From 293ec78069662311a876da75481a7f7456477030 Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Wed, 16 May 2018 17:48:33 +0100 Subject: [PATCH] build(aio): don't constrain `checkContentRules` to run before another processor (#24000) We don't really care when this processor runs as long as it happens after the tags have been extracted. By not constraining its `runBefore` property we can ensure that other processors can be run before it. PR Close #24000 --- .../angular-base-package/processors/checkContentRules.js | 2 +- .../angular-base-package/processors/checkContentRules.spec.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/aio/tools/transforms/angular-base-package/processors/checkContentRules.js b/aio/tools/transforms/angular-base-package/processors/checkContentRules.js index 148311b969..f12480dbca 100644 --- a/aio/tools/transforms/angular-base-package/processors/checkContentRules.js +++ b/aio/tools/transforms/angular-base-package/processors/checkContentRules.js @@ -32,7 +32,7 @@ module.exports = function checkContentRules(log, createDocMessage) { docTypeRules: {}, failOnContentErrors: false, $runAfter: ['tags-extracted'], - $runBefore: ['processing-docs'], + $runBefore: [], $process(docs) { const logMessage = this.failOnContentErrors ? log.error.bind(log) : log.warn.bind(log); const errors = []; diff --git a/aio/tools/transforms/angular-base-package/processors/checkContentRules.spec.js b/aio/tools/transforms/angular-base-package/processors/checkContentRules.spec.js index a5be9e5e59..8c0f500acd 100644 --- a/aio/tools/transforms/angular-base-package/processors/checkContentRules.spec.js +++ b/aio/tools/transforms/angular-base-package/processors/checkContentRules.spec.js @@ -18,7 +18,7 @@ describe('checkContentRules processor', function() { it('shpuld run at the right time', () => { expect(processor.$runAfter).toEqual(['tags-extracted']); - expect(processor.$runBefore).toEqual(['processing-docs']); + expect(processor.$runBefore).toEqual([]); }); it('should do nothing if not configured', () => {