honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(dev-infra): output the number of new and fixed cycles (#38805) 

This commit adds a logic to ouput the number of new and fixed cycles after running circular
dependency checker. This information is useful to better understand an impact of changes in case
the number of new/fixed cycles is relatively big.

PR Close #38805
This commit is contained in:
Andrew Kushnir 2020-09-10 18:15:32 -07:00 committed by Misko Hevery
parent 95b8a8706a
commit 2d6105a784
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dev-infra/ts-circular-dependencies/index.ts
View File

@ -112,7 +112,8 @@ export function main(
if (fixedCircularDeps.length !== 0) {
error(yellow(` Fixed circular dependencies that need to be removed from the golden:`));
fixedCircularDeps.forEach(c => error(` • ${convertReferenceChainToString(c)}`));
error();
info(yellow(`\n Total: ${newCircularDeps.length} new cycle(s), ${
fixedCircularDeps.length} fixed cycle(s). \n`));
if (approveCommand) {
info(yellow(` Please approve the new golden with: ${approveCommand}`));
} else {