From 2d96576a1011b00676c4874cbb47460119a0c089 Mon Sep 17 00:00:00 2001
From: Keen Yee Liau <kyliau@google.com>
Date: Thu, 22 Aug 2019 11:46:57 -0700
Subject: [PATCH] test: make largetable test work in g3 (#32275)

This PR modifies the `largetable` render3 (ivy) test so that it works in
g3.

1. `index.ts` must be named `index_aot.ts`
2. Scripts should be loaded via `ts_devserver` and not as an explicit
script tag in the HTML.

PR Close #32275
---
 .../src/largetable/render3/BUILD.bazel         | 18 ++++++++++--------
 .../src/largetable/render3/index.html          |  6 ------
 .../render3/{index.ts => index_aot.ts}         |  1 -
 3 files changed, 10 insertions(+), 15 deletions(-)
 rename modules/benchmarks/src/largetable/render3/{index.ts => index_aot.ts} (97%)

diff --git a/modules/benchmarks/src/largetable/render3/BUILD.bazel b/modules/benchmarks/src/largetable/render3/BUILD.bazel
index 1ef7685982..5309500cb3 100644
--- a/modules/benchmarks/src/largetable/render3/BUILD.bazel
+++ b/modules/benchmarks/src/largetable/render3/BUILD.bazel
@@ -6,7 +6,10 @@ load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
 
 ng_module(
     name = "largetable_lib",
-    srcs = glob(["**/*.ts"]),
+    srcs = [
+        "index_aot.ts",
+        "table.ts",
+    ],
     tags = ["ivy-only"],
     deps = [
         "//modules/benchmarks/src:util_lib",
@@ -14,13 +17,12 @@ ng_module(
         "//packages:types",
         "//packages/common",
         "//packages/core",
-        "@npm//reflect-metadata",
     ],
 )
 
 ng_rollup_bundle(
     name = "bundle",
-    entry_point = ":index.ts",
+    entry_point = ":index_aot.ts",
     tags = ["ivy-only"],
     deps = [
         ":largetable_lib",
@@ -30,12 +32,12 @@ ng_rollup_bundle(
 
 ts_devserver(
     name = "devserver",
-    static_files = [
-        ":bundle.min_debug.js",
-        ":bundle.min.js",
-        "index.html",
-    ],
+    index_html = "index.html",
+    port = 4200,
     tags = ["ivy-only"],
+    deps = [
+        ":bundle.min_debug.js",
+    ],
 )
 
 benchmark_test(
diff --git a/modules/benchmarks/src/largetable/render3/index.html b/modules/benchmarks/src/largetable/render3/index.html
index 41684174e7..20848764c7 100644
--- a/modules/benchmarks/src/largetable/render3/index.html
+++ b/modules/benchmarks/src/largetable/render3/index.html
@@ -28,12 +28,6 @@
     <largetable id="root"></largetable>
   </div>
 
-  <script>
-    // TODO(mlaval): remove once we have a proper solution
-    ngDevMode = false;
-    var bazelBundle = document.location.search.endsWith('debug') ? 'bundle.min_debug.js' : 'bundle.min.js';
-    document.write('<script src="' + bazelBundle + '">\u003c/script>');
-  </script>
 </body>
 
 </html>
diff --git a/modules/benchmarks/src/largetable/render3/index.ts b/modules/benchmarks/src/largetable/render3/index_aot.ts
similarity index 97%
rename from modules/benchmarks/src/largetable/render3/index.ts
rename to modules/benchmarks/src/largetable/render3/index_aot.ts
index caa6f2370d..77c3c8610d 100644
--- a/modules/benchmarks/src/largetable/render3/index.ts
+++ b/modules/benchmarks/src/largetable/render3/index_aot.ts
@@ -5,7 +5,6 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
-import 'reflect-metadata';
 import {ɵrenderComponent as renderComponent} from '@angular/core';
 
 import {bindAction, profile} from '../../util';