fix(compiler-cli): produce diagnostic messages in expression of PrefixNot node. (#33087)

PR Close #33087

packages/compiler-cli/src/diagnostics/expression_type.ts

@@ -304,6 +304,10 @@ export class AstType implements AstVisitor {
   }
 
   visitPrefixNot(ast: PrefixNot) {
+    // If we are producing diagnostics, visit the children
+    if (this.diagnostics) {
+      visitAstChildren(ast, this);
+    }
     // The type of a prefix ! is always boolean.
     return this.query.getBuiltinType(BuiltinType.Boolean);
   }

packages/compiler-cli/test/diagnostics/expression_diagnostics_spec.ts

@@ -98,6 +98,9 @@ describe('expression diagnostics', () => {
      () => reject(
          '<div *ngIf="persson">{{person.name.first}}</div>',
          'Identifier \'persson\' is not defined'));
+  it('should reject *ngIf of misspelled identifier in PrefixNot node',
+     () =>
+         reject('<div *ngIf="people && !persson"></div>', 'Identifier \'persson\' is not defined'));
   it('should accept an *ngFor', () => accept(`
       <div *ngFor="let p of people">
         {{p.name.first}} {{p.name.last}}