honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): export NgModuleFactory via r3_symbols for core factories (#25392)

Browse Source 
When @angular/core is compiled by ngtsc, a factory file is generated
for ApplicationModule, that is currently invalid because r3_symbols
does not export NgModuleFactory. This change fixes that issue and
ensures the generated ngfactory file for @angular/core is valid.

PR Close #25392
This commit is contained in:
Alex Rickabaugh 2018-08-06 15:52:26 +02:00 committed by Ben Lesh
parent 2befc65777
commit 33fd7e0784
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/compiler-cli/src/ngtsc/transform/src/translator.ts
View File

@ -46,6 +46,7 @@ const CORE_SUPPORTED_SYMBOLS = new Set<string>([
'ɵInjectableDef', 'ɵInjectableDef',
'ɵInjectorDef', 'ɵInjectorDef',
'ɵNgModuleDef', 'ɵNgModuleDef',
'ɵNgModuleFactory',
]); ]);
export class ImportManager { export class ImportManager {

2
packages/core/src/r3_symbols.ts
View File

@ -23,7 +23,7 @@ export {InjectableDef as ɵInjectableDef, InjectorDef as ɵInjectorDef, defineIn
export {inject} from './di/injector'; export {inject} from './di/injector';
export {NgModuleDef as ɵNgModuleDef} from './metadata/ng_module'; export {NgModuleDef as ɵNgModuleDef} from './metadata/ng_module';
export {defineNgModule as ɵdefineNgModule} from './render3/definition'; export {defineNgModule as ɵdefineNgModule} from './render3/definition';
export {NgModuleFactory as ɵNgModuleFactory} from './render3/ng_module_ref';
/** /**
* The existence of this constant (in this particular file) informs the Angular compiler that the * The existence of this constant (in this particular file) informs the Angular compiler that the

2
packages/core/test/bundling/todo/bundle.golden_symbols.json
View File

@ -198,7 +198,7 @@
"name": "ViewEncapsulation$1" "name": "ViewEncapsulation$1"
}, },
{ {
"name": "ViewRef$1" "name": "ViewRef"
}, },
{ {
"name": "_CLEAN_PROMISE" "name": "_CLEAN_PROMISE"