honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(animations): error when setting position before starting animation (#28255)

Browse Source 
it is now possible to set the position when the animation has not ever been started.

PR Close #28255
This commit is contained in:
Benjamin Kindle 2020-12-04 13:28:35 -05:00 committed by Andrew Scott
parent 09e1e1935a
commit 3b7d2ca179
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/animations/browser/src/render/web_animations/web_animations_player.ts
View File

@ -156,6 +156,9 @@ export class WebAnimationsPlayer implements AnimationPlayer {
} }
setPosition(p: number): void { setPosition(p: number): void {
if (this.domPlayer === undefined) {
this.init();
}
this.domPlayer.currentTime = p * this.time; this.domPlayer.currentTime = p * this.time;
} }

21
packages/animations/browser/test/render/web_animations/web_animations_player_spec.ts
View File

@ -67,6 +67,27 @@ import {WebAnimationsPlayer} from '../../../src/render/web_animations/web_animat
player.finish(); player.finish();
expect(log).toEqual(['started', 'done']); expect(log).toEqual(['started', 'done']);
}); });
it('should allow setting position before animation is started', () => {
const player = new WebAnimationsPlayer(element, [], {duration: 1000});
player.setPosition(0.5);
const p = innerPlayer!;
expect(p.log).toEqual(['pause']);
expect(p.currentTime).toEqual(500);
});
it('should continue playing animations from setPosition', () => {
const player = new WebAnimationsPlayer(element, [], {duration: 1000});
player.play();
const p = innerPlayer!;
expect(p.log).toEqual(['play']);
player.setPosition(0.5);
expect(p.currentTime).toEqual(500);
expect(p.log).toEqual(['play']);
});
}); });
} }