From 3d8ac06e4b3d50170cc2a1237db1d622c394a77b Mon Sep 17 00:00:00 2001 From: Keen Yee Liau Date: Mon, 22 Feb 2021 14:13:43 -0800 Subject: [PATCH] refactor(language-service): Clean up getTcb interface (#40954) `GetTcbResponse` should not be a union type with `undefined`. PR Close #40954 --- packages/language-service/api.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/language-service/api.ts b/packages/language-service/api.ts index ad5a203aea..fce2ea8c74 100644 --- a/packages/language-service/api.ts +++ b/packages/language-service/api.ts @@ -31,7 +31,7 @@ export type GetTcbResponse = { * code, `selections` is empty. */ selections: ts.TextSpan[], -}|undefined; +}; export type GetComponentLocationsForTemplateResponse = ts.DocumentSpan[]; @@ -40,6 +40,6 @@ export type GetComponentLocationsForTemplateResponse = ts.DocumentSpan[]; * whose API surface is a strict superset of TypeScript's language service. */ export interface NgLanguageService extends ts.LanguageService { - getTcb(fileName: string, position: number): GetTcbResponse; + getTcb(fileName: string, position: number): GetTcbResponse|undefined; getComponentLocationsForTemplate(fileName: string): GetComponentLocationsForTemplateResponse; }