From 3dc4df2ffa1ed0bc15112463f70f84ce7a735112 Mon Sep 17 00:00:00 2001 From: Yegor Jbanov Date: Thu, 16 Apr 2015 16:29:46 -0700 Subject: [PATCH] chore(analysis): analyze web folders; fix existing warnings --- modules/angular2/src/facade/collection.dart | 5 +++ modules/angular2/src/facade/collection.es6 | 3 ++ .../change_detection_benchmark.js | 1 - .../src/compiler/compiler_benchmark.js | 7 +--- .../src/largetable/largetable_benchmark.js | 36 ++-------------- .../src/naive_infinite_scroll/app.js | 4 +- .../src/naive_infinite_scroll/cells.js | 7 +--- .../src/naive_infinite_scroll/common.js | 24 +++++------ .../src/naive_infinite_scroll/index.js | 42 ++----------------- .../src/naive_infinite_scroll/scroll_area.js | 8 +--- .../src/naive_infinite_scroll/scroll_item.js | 9 +--- modules/benchmarks/src/tree/tree_benchmark.js | 30 +------------ .../src/tree/tree_benchmark.dart | 1 - .../examples/src/material/grid_list/index.js | 1 - modules/examples/src/todo/index.js | 2 - .../examples/src/todo/services/TodoStore.js | 10 ++--- tools/build/dartanalyzer.js | 11 +---- 17 files changed, 38 insertions(+), 163 deletions(-) diff --git a/modules/angular2/src/facade/collection.dart b/modules/angular2/src/facade/collection.dart index 17b8e534d7..e5b5e3c21e 100644 --- a/modules/angular2/src/facade/collection.dart +++ b/modules/angular2/src/facade/collection.dart @@ -154,6 +154,11 @@ class ListWrapper { static List slice(List l, int from, int to) { return l.sublist(from, to); } + static List splice(List l, int from, int to) { + var sub = l.sublist(from, to); + l.removeRange(from, to); + return sub; + } static void sort(List l, compareFn(a,b)) { l.sort(compareFn); } diff --git a/modules/angular2/src/facade/collection.es6 b/modules/angular2/src/facade/collection.es6 index 98ecb5c551..c6230b53ac 100644 --- a/modules/angular2/src/facade/collection.es6 +++ b/modules/angular2/src/facade/collection.es6 @@ -193,6 +193,9 @@ export class ListWrapper { static slice(l:List, from:int, to:int):List { return l.slice(from, to); } + static splice(l:List, from:int, to:int):List { + return l.splice(from, to); + } static sort(l:List, compareFn:Function) { l.sort(compareFn); } diff --git a/modules/benchmarks/src/change_detection/change_detection_benchmark.js b/modules/benchmarks/src/change_detection/change_detection_benchmark.js index bbe82e138e..5352c4866f 100644 --- a/modules/benchmarks/src/change_detection/change_detection_benchmark.js +++ b/modules/benchmarks/src/change_detection/change_detection_benchmark.js @@ -1,4 +1,3 @@ -import {ListWrapper, MapWrapper} from 'angular2/src/facade/collection'; import {reflector} from 'angular2/src/reflection/reflection'; import {isPresent, isJsObject} from 'angular2/src/facade/lang'; import {getIntParameter, bindAction, microBenchmark} from 'angular2/src/test_lib/benchmark_util'; diff --git a/modules/benchmarks/src/compiler/compiler_benchmark.js b/modules/benchmarks/src/compiler/compiler_benchmark.js index 7f88472517..48e36b0903 100644 --- a/modules/benchmarks/src/compiler/compiler_benchmark.js +++ b/modules/benchmarks/src/compiler/compiler_benchmark.js @@ -1,12 +1,10 @@ import {DOM} from 'angular2/src/dom/dom_adapter'; import {BrowserDomAdapter} from 'angular2/src/dom/browser_adapter'; -import {isBlank, Type} from 'angular2/src/facade/lang'; +import {Type} from 'angular2/src/facade/lang'; import {document} from 'angular2/src/facade/browser'; -import {MapWrapper} from 'angular2/src/facade/collection'; -import {DirectiveMetadata} from 'angular2/src/core/compiler/directive_metadata'; import {NativeShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/native_shadow_dom_strategy'; -import {Parser, Lexer, ProtoRecordRange, DynamicChangeDetection} from 'angular2/change_detection'; +import {Parser, Lexer, DynamicChangeDetection} from 'angular2/change_detection'; import {Compiler, CompilerCache} from 'angular2/src/core/compiler/compiler'; import {DirectiveMetadataReader} from 'angular2/src/core/compiler/directive_metadata_reader'; @@ -25,7 +23,6 @@ import {ReflectionCapabilities} from 'angular2/src/reflection/reflection_capabil import {getIntParameter, bindAction} from 'angular2/src/test_lib/benchmark_util'; import {ProtoViewFactory} from 'angular2/src/core/compiler/proto_view_factory'; -import {Renderer} from 'angular2/src/render/api'; import {DirectDomRenderer} from 'angular2/src/render/dom/direct_dom_renderer'; import * as rc from 'angular2/src/render/dom/compiler/compiler'; diff --git a/modules/benchmarks/src/largetable/largetable_benchmark.js b/modules/benchmarks/src/largetable/largetable_benchmark.js index 2a564ba96b..ff7e88dfe1 100644 --- a/modules/benchmarks/src/largetable/largetable_benchmark.js +++ b/modules/benchmarks/src/largetable/largetable_benchmark.js @@ -1,53 +1,24 @@ -import {Parser, Lexer, ChangeDetector, ChangeDetection, jitChangeDetection} -from 'angular2/change_detection'; -import {ExceptionHandler} from 'angular2/src/core/exception_handler'; +import {bootstrap, Component, View} from 'angular2/angular2'; -import {bootstrap, Component, Viewport, View, ViewContainer, Compiler, NgElement, Decorator} from 'angular2/angular2'; - -import {CompilerCache} from 'angular2/src/core/compiler/compiler'; -import {DirectiveMetadataReader} from 'angular2/src/core/compiler/directive_metadata_reader'; -import {TemplateLoader} from 'angular2/src/render/dom/compiler/template_loader'; -import {TemplateResolver} from 'angular2/src/core/compiler/template_resolver'; -import {ShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/shadow_dom_strategy'; -import {NativeShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/native_shadow_dom_strategy'; -import {EmulatedUnscopedShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/emulated_unscoped_shadow_dom_strategy'; import {LifeCycle} from 'angular2/src/core/life_cycle/life_cycle'; -import {UrlResolver} from 'angular2/src/services/url_resolver'; -import {StyleUrlResolver} from 'angular2/src/render/dom/shadow_dom/style_url_resolver'; -import {ComponentUrlMapper} from 'angular2/src/core/compiler/component_url_mapper'; -import {StyleInliner} from 'angular2/src/render/dom/shadow_dom/style_inliner'; -import {DynamicComponentLoader} from 'angular2/src/core/compiler/dynamic_component_loader'; -import {TestabilityRegistry, Testability} from 'angular2/src/core/testability/testability'; import {reflector} from 'angular2/src/reflection/reflection'; import {ReflectionCapabilities} from 'angular2/src/reflection/reflection_capabilities'; import {DOM} from 'angular2/src/dom/dom_adapter'; -import {isPresent, BaseException} from 'angular2/src/facade/lang'; import {window, document, gc} from 'angular2/src/facade/browser'; import {getIntParameter, getStringParameter, bindAction} from 'angular2/src/test_lib/benchmark_util'; -import {XHR} from 'angular2/src/services/xhr'; -import {XHRImpl} from 'angular2/src/services/xhr_impl'; - -import {If, For, Switch, SwitchWhen, SwitchDefault} from 'angular2/directives'; +import {For, Switch, SwitchWhen, SwitchDefault} from 'angular2/directives'; import {BrowserDomAdapter} from 'angular2/src/dom/browser_adapter'; -import {EventManager} from 'angular2/src/render/dom/events/event_manager'; - import {ListWrapper} from 'angular2/src/facade/collection'; -import {Parent} from 'angular2/src/core/annotations/visibility'; -import {ViewFactory, VIEW_POOL_CAPACITY} from 'angular2/src/core/compiler/view_factory'; -import {ProtoViewFactory} from 'angular2/src/core/compiler/proto_view_factory'; -import {Renderer} from 'angular2/src/render/api'; -import {DirectDomRenderer} from 'angular2/src/render/dom/direct_dom_renderer'; -import * as rc from 'angular2/src/render/dom/compiler/compiler'; -import * as rvf from 'angular2/src/render/dom/view/view_factory'; import {Inject, bind} from 'angular2/di'; export const BENCHMARK_TYPE = 'LargetableComponent.benchmarkType'; export const LARGETABLE_ROWS = 'LargetableComponent.rows'; export const LARGETABLE_COLS = 'LargetableComponent.cols'; + function _createBindings() { return [ bind(BENCHMARK_TYPE).toValue(getStringParameter('benchmarkType')), @@ -86,7 +57,6 @@ export function main() { var app; var lifecycle; var baselineRootLargetableComponent; - var count = 0; function ng2DestroyDom() { // TODO: We need an initial value as otherwise the getter for data.value will fail diff --git a/modules/benchmarks/src/naive_infinite_scroll/app.js b/modules/benchmarks/src/naive_infinite_scroll/app.js index 258dfbe0fe..5f030675e4 100644 --- a/modules/benchmarks/src/naive_infinite_scroll/app.js +++ b/modules/benchmarks/src/naive_infinite_scroll/app.js @@ -1,8 +1,6 @@ import {int, isPresent} from 'angular2/src/facade/lang'; -import {reflector} from 'angular2/src/reflection/reflection'; import {getIntParameter, bindAction} from 'angular2/src/test_lib/benchmark_util'; -import {bootstrap, Component, Viewport, View, ViewContainer, Compiler} - from 'angular2/angular2'; +import {Component, View} from 'angular2/angular2'; import {PromiseWrapper} from 'angular2/src/facade/async'; import {ListWrapper} from 'angular2/src/facade/collection'; import {ScrollAreaComponent} from './scroll_area'; diff --git a/modules/benchmarks/src/naive_infinite_scroll/cells.js b/modules/benchmarks/src/naive_infinite_scroll/cells.js index 904655d71b..884e006592 100644 --- a/modules/benchmarks/src/naive_infinite_scroll/cells.js +++ b/modules/benchmarks/src/naive_infinite_scroll/cells.js @@ -1,9 +1,4 @@ -import {int} from 'angular2/src/facade/lang'; -import {reflector} from 'angular2/src/reflection/reflection'; -import {getIntParameter, bindAction} from 'angular2/src/test_lib/benchmark_util'; -import {bootstrap, Component, Viewport, View, ViewContainer, Compiler} - from 'angular2/angular2'; -import {PromiseWrapper} from 'angular2/src/facade/async'; +import {Component, View} from 'angular2/angular2'; import {ListWrapper, MapWrapper} from 'angular2/src/facade/collection'; import {Company, Opportunity, Offering, Account, CustomDate, STATUS_LIST} from './common'; diff --git a/modules/benchmarks/src/naive_infinite_scroll/common.js b/modules/benchmarks/src/naive_infinite_scroll/common.js index 1121dfb953..2b4fbb6bb8 100644 --- a/modules/benchmarks/src/naive_infinite_scroll/common.js +++ b/modules/benchmarks/src/naive_infinite_scroll/common.js @@ -1,7 +1,5 @@ -import {int} from 'angular2/src/facade/lang'; import {Math} from 'angular2/src/facade/math'; -import {PromiseWrapper} from 'angular2/src/facade/async'; import {ListWrapper, MapWrapper} from 'angular2/src/facade/collection'; export var ITEMS = 1000; @@ -46,17 +44,17 @@ export var AAT_STATUS_LIST = [ // Just a non-trivial object. Nothing fancy or correct. export class CustomDate { - year: int; - month: int; - day: int; + year:number; + month:number; + day:number; - constructor(y:int, m:int, d:int) { + constructor(y:number, m:number, d:number) { this.year = y; this.month = m; this.day = d; } - addDays(days:int):CustomDate { + addDays(days:number):CustomDate { var newDay = this.day + days; var newMonth = this.month + Math.floor(newDay / 30); newDay = newDay % 30; @@ -154,13 +152,13 @@ export class Offering extends RawEntity { this.set('account', val); } - get basePoints():int { return this.get('basePoints'); } - set basePoints(val:int) { + get basePoints():number { return this.get('basePoints'); } + set basePoints(val:number) { this.set('basePoints', val); } - get kickerPoints():int { return this.get('kickerPoints'); } - set kickerPoints(val:int) { + get kickerPoints():number { return this.get('kickerPoints'); } + set kickerPoints(val:number) { this.set('kickerPoints', val); } @@ -198,8 +196,8 @@ export class Opportunity extends RawEntity { } export class Account extends RawEntity { - get accountId():int { return this.get('accountId'); } - set accountId(val:int) { + get accountId():number { return this.get('accountId'); } + set accountId(val:number) { this.set('accountId', val); } } diff --git a/modules/benchmarks/src/naive_infinite_scroll/index.js b/modules/benchmarks/src/naive_infinite_scroll/index.js index 2828909995..cd6070c3ca 100644 --- a/modules/benchmarks/src/naive_infinite_scroll/index.js +++ b/modules/benchmarks/src/naive_infinite_scroll/index.js @@ -1,48 +1,13 @@ -import {int, isBlank} from 'angular2/src/facade/lang'; -import {DOM} from 'angular2/src/dom/dom_adapter'; import {MapWrapper} from 'angular2/src/facade/collection'; -import {Parser, Lexer, ChangeDetector, ChangeDetection} - from 'angular2/change_detection'; -import {ExceptionHandler} from 'angular2/src/core/exception_handler'; -import { - bootstrap, Component, Viewport, View, ViewContainer, Compiler, onChange, NgElement, Decorator -} from 'angular2/angular2'; +import {bootstrap} from 'angular2/angular2'; import {reflector} from 'angular2/src/reflection/reflection'; import {ReflectionCapabilities} from 'angular2/src/reflection/reflection_capabilities'; -import {CompilerCache} from 'angular2/src/core/compiler/compiler'; -import {DirectiveMetadataReader} from 'angular2/src/core/compiler/directive_metadata_reader'; -import {ShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/shadow_dom_strategy'; -import {NativeShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/native_shadow_dom_strategy'; -import {EmulatedUnscopedShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/emulated_unscoped_shadow_dom_strategy'; -import {TemplateLoader} from 'angular2/src/render/dom/compiler/template_loader'; -import {TemplateResolver} from 'angular2/src/core/compiler/template_resolver'; -import {LifeCycle} from 'angular2/src/core/life_cycle/life_cycle'; -import {XHR} from 'angular2/src/services/xhr'; -import {XHRImpl} from 'angular2/src/services/xhr_impl'; -import {UrlResolver} from 'angular2/src/services/url_resolver'; -import {StyleUrlResolver} from 'angular2/src/render/dom/shadow_dom/style_url_resolver'; -import {ComponentUrlMapper} from 'angular2/src/core/compiler/component_url_mapper'; -import {StyleInliner} from 'angular2/src/render/dom/shadow_dom/style_inliner'; -import {DynamicComponentLoader} from 'angular2/src/core/compiler/dynamic_component_loader'; -import {TestabilityRegistry, Testability} from 'angular2/src/core/testability/testability'; -import {If, For} from 'angular2/directives'; import {App} from './app'; -import {ScrollAreaComponent} from './scroll_area'; -import {ScrollItemComponent} from './scroll_item'; -import {CompanyNameComponent, OpportunityNameComponent, OfferingNameComponent, - AccountCellComponent, StageButtonsComponent, FormattedCellComponent} - from './cells'; -import {EventManager} from 'angular2/src/render/dom/events/event_manager'; -import {ViewFactory, VIEW_POOL_CAPACITY} from 'angular2/src/core/compiler/view_factory'; -import {ProtoViewFactory} from 'angular2/src/core/compiler/proto_view_factory'; -import {Renderer} from 'angular2/src/render/api'; -import {DirectDomRenderer} from 'angular2/src/render/dom/direct_dom_renderer'; -import * as rc from 'angular2/src/render/dom/compiler/compiler'; -import * as rvf from 'angular2/src/render/dom/view/view_factory'; -import {Inject, bind} from 'angular2/di'; +import {VIEW_POOL_CAPACITY} from 'angular2/src/core/compiler/view_factory'; +import {bind} from 'angular2/di'; export function main() { setupReflector(); @@ -59,7 +24,6 @@ export function setupReflector() { // TODO(kegluneq): Generate this. reflector.registerSetters({ 'style': (o, m) => { - //if (isBlank(m)) return; // HACK MapWrapper.forEach(m, function(v, k) { o.style.setProperty(k, v); diff --git a/modules/benchmarks/src/naive_infinite_scroll/scroll_area.js b/modules/benchmarks/src/naive_infinite_scroll/scroll_area.js index a2d2e9fdeb..85073d45bf 100644 --- a/modules/benchmarks/src/naive_infinite_scroll/scroll_area.js +++ b/modules/benchmarks/src/naive_infinite_scroll/scroll_area.js @@ -1,11 +1,5 @@ -import {int, FINAL} from 'angular2/src/facade/lang'; -import {reflector} from 'angular2/src/reflection/reflection'; -import {getIntParameter, bindAction} from 'angular2/src/test_lib/benchmark_util'; -import {Component, Viewport, View, ViewContainer, Compiler} - from 'angular2/angular2'; -import {PromiseWrapper} from 'angular2/src/facade/async'; +import {Component, View} from 'angular2/angular2'; import {ListWrapper, MapWrapper} from 'angular2/src/facade/collection'; -import {DOM} from 'angular2/src/dom/dom_adapter'; import {Math} from 'angular2/src/facade/math'; import {Offering, ITEMS, ITEM_HEIGHT, VISIBLE_ITEMS, VIEW_PORT_HEIGHT, diff --git a/modules/benchmarks/src/naive_infinite_scroll/scroll_item.js b/modules/benchmarks/src/naive_infinite_scroll/scroll_item.js index 19ec32069e..42a76f1611 100644 --- a/modules/benchmarks/src/naive_infinite_scroll/scroll_item.js +++ b/modules/benchmarks/src/naive_infinite_scroll/scroll_item.js @@ -1,11 +1,5 @@ -import {int} from 'angular2/src/facade/lang'; -import {reflector} from 'angular2/src/reflection/reflection'; -import {Component, Viewport, View, ViewContainer, Compiler} - from 'angular2/angular2'; -import {PromiseWrapper} from 'angular2/src/facade/async'; +import {Component, View} from 'angular2/angular2'; import {ListWrapper, MapWrapper} from 'angular2/src/facade/collection'; -import {DOM} from 'angular2/src/dom/dom_adapter'; -import {Math} from 'angular2/src/facade/math'; import {CompanyNameComponent, OpportunityNameComponent, OfferingNameComponent, StageButtonsComponent, AccountCellComponent, FormattedCellComponent} from './cells'; @@ -14,7 +8,6 @@ import {Offering, ITEM_HEIGHT, COMPANY_NAME_WIDTH, OPPORTUNITY_NAME_WIDTH, OFFERING_NAME_WIDTH, ACCOUNT_CELL_WIDTH, BASE_POINTS_WIDTH, KICKER_POINTS_WIDTH, STAGE_BUTTONS_WIDTH, BUNDLES_WIDTH, DUE_DATE_WIDTH, END_DATE_WIDTH, AAT_STATUS_WIDTH} from './common'; -import {generateOfferings} from './random_data'; @Component({ selector: 'scroll-item', diff --git a/modules/benchmarks/src/tree/tree_benchmark.js b/modules/benchmarks/src/tree/tree_benchmark.js index 37ec613195..f8818bb2e9 100644 --- a/modules/benchmarks/src/tree/tree_benchmark.js +++ b/modules/benchmarks/src/tree/tree_benchmark.js @@ -1,45 +1,17 @@ -import {Parser, Lexer, ChangeDetector, ChangeDetection, jitChangeDetection} - from 'angular2/change_detection'; -import {ExceptionHandler} from 'angular2/src/core/exception_handler'; - import {bootstrap, Component, Viewport, View, ViewContainer, Compiler, NgElement, Decorator} from 'angular2/angular2'; -import {CompilerCache} from 'angular2/src/core/compiler/compiler'; -import {DirectiveMetadataReader} from 'angular2/src/core/compiler/directive_metadata_reader'; -import {TemplateLoader} from 'angular2/src/render/dom/compiler/template_loader'; -import {TemplateResolver} from 'angular2/src/core/compiler/template_resolver'; -import {ShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/shadow_dom_strategy'; -import {NativeShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/native_shadow_dom_strategy'; -import {EmulatedUnscopedShadowDomStrategy} from 'angular2/src/render/dom/shadow_dom/emulated_unscoped_shadow_dom_strategy'; import {LifeCycle} from 'angular2/src/core/life_cycle/life_cycle'; -import {UrlResolver} from 'angular2/src/services/url_resolver'; -import {StyleUrlResolver} from 'angular2/src/render/dom/shadow_dom/style_url_resolver'; -import {ComponentUrlMapper} from 'angular2/src/core/compiler/component_url_mapper'; -import {StyleInliner} from 'angular2/src/render/dom/shadow_dom/style_inliner'; -import {DynamicComponentLoader} from 'angular2/src/core/compiler/dynamic_component_loader'; -import {TestabilityRegistry, Testability} from 'angular2/src/core/testability/testability'; - import {reflector} from 'angular2/src/reflection/reflection'; import {ReflectionCapabilities} from 'angular2/src/reflection/reflection_capabilities'; import {DOM} from 'angular2/src/dom/dom_adapter'; import {isPresent} from 'angular2/src/facade/lang'; import {window, document, gc} from 'angular2/src/facade/browser'; import {getIntParameter, getStringParameter, bindAction} from 'angular2/src/test_lib/benchmark_util'; - -import {XHR} from 'angular2/src/services/xhr'; -import {XHRImpl} from 'angular2/src/services/xhr_impl'; - import {If} from 'angular2/directives'; import {BrowserDomAdapter} from 'angular2/src/dom/browser_adapter'; - -import {EventManager} from 'angular2/src/render/dom/events/event_manager'; import {ViewFactory, VIEW_POOL_CAPACITY} from 'angular2/src/core/compiler/view_factory'; -import {ProtoViewFactory} from 'angular2/src/core/compiler/proto_view_factory'; -import {Renderer} from 'angular2/src/render/api'; -import {DirectDomRenderer} from 'angular2/src/render/dom/direct_dom_renderer'; -import * as rc from 'angular2/src/render/dom/compiler/compiler'; import * as rvf from 'angular2/src/render/dom/view/view_factory'; -import {Inject, bind} from 'angular2/di'; +import {bind} from 'angular2/di'; function createBindings():List { var viewCacheCapacity = getStringParameter('viewcache') == 'true' ? 10000 : 1; diff --git a/modules/benchmarks_external/src/tree/tree_benchmark.dart b/modules/benchmarks_external/src/tree/tree_benchmark.dart index fc28619df2..09f005417b 100644 --- a/modules/benchmarks_external/src/tree/tree_benchmark.dart +++ b/modules/benchmarks_external/src/tree/tree_benchmark.dart @@ -3,7 +3,6 @@ library tree_benchmark_ng10; import 'package:angular/angular.dart'; import 'package:angular/application_factory.dart'; -import 'dart:html'; import 'package:angular2/src/test_lib/benchmark_util.dart'; setup() { diff --git a/modules/examples/src/material/grid_list/index.js b/modules/examples/src/material/grid_list/index.js index 2d938c90ad..e3e0e32f05 100644 --- a/modules/examples/src/material/grid_list/index.js +++ b/modules/examples/src/material/grid_list/index.js @@ -1,6 +1,5 @@ import {bootstrap, Component, View} from 'angular2/angular2'; import {MdGridList, MdGridTile} from 'angular2_material/src/components/grid_list/grid_list' -import {MdTheme} from 'angular2_material/src/core/theme' import {UrlResolver} from 'angular2/src/services/url_resolver'; import {commonDemoSetup, DemoUrlResolver} from '../demo_common'; import {bind} from 'angular2/di'; diff --git a/modules/examples/src/todo/index.js b/modules/examples/src/todo/index.js index c3a413a6ad..b2b3468c59 100644 --- a/modules/examples/src/todo/index.js +++ b/modules/examples/src/todo/index.js @@ -39,7 +39,6 @@ class TodoApp { var target = $event.target; if(which === 13) { todo.title = target.value; - this.todoStore.save(todo); this.todoEdit = null; } else if (which === 27) { this.todoEdit = null; @@ -63,7 +62,6 @@ class TodoApp { var isComplete = $event.target.checked; this.todoStore.list.forEach((todo) => { todo.completed = isComplete; - this.todoStore.save(todo); }); } diff --git a/modules/examples/src/todo/services/TodoStore.js b/modules/examples/src/todo/services/TodoStore.js index 751c7656dd..2ba4285ea2 100644 --- a/modules/examples/src/todo/services/TodoStore.js +++ b/modules/examples/src/todo/services/TodoStore.js @@ -2,9 +2,9 @@ import {ListWrapper} from 'angular2/src/facade/collection'; // base model for RecordStore export class KeyModel { - _key: number; - constructor(key: number) { - this._key = key; + key:number; + constructor(k:number) { + this.key = k; } } @@ -45,7 +45,7 @@ export class Store { } add(record: KeyModel) { - this.list.push(record); + ListWrapper.push(this.list, record); } remove(record: KeyModel) { @@ -60,7 +60,7 @@ export class Store { spliceOut(record: KeyModel) { var i = this.indexFor(record); if( i > -1 ) { - return this.list.splice(i, 1)[0]; + return ListWrapper.splice(this.list, i, 1)[0]; } return null; } diff --git a/tools/build/dartanalyzer.js b/tools/build/dartanalyzer.js index a5a1ff4d65..144d018f9b 100644 --- a/tools/build/dartanalyzer.js +++ b/tools/build/dartanalyzer.js @@ -22,7 +22,7 @@ module.exports = function(gulp, plugins, config) { var analyzeFile = ['library _analyzer;']; srcFiles.concat(testFiles).forEach(function(fileName, index) { if (fileName !== tempFile && fileName.indexOf("/packages/") === -1) { - analyzeFile.push('import "./'+fileName+'" as mod'+index+';'); + analyzeFile.push('import "./' + fileName + '" as mod' + index + ';'); } }); fs.writeFileSync(path.join(dir, tempFile), analyzeFile.join('\n')); @@ -73,15 +73,6 @@ module.exports = function(gulp, plugins, config) { } var skip = false; - // TODO: not reporting issues in web for now - // Should be removed when https://github.com/angular/angular/issues/1392 - // is fixed - var webDir = path.join(dirName, 'web'); - if (line.indexOf(webDir) >= 0) { - skip = true; - line = '(TODO #1392) ' + line; - } - if (!skip) { if (line.match(/\[hint\]/)) { hintCount++;