ci(docs-infra): use the regular (non-Ivy) Angular packages in `test_docs_examples_ivy` CI job (#36015)
The docs examples tests are run both with Ivy turned off and on. When Ivy is turned on, ngcc is used to convert all dependencies (including the Angular framework packages to Ivy). Previously, in order to speed things up, the `test_docs_examples_ivy` CI job would use Angular packages built with Ivy (from `dist/packages-dist-ivy-aot`). This however was a deviation from what happens in real-world applications. This commit changes the `test_docs_examples_ivy` CI job to always use the regular Angular packages (as published on npm) and use ngcc to convert them to Ivy. Relevant discussion: https://github.com/angular/angular/pull/35091#discussion_r373775396 PR Close #36015
This commit is contained in:
parent
9e70bcb34f
commit
3e08347d8a
|
@ -464,17 +464,6 @@ jobs:
|
||||||
- install_chrome_libs
|
- install_chrome_libs
|
||||||
# Install aio
|
# Install aio
|
||||||
- run: yarn --cwd aio install --frozen-lockfile --non-interactive
|
- run: yarn --cwd aio install --frozen-lockfile --non-interactive
|
||||||
- when:
|
|
||||||
condition: << parameters.ivy >>
|
|
||||||
steps:
|
|
||||||
# Rename the "dist/*-dist-ivy-aot" packages directories (persisted to the workspace by
|
|
||||||
# the `build-ivy-npm-packages` job) to "dist/*-dist" as the AIO package installer
|
|
||||||
# picks up the locally built packages from that location.
|
|
||||||
# *Note*: We could also adjust the packages installer, but given we won't have
|
|
||||||
# two different folders of Angular distributions in the future, we should keep
|
|
||||||
# the packages installer unchanged.
|
|
||||||
- run: mv dist/packages-dist-ivy-aot dist/packages-dist
|
|
||||||
- run: mv dist/zone.js-dist-ivy-aot dist/zone.js-dist
|
|
||||||
# Run examples tests. The "CIRCLE_NODE_INDEX" will be set if "parallelism" is enabled.
|
# Run examples tests. The "CIRCLE_NODE_INDEX" will be set if "parallelism" is enabled.
|
||||||
# Since the parallelism is set to "5", there will be five parallel CircleCI containers.
|
# Since the parallelism is set to "5", there will be five parallel CircleCI containers.
|
||||||
# with either "0", "1", etc as node index. This can be passed to the "--shard" argument.
|
# with either "0", "1", etc as node index. This can be passed to the "--shard" argument.
|
||||||
|
@ -832,7 +821,7 @@ workflows:
|
||||||
name: test_docs_examples_ivy
|
name: test_docs_examples_ivy
|
||||||
ivy: true
|
ivy: true
|
||||||
requires:
|
requires:
|
||||||
- build-ivy-npm-packages
|
- build-npm-packages
|
||||||
- aio_preview:
|
- aio_preview:
|
||||||
# Only run on PR builds. (There can be no previews for non-PR builds.)
|
# Only run on PR builds. (There can be no previews for non-PR builds.)
|
||||||
<<: *only_on_pull_requests
|
<<: *only_on_pull_requests
|
||||||
|
|
Loading…
Reference in New Issue