honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build: fix linting against jasmine focus functions (#42415) 

We were linting against usages of `fdescribe` and `fit` by referencing the `no-jasmine-focus` rule which isn't installed, causing tslint to log the following:

```
Could not find implementations for the following rules specified in the configuration:
    no-jasmine-focus
Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
If TSLint was recently upgraded, you may have old rules configured which need to be cleaned
```

These changes switch to using the built-in `ban` rule.

PR Close #42415
This commit is contained in:
Kristiyan Kostadinov 2021-05-29 13:25:53 +02:00 committed by Andrew Kushnir
parent 1d9c6bb31d
commit 3e192bfa4d
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/examples/testing/ts/testing.ts
View File

@ -18,7 +18,7 @@ describe('some component', () => {
}); });
}); });
/* tslint:disable-next-line:no-jasmine-focus */ // tslint:disable-next-line:ban
fdescribe('some component', () => { fdescribe('some component', () => {
it('has a test', it('has a test',
() => { () => {
@ -44,7 +44,7 @@ describe('another component', () => {
}); });
describe('some component', () => { describe('some component', () => {
/* tslint:disable-next-line:no-jasmine-focus */ // tslint:disable-next-line:ban
fit('has a test', fit('has a test',
() => { () => {
// This test will run. // This test will run.

14
tslint.json
View File

@ -20,7 +20,6 @@
"no-construct": true, "no-construct": true,
"no-duplicate-imports": true, "no-duplicate-imports": true,
"no-duplicate-variable": true, "no-duplicate-variable": true,
"no-jasmine-focus": true,
"no-var-keyword": true, "no-var-keyword": true,
"prefer-literal": [ "prefer-literal": [
true, true,
@ -49,7 +48,12 @@
true, true,
"function" "function"
], ],
"no-debugger": true "no-debugger": true,
"ban": [
true,
{"name": "fdescribe", "message": "Don't keep jasmine focus methods."},
{"name": "fit", "message": "Don't keep jasmine focus methods."}
]
}, },
"jsRules": { "jsRules": {
"file-header": [ "file-header": [
@ -65,7 +69,6 @@
], ],
"no-duplicate-imports": true, "no-duplicate-imports": true,
"no-duplicate-variable": true, "no-duplicate-variable": true,
"no-jasmine-focus": true,
"require-internal-with-underscore": true, "require-internal-with-underscore": true,
"semicolon": [ "semicolon": [
true true
@ -77,6 +80,11 @@
"no-inner-declarations": [ "no-inner-declarations": [
true, true,
"function" "function"
],
"ban": [
true,
{"name": "fdescribe", "message": "Don't keep jasmine focus methods."},
{"name": "fit", "message": "Don't keep jasmine focus methods."}
] ]
}, },
"linterOptions": { "linterOptions": {