diff --git a/.pullapprove.yml b/.pullapprove.yml index b7b7f701fc..c5fe246e47 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -229,6 +229,10 @@ groups: 'aio/content/guide/route-animations.md', 'aio/content/guide/transition-and-triggers.md' ]) + labels: + pending: "comp: animations" + approved: "comp: animations" + rejected: "comp: animations" reviewers: users: - crisbeto @@ -254,6 +258,10 @@ groups: 'aio/content/guide/aot-metadata-errors.md', 'aio/content/guide/template-typecheck.md ' ]) + labels: + pending: "comp: compiler" + approved: "comp: compiler" + rejected: "comp: compiler" reviewers: users: - alxhub @@ -270,6 +278,10 @@ groups: - *can-be-global-approved - *can-be-global-docs-approved - files.include('packages/compiler-cli/ngcc/**') + labels: + pending: "comp: ngcc" + approved: "comp: ngcc" + rejected: "comp: ngcc" reviewers: users: - alxhub @@ -287,6 +299,10 @@ groups: - *can-be-global-approved - *can-be-global-docs-approved - files.include("packages/core/schematics/**") + labels: + pending: "comp: migrations" + approved: "comp: migrations" + rejected: "comp: migrations" reviewers: users: - alxhub @@ -306,11 +322,9 @@ groups: contains_any_globs(files.exclude("packages/core/schematics/**"), [ 'packages/core/**', 'packages/examples/core/**', - 'packages/common/**', 'packages/platform-browser/**', 'packages/examples/platform-browser/**', 'packages/platform-browser-dynamic/**', - 'packages/examples/common/**', 'packages/docs/**', 'aio/content/guide/accessibility.md', 'aio/content/examples/accessibility/**', @@ -424,6 +438,10 @@ groups: 'aio/content/examples/user-input/**', 'aio/content/images/guide/user-input/**' ]) + labels: + pending: "comp: core" + approved: "comp: core" + rejected: "comp: core" reviewers: users: - alxhub @@ -435,6 +453,34 @@ groups: # OOO as of 2020-09-28 - pkozlowski-opensource + # ========================================================= + # Framework: Common + # ========================================================= + fw-common: + <<: *defaults + conditions: + - *can-be-global-approved + - *can-be-global-docs-approved + - > + contains_any_globs(files.exclude("packages/core/schematics/**"), [ + 'packages/common/**', + 'packages/examples/common/**', + ]) + labels: + pending: "comp: common" + approved: "comp: common" + rejected: "comp: common" + reviewers: + users: + - alxhub + - AndrewKushnir + - atscott + - ~kara # do not request reviews from Kara, but allow her to approve PRs + - mhevery + - jessicajaniuk + # OOO as of 2020-09-28 - pkozlowski-opensource + + # ========================================================= # Framework: Http # ========================================================= @@ -451,6 +497,10 @@ groups: 'aio/content/examples/http/**', 'aio/content/images/guide/http/**' ]) + labels: + pending: "comp: common/http" + approved: "comp: common/http" + rejected: "comp: common/http" reviewers: users: - alxhub @@ -472,6 +522,10 @@ groups: 'aio/content/images/guide/elements/**', 'aio/content/guide/elements.md' ]) + labels: + pending: "comp: elements" + approved: "comp: elements" + rejected: "comp: elements" reviewers: users: - andrewseguin @@ -506,6 +560,10 @@ groups: 'aio/content/examples/reactive-forms/**', 'aio/content/images/guide/reactive-forms/**' ]) + labels: + pending: "comp: forms" + approved: "comp: forms" + rejected: "comp: forms" reviewers: users: - AndrewKushnir @@ -538,6 +596,10 @@ groups: 'aio/content/guide/i18n.md', 'aio/content/examples/i18n/**' ]) + labels: + pending: "comp: i18n" + approved: "comp: i18n" + rejected: "comp: i18n" reviewers: users: - AndrewKushnir @@ -559,6 +621,10 @@ groups: 'aio/content/guide/universal.md', 'aio/content/examples/universal/**' ]) + labels: + pending: "comp: server" + approved: "comp: server" + rejected: "comp: server" reviewers: users: - alxhub @@ -584,6 +650,10 @@ groups: 'aio/content/examples/router/**', 'aio/content/images/guide/router/**' ]) + labels: + pending: "comp: router" + approved: "comp: router" + rejected: "comp: router" reviewers: users: - atscott @@ -610,6 +680,10 @@ groups: 'aio/content/guide/service-worker-intro.md', 'aio/content/images/guide/service-worker/**' ]) + labels: + pending: "comp: service-worker" + approved: "comp: service-worker" + rejected: "comp: service-worker" reviewers: users: - alxhub @@ -642,6 +716,10 @@ groups: 'aio/content/guide/ajs-quick-reference.md', 'aio/content/examples/ajs-quick-reference/**' ]) + labels: + pending: "comp: upgrade" + approved: "comp: upgrade" + rejected: "comp: upgrade" reviewers: users: - gkalpak @@ -671,6 +749,10 @@ groups: 'aio/content/examples/testing/**', 'aio/content/images/guide/testing/**' ]) + labels: + pending: "comp: testing" + approved: "comp: testing" + rejected: "comp: testing" reviewers: users: - AndrewKushnir @@ -689,6 +771,10 @@ groups: contains_any_globs(files, [ 'modules/benchmarks/**' ]) + labels: + pending: "comp: performance" + approved: "comp: performance" + rejected: "comp: performance" reviewers: users: - IgorMinar @@ -737,6 +823,10 @@ groups: - mhevery - jelbourn # OOO as of 2020-09-28 - pkozlowski-opensource + labels: + pending: "comp: security" + approved: "comp: security" + rejected: "comp: security" reviews: request: -1 # request reviews from everyone required: 2 # require at least 2 approvals @@ -755,6 +845,10 @@ groups: contains_any_globs(files, [ 'packages/bazel/**', ]) + labels: + pending: "comp: bazel" + approved: "comp: bazel" + rejected: "comp: bazel" reviewers: users: - IgorMinar @@ -776,6 +870,10 @@ groups: 'aio/content/guide/language-service.md', 'aio/content/images/guide/language-service/**' ]) + labels: + pending: "comp: language-service" + approved: "comp: language-service" + rejected: "comp: language-service" reviewers: users: - ayazhafiz @@ -796,6 +894,10 @@ groups: 'packages/zone.js/**', 'aio/content/guide/zone.md' ]) + labels: + pending: "comp: zones" + approved: "comp: zones" + rejected: "comp: zones" reviewers: users: - JiaLiPassion @@ -812,6 +914,10 @@ groups: contains_any_globs(files, [ 'packages/misc/angular-in-memory-web-api/**', ]) + labels: + pending: "comp: in-memory-web-api" + approved: "comp: in-memory-web-api" + rejected: "comp: in-memory-web-api" reviewers: users: - IgorMinar @@ -829,6 +935,10 @@ groups: contains_any_globs(files, [ 'packages/benchpress/**' ]) + labels: + pending: "comp: benchpress" + approved: "comp: benchpress" + rejected: "comp: benchpress" reviewers: users: - alxhub @@ -846,6 +956,10 @@ groups: contains_any_globs(files, [ 'integration/**' ]) + labels: + pending: "comp: testing" + approved: "comp: testing" + rejected: "comp: testing" reviewers: users: - IgorMinar @@ -879,6 +993,10 @@ groups: 'aio/content/start/**', 'aio/content/images/guide/start/**' ]) + labels: + pending: "comp: examples" + approved: "comp: examples" + rejected: "comp: examples" reviewers: users: - aikidave @@ -904,6 +1022,10 @@ groups: 'aio/content/license.md', 'aio/content/navigation.json' ]) + labels: + pending: "comp: docs" + approved: "comp: docs" + rejected: "comp: docs" reviewers: users: - aikidave @@ -931,6 +1053,10 @@ groups: 'aio/content/guide/rx-library.md', 'aio/content/examples/rx-library/**' ]) + labels: + pending: "comp: docs" + approved: "comp: docs" + rejected: "comp: docs" reviewers: users: - alxhub @@ -964,6 +1090,10 @@ groups: 'aio/content/guide/ivy-compatibility.md', 'aio/content/guide/ivy-compatibility-examples.md' ]) + labels: + pending: "comp: docs" + approved: "comp: docs" + rejected: "comp: docs" reviewers: users: - IgorMinar @@ -990,6 +1120,10 @@ groups: - clydin - kyliau - IgorMinar + labels: + pending: "comp: compiler" + approved: "comp: compiler" + rejected: "comp: compiler" reviews: request: -1 # request reviews from everyone required: 2 # require at least 2 approvals @@ -1024,6 +1158,10 @@ groups: 'aio/content/guide/migration-update-module-and-target-compiler-options.md', 'aio/content/guide/migration-update-libraries-tslib.md', ]) + labels: + pending: "comp: docs" + approved: "comp: docs" + rejected: "comp: docs" reviewers: users: - alan-agius4 @@ -1046,6 +1184,10 @@ groups: 'aio/content/guide/libraries.md', 'aio/content/guide/using-libraries.md' ]) + labels: + pending: "comp: docs" + approved: "comp: docs" + rejected: "comp: docs" reviewers: users: - alan-agius4 @@ -1069,6 +1211,10 @@ groups: 'aio/content/images/guide/schematics/**', 'aio/content/examples/schematics-for-libraries/**' ]) + labels: + pending: "comp: docs" + approved: "comp: docs" + rejected: "comp: docs" reviewers: users: - alan-agius4 @@ -1099,6 +1245,10 @@ groups: 'aio/content/images/guide/docs-style-guide/**', 'aio/content/guide/visual-studio-2015.md' ]) + labels: + pending: "comp: docs-infra" + approved: "comp: docs-infra" + rejected: "comp: docs-infra" reviewers: users: - gkalpak @@ -1166,6 +1316,10 @@ groups: '**/*.bzl', '**/*.bazel' ]) + labels: + pending: "comp: dev-infra" + approved: "comp: dev-infra" + rejected: "comp: dev-infra" reviewers: users: # OOO as of 2020-09-28 - devversion @@ -1203,6 +1357,10 @@ groups: - jelbourn - petebacondarwin # OOO as of 2020-09-28 - pkozlowski-opensource + labels: + pending: "comp: docs/api" + approved: "comp: docs/api" + rejected: "comp: docs/api" reviews: request: 4 # Request reviews from four people required: 3 # Require that three people approve @@ -1231,6 +1389,10 @@ groups: - jelbourn - petebacondarwin # OOO as of 2020-09-28 - pkozlowski-opensource + labels: + pending: "comp: build & ci" + approved: "comp: build & ci" + rejected: "comp: build & ci" reviews: request: 4 # Request reviews from four people required: 2 # Require that two people approve @@ -1250,6 +1412,10 @@ groups: contains_any_globs(files, [ 'goldens/circular-deps/packages.json' ]) + labels: + pending: "comp: build & ci" + approved: "comp: build & ci" + rejected: "comp: build & ci" reviewers: users: - AndrewKushnir @@ -1276,6 +1442,10 @@ groups: contains_any_globs(files, [ '.pullapprove.yml' ]) + labels: + pending: "comp: build & ci" + approved: "comp: build & ci" + rejected: "comp: build & ci" reviewers: users: - AndrewKushnir