From 43597279d691ae784d6f42d85d97d8a39cd64d56 Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Wed, 16 May 2018 10:10:57 -0700 Subject: [PATCH] test: don't run unit tests on Firefox (#23942) PR Close #23942 --- tools/defaults.bzl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/defaults.bzl b/tools/defaults.bzl index 8a956ca64f..9954668f3d 100644 --- a/tools/defaults.bzl +++ b/tools/defaults.bzl @@ -79,12 +79,16 @@ def ts_web_test_suite(bootstrap = [], deps = [], **kwargs): _ts_web_test_suite( bootstrap = bootstrap, deps = local_deps, - # Run unit tests on Chromium and Firefox by default. + # Run unit tests on local Chromium by default. # You can exclude tests based on tags, e.g. to skip Firefox testing, # `bazel test --test_tag_filters=-browser:firefox-local [targets]` browsers = [ "@io_bazel_rules_webtesting//browsers:chromium-local", - "@io_bazel_rules_webtesting//browsers:firefox-local", + # Don't test on local Firefox by default, for faster builds. + # We think that bugs in Angular tend to be caught the same in any + # evergreen browser. + # "@io_bazel_rules_webtesting//browsers:firefox-local", + # TODO(alexeagle): add remote browsers on SauceLabs ], **kwargs)