honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf(ivy): avoid repeated tNode.initialInputs reads (#33322) 

PR Close #33322
This commit is contained in:
Pawel Kozlowski 2019-10-22 16:42:23 +02:00 committed by atscott
parent 41caafcaf2
commit 4452d6d848
3 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/core/src/render3/instructions/shared.ts
View File

@ -1103,6 +1103,7 @@ function instantiateAllDirectives(
attachPatchData(native, lView);
const initialInputs = tNode.initialInputs;
for (let i = start; i < end; i++) {
const def = tView.data[i] as DirectiveDef<any>;
const isComponent = isComponentDef(def);
@ -1115,8 +1116,8 @@ function instantiateAllDirectives(
const directive = getNodeInjectable(tView.data, lView, i, tNode);
attachPatchData(directive, lView);
if (tNode.initialInputs !== null) {
setInputsFromAttrs(lView, i - start, directive, def, tNode);
if (initialInputs !== null) {
setInputsFromAttrs(lView, i - start, directive, def, tNode, initialInputs !);
}
if (isComponent) {
@ -1348,8 +1349,8 @@ export function elementAttributeInternal(
* @param tNode The static data for this node
*/
function setInputsFromAttrs<T>(
lView: LView, directiveIndex: number, instance: T, def: DirectiveDef<T>, tNode: TNode): void {
const initialInputData = tNode.initialInputs as InitialInputData;
lView: LView, directiveIndex: number, instance: T, def: DirectiveDef<T>, tNode: TNode,
initialInputData: InitialInputData): void {
const initialInputs: InitialInputs|null = initialInputData ![directiveIndex];
if (initialInputs !== null) {
const setInput = def.setInput;

2
packages/core/src/render3/interfaces/node.ts
View File

@ -603,7 +603,7 @@ export interface TProjectionNode extends TNode {
}
/**
* An union type representing all TNode types that can host a directive.
* A union type representing all TNode types that can host a directive.
*/
export type TDirectiveHostNode = TElementNode | TContainerNode | TElementContainerNode;

6
packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
View File

@ -533,12 +533,6 @@
{
"name": "objectToClassName"
},
{
"name": "postProcessBaseDirective"
},
{
"name": "postProcessDirective"
},
{
"name": "refreshChildComponents"
},