honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(core): add `isPromise` generic (#34168) 

This commit adds generic to `isPromise` function to help with type inference.

PR Close #34168
This commit is contained in:
danranVm 2020-03-18 15:28:25 +08:00 committed by Misko Hevery
parent b4972fa165
commit 47bfec4e46
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/common/upgrade/src/utils.ts
View File

@ -31,7 +31,7 @@ export function isAnchor(el: (Node & ParentNode) | Element | null): el is HTMLAn
return (<HTMLAnchorElement>el).href !== undefined; return (<HTMLAnchorElement>el).href !== undefined;
} }
export function isPromise(obj: any): obj is Promise<any> { export function isPromise<T = any>(obj: any): obj is Promise<T> {
// allow any Promise/A+ compliant thenable. // allow any Promise/A+ compliant thenable.
// It's up to the caller to ensure that obj.then conforms to the spec // It's up to the caller to ensure that obj.then conforms to the spec
return !!obj && typeof obj.then === 'function'; return !!obj && typeof obj.then === 'function';

2
packages/compiler/src/util.ts
View File

@ -214,7 +214,7 @@ export function resolveForwardRef(type: any): any {
/** /**
* Determine if the argument is shaped like a Promise * Determine if the argument is shaped like a Promise
*/ */
export function isPromise(obj: any): obj is Promise<any> { export function isPromise<T = any>(obj: any): obj is Promise<T> {
// allow any Promise/A+ compliant thenable. // allow any Promise/A+ compliant thenable.
// It's up to the caller to ensure that obj.then conforms to the spec // It's up to the caller to ensure that obj.then conforms to the spec
return !!obj && typeof obj.then === 'function'; return !!obj && typeof obj.then === 'function';

2
packages/core/src/util/lang.ts
View File

@ -11,7 +11,7 @@ import {Observable} from 'rxjs';
/** /**
* Determine if the argument is shaped like a Promise * Determine if the argument is shaped like a Promise
*/ */
export function isPromise(obj: any): obj is Promise<any> { export function isPromise<T = any>(obj: any): obj is Promise<T> {
// allow any Promise/A+ compliant thenable. // allow any Promise/A+ compliant thenable.
// It's up to the caller to ensure that obj.then conforms to the spec // It's up to the caller to ensure that obj.then conforms to the spec
return !!obj && typeof obj.then === 'function'; return !!obj && typeof obj.then === 'function';