refactor(change_detector): made change detection responsible for processing events

Closes #3666
This commit is contained in:
vsavkin 2015-08-12 16:26:21 -07:00 committed by Victor Savkin
parent 8b655c7be3
commit 4845583dcf
34 changed files with 837 additions and 1014 deletions

View File

@ -66,6 +66,10 @@ export class AbstractChangeDetector<T> implements ChangeDetector {
remove(): void { this.parent.removeChild(this); } remove(): void { this.parent.removeChild(this); }
handleEvent(eventName: string, elIndex: number, locals: Locals): boolean {
throw new BaseException("Not implemented");
}
detectChanges(): void { this.runDetectChanges(false); } detectChanges(): void { this.runDetectChanges(false); }
checkNoChanges(): void { throw new BaseException("Not implemented"); } checkNoChanges(): void { throw new BaseException("Not implemented"); }

View File

@ -10,11 +10,13 @@ const ELEMENT_ATTRIBUTE = "elementAttribute";
const ELEMENT_CLASS = "elementClass"; const ELEMENT_CLASS = "elementClass";
const ELEMENT_STYLE = "elementStyle"; const ELEMENT_STYLE = "elementStyle";
const TEXT_NODE = "textNode"; const TEXT_NODE = "textNode";
const EVENT = "event";
const HOST_EVENT = "hostEvent";
export class BindingRecord { export class BindingRecord {
constructor(public mode: string, public implicitReceiver: any, public ast: AST, constructor(public mode: string, public implicitReceiver: any, public ast: AST,
public elementIndex: number, public propertyName: string, public propertyUnit: string, public elementIndex: number, public propertyName: string, public propertyUnit: string,
public setter: SetterFn, public lifecycleEvent: string, public eventName: string, public setter: SetterFn, public lifecycleEvent: string,
public directiveRecord: DirectiveRecord) {} public directiveRecord: DirectiveRecord) {}
callOnChange(): boolean { callOnChange(): boolean {
@ -41,73 +43,83 @@ export class BindingRecord {
static createForDirective(ast: AST, propertyName: string, setter: SetterFn, static createForDirective(ast: AST, propertyName: string, setter: SetterFn,
directiveRecord: DirectiveRecord): BindingRecord { directiveRecord: DirectiveRecord): BindingRecord {
return new BindingRecord(DIRECTIVE, 0, ast, 0, propertyName, null, setter, null, return new BindingRecord(DIRECTIVE, 0, ast, 0, propertyName, null, null, setter, null,
directiveRecord); directiveRecord);
} }
static createDirectiveOnCheck(directiveRecord: DirectiveRecord): BindingRecord { static createDirectiveOnCheck(directiveRecord: DirectiveRecord): BindingRecord {
return new BindingRecord(DIRECTIVE_LIFECYCLE, 0, null, 0, null, null, null, "onCheck", return new BindingRecord(DIRECTIVE_LIFECYCLE, 0, null, 0, null, null, null, null, "onCheck",
directiveRecord); directiveRecord);
} }
static createDirectiveOnInit(directiveRecord: DirectiveRecord): BindingRecord { static createDirectiveOnInit(directiveRecord: DirectiveRecord): BindingRecord {
return new BindingRecord(DIRECTIVE_LIFECYCLE, 0, null, 0, null, null, null, "onInit", return new BindingRecord(DIRECTIVE_LIFECYCLE, 0, null, 0, null, null, null, null, "onInit",
directiveRecord); directiveRecord);
} }
static createDirectiveOnChange(directiveRecord: DirectiveRecord): BindingRecord { static createDirectiveOnChange(directiveRecord: DirectiveRecord): BindingRecord {
return new BindingRecord(DIRECTIVE_LIFECYCLE, 0, null, 0, null, null, null, "onChange", return new BindingRecord(DIRECTIVE_LIFECYCLE, 0, null, 0, null, null, null, null, "onChange",
directiveRecord); directiveRecord);
} }
static createForElementProperty(ast: AST, elementIndex: number, static createForElementProperty(ast: AST, elementIndex: number,
propertyName: string): BindingRecord { propertyName: string): BindingRecord {
return new BindingRecord(ELEMENT_PROPERTY, 0, ast, elementIndex, propertyName, null, null, null, return new BindingRecord(ELEMENT_PROPERTY, 0, ast, elementIndex, propertyName, null, null, null,
null); null, null);
} }
static createForElementAttribute(ast: AST, elementIndex: number, static createForElementAttribute(ast: AST, elementIndex: number,
attributeName: string): BindingRecord { attributeName: string): BindingRecord {
return new BindingRecord(ELEMENT_ATTRIBUTE, 0, ast, elementIndex, attributeName, null, null, return new BindingRecord(ELEMENT_ATTRIBUTE, 0, ast, elementIndex, attributeName, null, null,
null, null); null, null, null);
} }
static createForElementClass(ast: AST, elementIndex: number, className: string): BindingRecord { static createForElementClass(ast: AST, elementIndex: number, className: string): BindingRecord {
return new BindingRecord(ELEMENT_CLASS, 0, ast, elementIndex, className, null, null, null, return new BindingRecord(ELEMENT_CLASS, 0, ast, elementIndex, className, null, null, null, null,
null); null);
} }
static createForElementStyle(ast: AST, elementIndex: number, styleName: string, static createForElementStyle(ast: AST, elementIndex: number, styleName: string,
unit: string): BindingRecord { unit: string): BindingRecord {
return new BindingRecord(ELEMENT_STYLE, 0, ast, elementIndex, styleName, unit, null, null, return new BindingRecord(ELEMENT_STYLE, 0, ast, elementIndex, styleName, unit, null, null, null,
null); null);
} }
static createForHostProperty(directiveIndex: DirectiveIndex, ast: AST, static createForHostProperty(directiveIndex: DirectiveIndex, ast: AST,
propertyName: string): BindingRecord { propertyName: string): BindingRecord {
return new BindingRecord(ELEMENT_PROPERTY, directiveIndex, ast, directiveIndex.elementIndex, return new BindingRecord(ELEMENT_PROPERTY, directiveIndex, ast, directiveIndex.elementIndex,
propertyName, null, null, null, null); propertyName, null, null, null, null, null);
} }
static createForHostAttribute(directiveIndex: DirectiveIndex, ast: AST, static createForHostAttribute(directiveIndex: DirectiveIndex, ast: AST,
attributeName: string): BindingRecord { attributeName: string): BindingRecord {
return new BindingRecord(ELEMENT_ATTRIBUTE, directiveIndex, ast, directiveIndex.elementIndex, return new BindingRecord(ELEMENT_ATTRIBUTE, directiveIndex, ast, directiveIndex.elementIndex,
attributeName, null, null, null, null); attributeName, null, null, null, null, null);
} }
static createForHostClass(directiveIndex: DirectiveIndex, ast: AST, static createForHostClass(directiveIndex: DirectiveIndex, ast: AST,
className: string): BindingRecord { className: string): BindingRecord {
return new BindingRecord(ELEMENT_CLASS, directiveIndex, ast, directiveIndex.elementIndex, return new BindingRecord(ELEMENT_CLASS, directiveIndex, ast, directiveIndex.elementIndex,
className, null, null, null, null); className, null, null, null, null, null);
} }
static createForHostStyle(directiveIndex: DirectiveIndex, ast: AST, styleName: string, static createForHostStyle(directiveIndex: DirectiveIndex, ast: AST, styleName: string,
unit: string): BindingRecord { unit: string): BindingRecord {
return new BindingRecord(ELEMENT_STYLE, directiveIndex, ast, directiveIndex.elementIndex, return new BindingRecord(ELEMENT_STYLE, directiveIndex, ast, directiveIndex.elementIndex,
styleName, unit, null, null, null); styleName, unit, null, null, null, null);
} }
static createForTextNode(ast: AST, elementIndex: number): BindingRecord { static createForTextNode(ast: AST, elementIndex: number): BindingRecord {
return new BindingRecord(TEXT_NODE, 0, ast, elementIndex, null, null, null, null, null); return new BindingRecord(TEXT_NODE, 0, ast, elementIndex, null, null, null, null, null, null);
}
static createForEvent(ast: AST, eventName: string, elementIndex: number): BindingRecord {
return new BindingRecord(EVENT, 0, ast, elementIndex, null, null, eventName, null, null, null);
}
static createForHostEvent(ast: AST, eventName: string,
directiveIndex: DirectiveIndex): BindingRecord {
return new BindingRecord(EVENT, directiveIndex, ast, directiveIndex.elementIndex, null, null,
eventName, null, null, null);
} }
} }

View File

@ -14,7 +14,7 @@ export {
ASTWithSource, ASTWithSource,
AST, AST,
AstTransformer, AstTransformer,
AccessMember, PropertyRead,
LiteralArray, LiteralArray,
ImplicitReceiver ImplicitReceiver
} from './parser/ast'; } from './parser/ast';

View File

@ -8,6 +8,7 @@ import {DirectiveIndex, DirectiveRecord} from './directive_record';
import {ProtoRecord, RecordType} from './proto_record'; import {ProtoRecord, RecordType} from './proto_record';
import {CodegenNameUtil, sanitizeName} from './codegen_name_util'; import {CodegenNameUtil, sanitizeName} from './codegen_name_util';
import {CodegenLogicUtil} from './codegen_logic_util'; import {CodegenLogicUtil} from './codegen_logic_util';
import {EventBinding} from './event_binding';
/** /**
@ -30,9 +31,10 @@ export class ChangeDetectorJITGenerator {
_typeName: string; _typeName: string;
constructor(public id: string, private changeDetectionStrategy: string, constructor(public id: string, private changeDetectionStrategy: string,
public records: List<ProtoRecord>, public directiveRecords: List<any>, public records: List<ProtoRecord>, public eventBindings: EventBinding[],
private generateCheckNoChanges: boolean) { public directiveRecords: List<any>, private generateCheckNoChanges: boolean) {
this._names = new CodegenNameUtil(this.records, this.directiveRecords, UTIL); this._names =
new CodegenNameUtil(this.records, this.eventBindings, this.directiveRecords, UTIL);
this._logic = new CodegenLogicUtil(this._names, UTIL); this._logic = new CodegenLogicUtil(this._names, UTIL);
this._typeName = sanitizeName(`ChangeDetector_${this.id}`); this._typeName = sanitizeName(`ChangeDetector_${this.id}`);
} }
@ -48,6 +50,13 @@ export class ChangeDetectorJITGenerator {
${this._typeName}.prototype = Object.create(${ABSTRACT_CHANGE_DETECTOR}.prototype); ${this._typeName}.prototype = Object.create(${ABSTRACT_CHANGE_DETECTOR}.prototype);
${this._typeName}.prototype.handleEvent = function(eventName, elIndex, locals) {
var ${this._names.getPreventDefaultAccesor()} = false;
${this._names.genInitEventLocals()}
${this._genHandleEvent()}
return ${this._names.getPreventDefaultAccesor()};
}
${this._typeName}.prototype.detectChangesInRecordsInternal = function(throwOnChange) { ${this._typeName}.prototype.detectChangesInRecordsInternal = function(throwOnChange) {
${this._names.genInitLocals()} ${this._names.genInitLocals()}
var ${IS_CHANGED_LOCAL} = false; var ${IS_CHANGED_LOCAL} = false;
@ -75,6 +84,33 @@ export class ChangeDetectorJITGenerator {
AbstractChangeDetector, ChangeDetectionUtil, this.records, this.directiveRecords); AbstractChangeDetector, ChangeDetectionUtil, this.records, this.directiveRecords);
} }
_genHandleEvent(): string {
return this.eventBindings.map(eb => this._genEventBinding(eb)).join("\n");
}
_genEventBinding(eb: EventBinding): string {
var recs = eb.records.map(r => this._genEventBindingEval(eb, r)).join("\n");
return `
if (eventName === "${eb.eventName}" && elIndex === ${eb.elIndex}) {
${recs}
}`;
}
_genEventBindingEval(eb: EventBinding, r: ProtoRecord): string {
if (r.lastInBinding) {
var evalRecord = this._logic.genEventBindingEvalValue(eb, r);
var prevDefault = this._genUpdatePreventDefault(eb, r);
return `${evalRecord}\n${prevDefault}`;
} else {
return this._logic.genEventBindingEvalValue(eb, r);
}
}
_genUpdatePreventDefault(eb: EventBinding, r: ProtoRecord): string {
var local = this._names.getEventLocalName(eb, r.selfIndex);
return `if (${local} === false) { ${this._names.getPreventDefaultAccesor()} = true};`;
}
_maybeGenDehydrateDirectives(): string { _maybeGenDehydrateDirectives(): string {
var destroyPipesCode = this._names.genPipeOnDestroy(); var destroyPipesCode = this._names.genPipeOnDestroy();
if (destroyPipesCode) { if (destroyPipesCode) {
@ -204,7 +240,7 @@ export class ChangeDetectorJITGenerator {
var oldValue = this._names.getFieldName(r.selfIndex); var oldValue = this._names.getFieldName(r.selfIndex);
var newValue = this._names.getLocalName(r.selfIndex); var newValue = this._names.getLocalName(r.selfIndex);
var read = ` var read = `
${this._logic.genUpdateCurrentValue(r)} ${this._logic.genPropertyBindingEvalValue(r)}
`; `;
var check = ` var check = `

View File

@ -13,3 +13,7 @@ String codify(funcOrValue) => JSON.encode(funcOrValue).replaceAll(r'$', r'\$');
String combineGeneratedStrings(List<String> vals) { String combineGeneratedStrings(List<String> vals) {
return '"${vals.map((v) => '\${$v}').join('')}"'; return '"${vals.map((v) => '\${$v}').join('')}"';
} }
String rawString(String str) {
return "r'$str'";
}

View File

@ -7,6 +7,10 @@ export function codify(obj: any): string {
return JSON.stringify(obj); return JSON.stringify(obj);
} }
export function rawString(str: string): string {
return `'${str}'`;
}
/** /**
* Combine the strings of generated code into a single interpolated string. * Combine the strings of generated code into a single interpolated string.
* Each element of `vals` is expected to be a string literal or a codegen'd * Each element of `vals` is expected to be a string literal or a codegen'd

View File

@ -1,7 +1,7 @@
import {ListWrapper} from 'angular2/src/facade/collection'; import {ListWrapper} from 'angular2/src/facade/collection';
import {BaseException, Json} from 'angular2/src/facade/lang'; import {BaseException, Json} from 'angular2/src/facade/lang';
import {CodegenNameUtil} from './codegen_name_util'; import {CodegenNameUtil} from './codegen_name_util';
import {codify, combineGeneratedStrings} from './codegen_facade'; import {codify, combineGeneratedStrings, rawString} from './codegen_facade';
import {ProtoRecord, RecordType} from './proto_record'; import {ProtoRecord, RecordType} from './proto_record';
/** /**
@ -12,14 +12,28 @@ export class CodegenLogicUtil {
/** /**
* Generates a statement which updates the local variable representing `protoRec` with the current * Generates a statement which updates the local variable representing `protoRec` with the current
* value of the record. * value of the record. Used by property bindings.
*/ */
genUpdateCurrentValue(protoRec: ProtoRecord): string { genPropertyBindingEvalValue(protoRec: ProtoRecord): string {
return this.genEvalValue(protoRec, idx => this._names.getLocalName(idx),
this._names.getLocalsAccessorName());
}
/**
* Generates a statement which updates the local variable representing `protoRec` with the current
* value of the record. Used by event bindings.
*/
genEventBindingEvalValue(eventRecord: any, protoRec: ProtoRecord): string {
return this.genEvalValue(protoRec, idx => this._names.getEventLocalName(eventRecord, idx),
"locals");
}
private genEvalValue(protoRec: ProtoRecord, getLocalName: Function,
localsAccessor: string): string {
var context = (protoRec.contextIndex == -1) ? var context = (protoRec.contextIndex == -1) ?
this._names.getDirectiveName(protoRec.directiveIndex) : this._names.getDirectiveName(protoRec.directiveIndex) :
this._names.getLocalName(protoRec.contextIndex); getLocalName(protoRec.contextIndex);
var argString = var argString = ListWrapper.map(protoRec.args, (arg) => getLocalName(arg)).join(", ");
ListWrapper.map(protoRec.args, (arg) => this._names.getLocalName(arg)).join(", ");
var rhs: string; var rhs: string;
switch (protoRec.mode) { switch (protoRec.mode) {
@ -31,7 +45,7 @@ export class CodegenLogicUtil {
rhs = codify(protoRec.funcOrValue); rhs = codify(protoRec.funcOrValue);
break; break;
case RecordType.PROPERTY: case RecordType.PROPERTY_READ:
rhs = `${context}.${protoRec.name}`; rhs = `${context}.${protoRec.name}`;
break; break;
@ -39,8 +53,12 @@ export class CodegenLogicUtil {
rhs = `${this._utilName}.isValueBlank(${context}) ? null : ${context}.${protoRec.name}`; rhs = `${this._utilName}.isValueBlank(${context}) ? null : ${context}.${protoRec.name}`;
break; break;
case RecordType.PROPERTY_WRITE:
rhs = `${context}.${protoRec.name} = ${getLocalName(protoRec.args[0])}`;
break;
case RecordType.LOCAL: case RecordType.LOCAL:
rhs = `${this._names.getLocalsAccessorName()}.get('${protoRec.name}')`; rhs = `${localsAccessor}.get(${rawString(protoRec.name)})`;
break; break;
case RecordType.INVOKE_METHOD: case RecordType.INVOKE_METHOD:
@ -68,16 +86,25 @@ export class CodegenLogicUtil {
rhs = this._genInterpolation(protoRec); rhs = this._genInterpolation(protoRec);
break; break;
case RecordType.KEYED_ACCESS: case RecordType.KEYED_READ:
rhs = `${context}[${this._names.getLocalName(protoRec.args[0])}]`; rhs = `${context}[${getLocalName(protoRec.args[0])}]`;
break;
case RecordType.KEYED_WRITE:
rhs = `${context}[${getLocalName(protoRec.args[0])}] = ${getLocalName(protoRec.args[1])}`;
break;
case RecordType.CHAIN:
rhs = 'null';
break; break;
default: default:
throw new BaseException(`Unknown operation ${protoRec.mode}`); throw new BaseException(`Unknown operation ${protoRec.mode}`);
} }
return `${this._names.getLocalName(protoRec.selfIndex)} = ${rhs};`; return `${getLocalName(protoRec.selfIndex)} = ${rhs};`;
} }
_genInterpolation(protoRec: ProtoRecord): string { _genInterpolation(protoRec: ProtoRecord): string {
var iVals = []; var iVals = [];
for (var i = 0; i < protoRec.args.length; ++i) { for (var i = 0; i < protoRec.args.length; ++i) {

View File

@ -1,9 +1,10 @@
import {RegExpWrapper, StringWrapper} from 'angular2/src/facade/lang'; import {RegExpWrapper, StringWrapper} from 'angular2/src/facade/lang';
import {List, ListWrapper} from 'angular2/src/facade/collection'; import {List, ListWrapper, MapWrapper, Map} from 'angular2/src/facade/collection';
import {DirectiveIndex} from './directive_record'; import {DirectiveIndex} from './directive_record';
import {ProtoRecord} from './proto_record'; import {ProtoRecord} from './proto_record';
import {EventBinding} from './event_binding';
// The names of these fields must be kept in sync with abstract_change_detector.ts or change // The names of these fields must be kept in sync with abstract_change_detector.ts or change
// detection will fail. // detection will fail.
@ -41,14 +42,25 @@ export class CodegenNameUtil {
* See [sanitizeName] for details. * See [sanitizeName] for details.
*/ */
_sanitizedNames: List<string>; _sanitizedNames: List<string>;
_sanitizedEventNames: Map<EventBinding, List<string>>;
constructor(private records: List<ProtoRecord>, private directiveRecords: List<any>, constructor(private records: List<ProtoRecord>, private eventBindings: EventBinding[],
private utilName: string) { private directiveRecords: List<any>, private utilName: string) {
this._sanitizedNames = ListWrapper.createFixedSize(this.records.length + 1); this._sanitizedNames = ListWrapper.createFixedSize(this.records.length + 1);
this._sanitizedNames[CONTEXT_INDEX] = _CONTEXT_ACCESSOR; this._sanitizedNames[CONTEXT_INDEX] = _CONTEXT_ACCESSOR;
for (var i = 0, iLen = this.records.length; i < iLen; ++i) { for (var i = 0, iLen = this.records.length; i < iLen; ++i) {
this._sanitizedNames[i + 1] = sanitizeName(`${this.records[i].name}${i}`); this._sanitizedNames[i + 1] = sanitizeName(`${this.records[i].name}${i}`);
} }
this._sanitizedEventNames = new Map();
for (var ebIndex = 0; ebIndex < eventBindings.length; ++ebIndex) {
var eb = eventBindings[ebIndex];
var names = [_CONTEXT_ACCESSOR];
for (var i = 0, iLen = eb.records.length; i < iLen; ++i) {
names.push(sanitizeName(`${eb.records[i].name}${i}_${ebIndex}`));
}
this._sanitizedEventNames.set(eb, names);
}
} }
_addFieldPrefix(name: string): string { return `${_FIELD_PREFIX}${name}`; } _addFieldPrefix(name: string): string { return `${_FIELD_PREFIX}${name}`; }
@ -73,6 +85,10 @@ export class CodegenNameUtil {
getLocalName(idx: int): string { return `l_${this._sanitizedNames[idx]}`; } getLocalName(idx: int): string { return `l_${this._sanitizedNames[idx]}`; }
getEventLocalName(eb: EventBinding, idx: int): string {
return `l_${MapWrapper.get(this._sanitizedEventNames, eb)[idx]}`;
}
getChangeName(idx: int): string { return `c_${this._sanitizedNames[idx]}`; } getChangeName(idx: int): string { return `c_${this._sanitizedNames[idx]}`; }
/** /**
@ -100,6 +116,23 @@ export class CodegenNameUtil {
return `var ${ListWrapper.join(declarations, ',')};${assignmentsCode}`; return `var ${ListWrapper.join(declarations, ',')};${assignmentsCode}`;
} }
/**
* Generate a statement initializing local variables for event handlers.
*/
genInitEventLocals(): string {
var res = [`${this.getLocalName(CONTEXT_INDEX)} = ${this.getFieldName(CONTEXT_INDEX)}`];
MapWrapper.forEach(this._sanitizedEventNames, (names, eb) => {
for (var i = 0; i < names.length; ++i) {
if (i !== CONTEXT_INDEX) {
res.push(this.getEventLocalName(eb, i));
}
}
});
return res.length > 1 ? `var ${res.join(',')};` : '';
}
getPreventDefaultAccesor(): string { return "preventDefault"; }
getFieldCount(): int { return this._sanitizedNames.length; } getFieldCount(): int { return this._sanitizedNames.length; }
getFieldName(idx: int): string { return this._addFieldPrefix(this._sanitizedNames[idx]); } getFieldName(idx: int): string { return this._addFieldPrefix(this._sanitizedNames[idx]); }

View File

@ -2,7 +2,9 @@ import {isPresent, isBlank, BaseException, FunctionWrapper} from 'angular2/src/f
import {List, ListWrapper, MapWrapper, StringMapWrapper} from 'angular2/src/facade/collection'; import {List, ListWrapper, MapWrapper, StringMapWrapper} from 'angular2/src/facade/collection';
import {AbstractChangeDetector} from './abstract_change_detector'; import {AbstractChangeDetector} from './abstract_change_detector';
import {EventBinding} from './event_binding';
import {BindingRecord} from './binding_record'; import {BindingRecord} from './binding_record';
import {Locals} from './parser/locals';
import {ChangeDetectionUtil, SimpleChange} from './change_detection_util'; import {ChangeDetectionUtil, SimpleChange} from './change_detection_util';
@ -16,7 +18,8 @@ export class DynamicChangeDetector extends AbstractChangeDetector<any> {
directives: any = null; directives: any = null;
constructor(id: string, changeDetectionStrategy: string, dispatcher: any, constructor(id: string, changeDetectionStrategy: string, dispatcher: any,
protos: List<ProtoRecord>, directiveRecords: List<any>) { protos: List<ProtoRecord>, public eventBindings: EventBinding[],
directiveRecords: List<any>) {
super(id, dispatcher, protos, directiveRecords, super(id, dispatcher, protos, directiveRecords,
ChangeDetectionUtil.changeDetectionMode(changeDetectionStrategy)); ChangeDetectionUtil.changeDetectionMode(changeDetectionStrategy));
var len = protos.length + 1; var len = protos.length + 1;
@ -28,6 +31,41 @@ export class DynamicChangeDetector extends AbstractChangeDetector<any> {
this.dehydrateDirectives(false); this.dehydrateDirectives(false);
} }
handleEvent(eventName: string, elIndex: number, locals: Locals): boolean {
var preventDefault = false;
this._matchingEventBindings(eventName, elIndex)
.forEach(rec => {
var res = this._processEventBinding(rec, locals);
if (res === false) {
preventDefault = true;
}
});
return preventDefault;
}
_processEventBinding(eb: EventBinding, locals: Locals): any {
var values = ListWrapper.createFixedSize(eb.records.length);
values[0] = this.values[0];
for (var i = 0; i < eb.records.length; ++i) {
var proto = eb.records[i];
var res = this._calculateCurrValue(proto, values, locals);
if (proto.lastInBinding) {
return res;
} else {
this._writeSelf(proto, res, values);
}
}
throw new BaseException("Cannot be reached");
}
_matchingEventBindings(eventName: string, elIndex: number): EventBinding[] {
return ListWrapper.filter(this.eventBindings,
eb => eb.eventName == eventName && eb.elIndex === elIndex);
}
hydrateDirectives(directives: any): void { hydrateDirectives(directives: any): void {
this.values[0] = this.context; this.values[0] = this.context;
this.directives = directives; this.directives = directives;
@ -79,7 +117,7 @@ export class DynamicChangeDetector extends AbstractChangeDetector<any> {
} }
} else { } else {
var change = this._check(proto, throwOnChange); var change = this._check(proto, throwOnChange, this.values, this.locals);
if (isPresent(change)) { if (isPresent(change)) {
this._updateDirectiveOrElement(change, bindingRecord); this._updateDirectiveOrElement(change, bindingRecord);
isChanged = true; isChanged = true;
@ -137,33 +175,33 @@ export class DynamicChangeDetector extends AbstractChangeDetector<any> {
_getDetectorFor(directiveIndex) { return this.directives.getDetectorFor(directiveIndex); } _getDetectorFor(directiveIndex) { return this.directives.getDetectorFor(directiveIndex); }
_check(proto: ProtoRecord, throwOnChange: boolean): SimpleChange { _check(proto: ProtoRecord, throwOnChange: boolean, values: any[], locals: Locals): SimpleChange {
if (proto.isPipeRecord()) { if (proto.isPipeRecord()) {
return this._pipeCheck(proto, throwOnChange); return this._pipeCheck(proto, throwOnChange, values);
} else { } else {
return this._referenceCheck(proto, throwOnChange); return this._referenceCheck(proto, throwOnChange, values, locals);
} }
} }
_referenceCheck(proto: ProtoRecord, throwOnChange: boolean) { _referenceCheck(proto: ProtoRecord, throwOnChange: boolean, values: any[], locals: Locals) {
if (this._pureFuncAndArgsDidNotChange(proto)) { if (this._pureFuncAndArgsDidNotChange(proto)) {
this._setChanged(proto, false); this._setChanged(proto, false);
return null; return null;
} }
var currValue = this._calculateCurrValue(proto); var currValue = this._calculateCurrValue(proto, values, locals);
if (proto.shouldBeChecked()) { if (proto.shouldBeChecked()) {
var prevValue = this._readSelf(proto); var prevValue = this._readSelf(proto, values);
if (!isSame(prevValue, currValue)) { if (!isSame(prevValue, currValue)) {
if (proto.lastInBinding) { if (proto.lastInBinding) {
var change = ChangeDetectionUtil.simpleChange(prevValue, currValue); var change = ChangeDetectionUtil.simpleChange(prevValue, currValue);
if (throwOnChange) this.throwOnChangeError(prevValue, currValue); if (throwOnChange) this.throwOnChangeError(prevValue, currValue);
this._writeSelf(proto, currValue); this._writeSelf(proto, currValue, values);
this._setChanged(proto, true); this._setChanged(proto, true);
return change; return change;
} else { } else {
this._writeSelf(proto, currValue); this._writeSelf(proto, currValue, values);
this._setChanged(proto, true); this._setChanged(proto, true);
return null; return null;
} }
@ -173,70 +211,88 @@ export class DynamicChangeDetector extends AbstractChangeDetector<any> {
} }
} else { } else {
this._writeSelf(proto, currValue); this._writeSelf(proto, currValue, values);
this._setChanged(proto, true); this._setChanged(proto, true);
return null; return null;
} }
} }
_calculateCurrValue(proto: ProtoRecord) { _calculateCurrValue(proto: ProtoRecord, values: any[], locals: Locals) {
switch (proto.mode) { switch (proto.mode) {
case RecordType.SELF: case RecordType.SELF:
return this._readContext(proto); return this._readContext(proto, values);
case RecordType.CONST: case RecordType.CONST:
return proto.funcOrValue; return proto.funcOrValue;
case RecordType.PROPERTY: case RecordType.PROPERTY_READ:
var context = this._readContext(proto); var context = this._readContext(proto, values);
return proto.funcOrValue(context); return proto.funcOrValue(context);
case RecordType.SAFE_PROPERTY: case RecordType.SAFE_PROPERTY:
var context = this._readContext(proto); var context = this._readContext(proto, values);
return isBlank(context) ? null : proto.funcOrValue(context); return isBlank(context) ? null : proto.funcOrValue(context);
case RecordType.PROPERTY_WRITE:
var context = this._readContext(proto, values);
var value = this._readArgs(proto, values)[0];
proto.funcOrValue(context, value);
return value;
case RecordType.KEYED_WRITE:
var context = this._readContext(proto, values);
var key = this._readArgs(proto, values)[0];
var value = this._readArgs(proto, values)[1];
context[key] = value;
return value;
case RecordType.LOCAL: case RecordType.LOCAL:
return this.locals.get(proto.name); return locals.get(proto.name);
case RecordType.INVOKE_METHOD: case RecordType.INVOKE_METHOD:
var context = this._readContext(proto); var context = this._readContext(proto, values);
var args = this._readArgs(proto); var args = this._readArgs(proto, values);
return proto.funcOrValue(context, args); return proto.funcOrValue(context, args);
case RecordType.SAFE_INVOKE_METHOD: case RecordType.SAFE_INVOKE_METHOD:
var context = this._readContext(proto); var context = this._readContext(proto, values);
if (isBlank(context)) { if (isBlank(context)) {
return null; return null;
} }
var args = this._readArgs(proto); var args = this._readArgs(proto, values);
return proto.funcOrValue(context, args); return proto.funcOrValue(context, args);
case RecordType.KEYED_ACCESS: case RecordType.KEYED_READ:
var arg = this._readArgs(proto)[0]; var arg = this._readArgs(proto, values)[0];
return this._readContext(proto)[arg]; return this._readContext(proto, values)[arg];
case RecordType.CHAIN:
var args = this._readArgs(proto, values);
return args[args.length - 1];
case RecordType.INVOKE_CLOSURE: case RecordType.INVOKE_CLOSURE:
return FunctionWrapper.apply(this._readContext(proto), this._readArgs(proto)); return FunctionWrapper.apply(this._readContext(proto, values),
this._readArgs(proto, values));
case RecordType.INTERPOLATE: case RecordType.INTERPOLATE:
case RecordType.PRIMITIVE_OP: case RecordType.PRIMITIVE_OP:
case RecordType.COLLECTION_LITERAL: case RecordType.COLLECTION_LITERAL:
return FunctionWrapper.apply(proto.funcOrValue, this._readArgs(proto)); return FunctionWrapper.apply(proto.funcOrValue, this._readArgs(proto, values));
default: default:
throw new BaseException(`Unknown operation ${proto.mode}`); throw new BaseException(`Unknown operation ${proto.mode}`);
} }
} }
_pipeCheck(proto: ProtoRecord, throwOnChange: boolean) { _pipeCheck(proto: ProtoRecord, throwOnChange: boolean, values: any[]) {
var context = this._readContext(proto); var context = this._readContext(proto, values);
var args = this._readArgs(proto); var args = this._readArgs(proto, values);
var pipe = this._pipeFor(proto, context); var pipe = this._pipeFor(proto, context);
var currValue = pipe.transform(context, args); var currValue = pipe.transform(context, args);
if (proto.shouldBeChecked()) { if (proto.shouldBeChecked()) {
var prevValue = this._readSelf(proto); var prevValue = this._readSelf(proto, values);
if (!isSame(prevValue, currValue)) { if (!isSame(prevValue, currValue)) {
currValue = ChangeDetectionUtil.unwrapValue(currValue); currValue = ChangeDetectionUtil.unwrapValue(currValue);
@ -244,13 +300,13 @@ export class DynamicChangeDetector extends AbstractChangeDetector<any> {
var change = ChangeDetectionUtil.simpleChange(prevValue, currValue); var change = ChangeDetectionUtil.simpleChange(prevValue, currValue);
if (throwOnChange) this.throwOnChangeError(prevValue, currValue); if (throwOnChange) this.throwOnChangeError(prevValue, currValue);
this._writeSelf(proto, currValue); this._writeSelf(proto, currValue, values);
this._setChanged(proto, true); this._setChanged(proto, true);
return change; return change;
} else { } else {
this._writeSelf(proto, currValue); this._writeSelf(proto, currValue, values);
this._setChanged(proto, true); this._setChanged(proto, true);
return null; return null;
} }
@ -259,7 +315,7 @@ export class DynamicChangeDetector extends AbstractChangeDetector<any> {
return null; return null;
} }
} else { } else {
this._writeSelf(proto, currValue); this._writeSelf(proto, currValue, values);
this._setChanged(proto, true); this._setChanged(proto, true);
return null; return null;
} }
@ -274,19 +330,19 @@ export class DynamicChangeDetector extends AbstractChangeDetector<any> {
return pipe; return pipe;
} }
_readContext(proto: ProtoRecord) { _readContext(proto: ProtoRecord, values: any[]) {
if (proto.contextIndex == -1) { if (proto.contextIndex == -1) {
return this._getDirectiveFor(proto.directiveIndex); return this._getDirectiveFor(proto.directiveIndex);
} else { } else {
return this.values[proto.contextIndex]; return values[proto.contextIndex];
} }
return this.values[proto.contextIndex]; return values[proto.contextIndex];
} }
_readSelf(proto: ProtoRecord) { return this.values[proto.selfIndex]; } _readSelf(proto: ProtoRecord, values: any[]) { return values[proto.selfIndex]; }
_writeSelf(proto: ProtoRecord, value) { this.values[proto.selfIndex] = value; } _writeSelf(proto: ProtoRecord, value, values: any[]) { values[proto.selfIndex] = value; }
_readPipe(proto: ProtoRecord) { return this.localPipes[proto.selfIndex]; } _readPipe(proto: ProtoRecord) { return this.localPipes[proto.selfIndex]; }
@ -310,11 +366,11 @@ export class DynamicChangeDetector extends AbstractChangeDetector<any> {
return false; return false;
} }
_readArgs(proto: ProtoRecord) { _readArgs(proto: ProtoRecord, values: any[]) {
var res = ListWrapper.createFixedSize(proto.args.length); var res = ListWrapper.createFixedSize(proto.args.length);
var args = proto.args; var args = proto.args;
for (var i = 0; i < args.length; ++i) { for (var i = 0; i < args.length; ++i) {
res[i] = this.values[args[i]]; res[i] = values[args[i]];
} }
return res; return res;
} }

View File

@ -0,0 +1,7 @@
import {DirectiveIndex} from './directive_record';
import {ProtoRecord} from './proto_record';
export class EventBinding {
constructor(public eventName: string, public elIndex: number, public dirIndex: DirectiveIndex,
public records: ProtoRecord[]) {}
}

View File

@ -62,6 +62,7 @@ export interface ChangeDetector {
dehydrate(): void; dehydrate(): void;
markPathToRootAsCheckOnce(): void; markPathToRootAsCheckOnce(): void;
handleEvent(eventName: string, elIndex: number, locals: Locals);
detectChanges(): void; detectChanges(): void;
checkNoChanges(): void; checkNoChanges(): void;
} }
@ -70,7 +71,6 @@ export interface ProtoChangeDetector { instantiate(dispatcher: ChangeDispatcher)
export class ChangeDetectorDefinition { export class ChangeDetectorDefinition {
constructor(public id: string, public strategy: string, public variableNames: List<string>, constructor(public id: string, public strategy: string, public variableNames: List<string>,
public bindingRecords: List<BindingRecord>, public bindingRecords: BindingRecord[], public eventRecords: BindingRecord[],
public directiveRecords: List<DirectiveRecord>, public directiveRecords: DirectiveRecord[], public generateCheckNoChanges: boolean) {}
public generateCheckNoChanges: boolean) {}
} }

View File

@ -4,7 +4,7 @@ import {ProtoChangeDetector, ChangeDetector, ChangeDetectorDefinition} from './i
import {ChangeDetectorJITGenerator} from './change_detection_jit_generator'; import {ChangeDetectorJITGenerator} from './change_detection_jit_generator';
import {coalesce} from './coalesce'; import {coalesce} from './coalesce';
import {ProtoRecordBuilder} from './proto_change_detector'; import {createPropertyRecords, createEventRecords} from './proto_change_detector';
export class JitProtoChangeDetector implements ProtoChangeDetector { export class JitProtoChangeDetector implements ProtoChangeDetector {
_factory: Function; _factory: Function;
@ -18,13 +18,11 @@ export class JitProtoChangeDetector implements ProtoChangeDetector {
instantiate(dispatcher: any): ChangeDetector { return this._factory(dispatcher); } instantiate(dispatcher: any): ChangeDetector { return this._factory(dispatcher); }
_createFactory(definition: ChangeDetectorDefinition) { _createFactory(definition: ChangeDetectorDefinition) {
var recordBuilder = new ProtoRecordBuilder(); var propertyBindingRecords = createPropertyRecords(definition);
ListWrapper.forEach(definition.bindingRecords, var eventBindingRecords = createEventRecords(definition);
(b) => { recordBuilder.add(b, definition.variableNames); }); return new ChangeDetectorJITGenerator(
var records = coalesce(recordBuilder.records); definition.id, definition.strategy, propertyBindingRecords, eventBindingRecords,
return new ChangeDetectorJITGenerator(definition.id, definition.strategy, records, this.definition.directiveRecords, this.definition.generateCheckNoChanges)
this.definition.directiveRecords,
this.definition.generateCheckNoChanges)
.generate(); .generate();
} }
} }

View File

@ -1,30 +1,18 @@
import {isBlank, isPresent, FunctionWrapper, BaseException} from "angular2/src/facade/lang"; import {isBlank, isPresent, FunctionWrapper, BaseException} from "angular2/src/facade/lang";
import {List, Map, ListWrapper, StringMapWrapper} from "angular2/src/facade/collection"; import {List, Map, ListWrapper, StringMapWrapper} from "angular2/src/facade/collection";
import {Locals} from "./locals";
export class AST { export class AST {
eval(context: any, locals: Locals): any { throw new BaseException("Not supported"); }
get isAssignable(): boolean { return false; }
assign(context: any, locals: Locals, value: any) { throw new BaseException("Not supported"); }
visit(visitor: AstVisitor): any { return null; } visit(visitor: AstVisitor): any { return null; }
toString(): string { return "AST"; } toString(): string { return "AST"; }
} }
export class EmptyExpr extends AST { export class EmptyExpr extends AST {
eval(context: any, locals: Locals): any { return null; }
visit(visitor: AstVisitor) { visit(visitor: AstVisitor) {
// do nothing // do nothing
} }
} }
export class ImplicitReceiver extends AST { export class ImplicitReceiver extends AST {
eval(context: any, locals: Locals): any { return context; }
visit(visitor: AstVisitor): any { return visitor.visitImplicitReceiver(this); } visit(visitor: AstVisitor): any { return visitor.visitImplicitReceiver(this); }
} }
@ -33,112 +21,45 @@ export class ImplicitReceiver extends AST {
*/ */
export class Chain extends AST { export class Chain extends AST {
constructor(public expressions: List<any>) { super(); } constructor(public expressions: List<any>) { super(); }
eval(context: any, locals: Locals): any {
var result;
for (var i = 0; i < this.expressions.length; i++) {
var last = this.expressions[i].eval(context, locals);
if (isPresent(last)) result = last;
}
return result;
}
visit(visitor: AstVisitor): any { return visitor.visitChain(this); } visit(visitor: AstVisitor): any { return visitor.visitChain(this); }
} }
export class Conditional extends AST { export class Conditional extends AST {
constructor(public condition: AST, public trueExp: AST, public falseExp: AST) { super(); } constructor(public condition: AST, public trueExp: AST, public falseExp: AST) { super(); }
eval(context: any, locals: Locals): any {
if (this.condition.eval(context, locals)) {
return this.trueExp.eval(context, locals);
} else {
return this.falseExp.eval(context, locals);
}
}
visit(visitor: AstVisitor): any { return visitor.visitConditional(this); } visit(visitor: AstVisitor): any { return visitor.visitConditional(this); }
} }
export class If extends AST { export class If extends AST {
constructor(public condition: AST, public trueExp: AST, public falseExp?: AST) { super(); } constructor(public condition: AST, public trueExp: AST, public falseExp?: AST) { super(); }
eval(context: any, locals: Locals) {
if (this.condition.eval(context, locals)) {
this.trueExp.eval(context, locals);
} else if (isPresent(this.falseExp)) {
this.falseExp.eval(context, locals);
}
}
visit(visitor: AstVisitor): any { return visitor.visitIf(this); } visit(visitor: AstVisitor): any { return visitor.visitIf(this); }
} }
export class AccessMember extends AST { export class PropertyRead extends AST {
constructor(public receiver: AST, public name: string, public getter: Function, constructor(public receiver: AST, public name: string, public getter: Function) { super(); }
public setter: Function) { visit(visitor: AstVisitor): any { return visitor.visitPropertyRead(this); }
super();
}
eval(context: any, locals: Locals): any {
if (this.receiver instanceof ImplicitReceiver && isPresent(locals) &&
locals.contains(this.name)) {
return locals.get(this.name);
} else {
var evaluatedReceiver = this.receiver.eval(context, locals);
return this.getter(evaluatedReceiver);
}
}
get isAssignable(): boolean { return true; }
assign(context: any, locals: Locals, value: any): any {
var evaluatedContext = this.receiver.eval(context, locals);
if (this.receiver instanceof ImplicitReceiver && isPresent(locals) &&
locals.contains(this.name)) {
throw new BaseException(`Cannot reassign a variable binding ${this.name}`);
} else {
return this.setter(evaluatedContext, value);
}
}
visit(visitor: AstVisitor): any { return visitor.visitAccessMember(this); }
} }
export class SafeAccessMember extends AST { export class PropertyWrite extends AST {
constructor(public receiver: AST, public name: string, public getter: Function, constructor(public receiver: AST, public name: string, public setter: Function,
public setter: Function) { public value: AST) {
super(); super();
} }
visit(visitor: AstVisitor): any { return visitor.visitPropertyWrite(this); }
eval(context: any, locals: Locals): any {
var evaluatedReceiver = this.receiver.eval(context, locals);
return isBlank(evaluatedReceiver) ? null : this.getter(evaluatedReceiver);
}
visit(visitor: AstVisitor): any { return visitor.visitSafeAccessMember(this); }
} }
export class KeyedAccess extends AST { export class SafePropertyRead extends AST {
constructor(public receiver: AST, public name: string, public getter: Function) { super(); }
visit(visitor: AstVisitor): any { return visitor.visitSafePropertyRead(this); }
}
export class KeyedRead extends AST {
constructor(public obj: AST, public key: AST) { super(); } constructor(public obj: AST, public key: AST) { super(); }
visit(visitor: AstVisitor): any { return visitor.visitKeyedRead(this); }
}
eval(context: any, locals: Locals): any { export class KeyedWrite extends AST {
var obj: any = this.obj.eval(context, locals); constructor(public obj: AST, public key: AST, public value: AST) { super(); }
var key: any = this.key.eval(context, locals); visit(visitor: AstVisitor): any { return visitor.visitKeyedWrite(this); }
return obj[key];
}
get isAssignable(): boolean { return true; }
assign(context: any, locals: Locals, value: any): any {
var obj: any = this.obj.eval(context, locals);
var key: any = this.key.eval(context, locals);
obj[key] = value;
return value;
}
visit(visitor: AstVisitor): any { return visitor.visitKeyedAccess(this); }
} }
export class BindingPipe extends AST { export class BindingPipe extends AST {
@ -149,133 +70,39 @@ export class BindingPipe extends AST {
export class LiteralPrimitive extends AST { export class LiteralPrimitive extends AST {
constructor(public value) { super(); } constructor(public value) { super(); }
eval(context: any, locals: Locals): any { return this.value; }
visit(visitor: AstVisitor): any { return visitor.visitLiteralPrimitive(this); } visit(visitor: AstVisitor): any { return visitor.visitLiteralPrimitive(this); }
} }
export class LiteralArray extends AST { export class LiteralArray extends AST {
constructor(public expressions: List<any>) { super(); } constructor(public expressions: List<any>) { super(); }
eval(context: any, locals: Locals): any {
return ListWrapper.map(this.expressions, (e) => e.eval(context, locals));
}
visit(visitor: AstVisitor): any { return visitor.visitLiteralArray(this); } visit(visitor: AstVisitor): any { return visitor.visitLiteralArray(this); }
} }
export class LiteralMap extends AST { export class LiteralMap extends AST {
constructor(public keys: List<any>, public values: List<any>) { super(); } constructor(public keys: List<any>, public values: List<any>) { super(); }
eval(context: any, locals: Locals): any {
var res = StringMapWrapper.create();
for (var i = 0; i < this.keys.length; ++i) {
StringMapWrapper.set(res, this.keys[i], this.values[i].eval(context, locals));
}
return res;
}
visit(visitor: AstVisitor): any { return visitor.visitLiteralMap(this); } visit(visitor: AstVisitor): any { return visitor.visitLiteralMap(this); }
} }
export class Interpolation extends AST { export class Interpolation extends AST {
constructor(public strings: List<any>, public expressions: List<any>) { super(); } constructor(public strings: List<any>, public expressions: List<any>) { super(); }
eval(context: any, locals: Locals): any {
throw new BaseException("evaluating an Interpolation is not supported");
}
visit(visitor: AstVisitor) { visitor.visitInterpolation(this); } visit(visitor: AstVisitor) { visitor.visitInterpolation(this); }
} }
export class Binary extends AST { export class Binary extends AST {
constructor(public operation: string, public left: AST, public right: AST) { super(); } constructor(public operation: string, public left: AST, public right: AST) { super(); }
eval(context: any, locals: Locals): any {
var left: any = this.left.eval(context, locals);
switch (this.operation) {
case '&&':
return left && this.right.eval(context, locals);
case '||':
return left || this.right.eval(context, locals);
}
var right: any = this.right.eval(context, locals);
switch (this.operation) {
case '+':
return left + right;
case '-':
return left - right;
case '*':
return left * right;
case '/':
return left / right;
case '%':
return left % right;
case '==':
return left == right;
case '!=':
return left != right;
case '===':
return left === right;
case '!==':
return left !== right;
case '<':
return left < right;
case '>':
return left > right;
case '<=':
return left <= right;
case '>=':
return left >= right;
case '^':
return left ^ right;
case '&':
return left & right;
}
throw 'Internal error [$operation] not handled';
}
visit(visitor: AstVisitor): any { return visitor.visitBinary(this); } visit(visitor: AstVisitor): any { return visitor.visitBinary(this); }
} }
export class PrefixNot extends AST { export class PrefixNot extends AST {
constructor(public expression: AST) { super(); } constructor(public expression: AST) { super(); }
eval(context: any, locals: Locals): any { return !this.expression.eval(context, locals); }
visit(visitor: AstVisitor): any { return visitor.visitPrefixNot(this); } visit(visitor: AstVisitor): any { return visitor.visitPrefixNot(this); }
} }
export class Assignment extends AST {
constructor(public target: AST, public value: any) { super(); }
eval(context: any, locals: Locals): any {
return this.target.assign(context, locals, this.value.eval(context, locals));
}
visit(visitor: AstVisitor): any { return visitor.visitAssignment(this); }
}
export class MethodCall extends AST { export class MethodCall extends AST {
constructor(public receiver: AST, public name: string, public fn: Function, constructor(public receiver: AST, public name: string, public fn: Function,
public args: List<any>) { public args: List<any>) {
super(); super();
} }
eval(context: any, locals: Locals): any {
var evaluatedArgs = evalList(context, locals, this.args);
if (this.receiver instanceof ImplicitReceiver && isPresent(locals) &&
locals.contains(this.name)) {
var fn = locals.get(this.name);
return FunctionWrapper.apply(fn, evaluatedArgs);
} else {
var evaluatedReceiver = this.receiver.eval(context, locals);
return this.fn(evaluatedReceiver, evaluatedArgs);
}
}
visit(visitor: AstVisitor): any { return visitor.visitMethodCall(this); } visit(visitor: AstVisitor): any { return visitor.visitMethodCall(this); }
} }
@ -284,44 +111,17 @@ export class SafeMethodCall extends AST {
public args: List<any>) { public args: List<any>) {
super(); super();
} }
eval(context: any, locals: Locals): any {
var evaluatedReceiver = this.receiver.eval(context, locals);
if (isBlank(evaluatedReceiver)) return null;
var evaluatedArgs = evalList(context, locals, this.args);
return this.fn(evaluatedReceiver, evaluatedArgs);
}
visit(visitor: AstVisitor): any { return visitor.visitSafeMethodCall(this); } visit(visitor: AstVisitor): any { return visitor.visitSafeMethodCall(this); }
} }
export class FunctionCall extends AST { export class FunctionCall extends AST {
constructor(public target: AST, public args: List<any>) { super(); } constructor(public target: AST, public args: List<any>) { super(); }
eval(context: any, locals: Locals): any {
var obj: any = this.target.eval(context, locals);
if (!(obj instanceof Function)) {
throw new BaseException(`${obj} is not a function`);
}
return FunctionWrapper.apply(obj, evalList(context, locals, this.args));
}
visit(visitor: AstVisitor): any { return visitor.visitFunctionCall(this); } visit(visitor: AstVisitor): any { return visitor.visitFunctionCall(this); }
} }
export class ASTWithSource extends AST { export class ASTWithSource extends AST {
constructor(public ast: AST, public source: string, public location: string) { super(); } constructor(public ast: AST, public source: string, public location: string) { super(); }
eval(context: any, locals: Locals): any { return this.ast.eval(context, locals); }
get isAssignable(): boolean { return this.ast.isAssignable; }
assign(context: any, locals: Locals, value: any): any {
return this.ast.assign(context, locals, value);
}
visit(visitor: AstVisitor): any { return this.ast.visit(visitor); } visit(visitor: AstVisitor): any { return this.ast.visit(visitor); }
toString(): string { return `${this.source} in ${this.location}`; } toString(): string { return `${this.source} in ${this.location}`; }
} }
@ -331,8 +131,8 @@ export class TemplateBinding {
} }
export interface AstVisitor { export interface AstVisitor {
visitAccessMember(ast: AccessMember): any; visitPropertyRead(ast: PropertyRead): any;
visitAssignment(ast: Assignment): any; visitPropertyWrite(ast: PropertyWrite): any;
visitBinary(ast: Binary): any; visitBinary(ast: Binary): any;
visitChain(ast: Chain): any; visitChain(ast: Chain): any;
visitConditional(ast: Conditional): any; visitConditional(ast: Conditional): any;
@ -341,13 +141,14 @@ export interface AstVisitor {
visitFunctionCall(ast: FunctionCall): any; visitFunctionCall(ast: FunctionCall): any;
visitImplicitReceiver(ast: ImplicitReceiver): any; visitImplicitReceiver(ast: ImplicitReceiver): any;
visitInterpolation(ast: Interpolation): any; visitInterpolation(ast: Interpolation): any;
visitKeyedAccess(ast: KeyedAccess): any; visitKeyedRead(ast: KeyedRead): any;
visitKeyedWrite(ast: KeyedWrite): any;
visitLiteralArray(ast: LiteralArray): any; visitLiteralArray(ast: LiteralArray): any;
visitLiteralMap(ast: LiteralMap): any; visitLiteralMap(ast: LiteralMap): any;
visitLiteralPrimitive(ast: LiteralPrimitive): any; visitLiteralPrimitive(ast: LiteralPrimitive): any;
visitMethodCall(ast: MethodCall): any; visitMethodCall(ast: MethodCall): any;
visitPrefixNot(ast: PrefixNot): any; visitPrefixNot(ast: PrefixNot): any;
visitSafeAccessMember(ast: SafeAccessMember): any; visitSafePropertyRead(ast: SafePropertyRead): any;
visitSafeMethodCall(ast: SafeMethodCall): any; visitSafeMethodCall(ast: SafeMethodCall): any;
} }
@ -362,12 +163,16 @@ export class AstTransformer implements AstVisitor {
return new LiteralPrimitive(ast.value); return new LiteralPrimitive(ast.value);
} }
visitAccessMember(ast: AccessMember): AccessMember { visitPropertyRead(ast: PropertyRead): PropertyRead {
return new AccessMember(ast.receiver.visit(this), ast.name, ast.getter, ast.setter); return new PropertyRead(ast.receiver.visit(this), ast.name, ast.getter);
} }
visitSafeAccessMember(ast: SafeAccessMember): SafeAccessMember { visitPropertyWrite(ast: PropertyWrite): PropertyWrite {
return new SafeAccessMember(ast.receiver.visit(this), ast.name, ast.getter, ast.setter); return new PropertyWrite(ast.receiver.visit(this), ast.name, ast.setter, ast.value);
}
visitSafePropertyRead(ast: SafePropertyRead): SafePropertyRead {
return new SafePropertyRead(ast.receiver.visit(this), ast.name, ast.getter);
} }
visitMethodCall(ast: MethodCall): MethodCall { visitMethodCall(ast: MethodCall): MethodCall {
@ -405,8 +210,12 @@ export class AstTransformer implements AstVisitor {
return new BindingPipe(ast.exp.visit(this), ast.name, this.visitAll(ast.args)); return new BindingPipe(ast.exp.visit(this), ast.name, this.visitAll(ast.args));
} }
visitKeyedAccess(ast: KeyedAccess): KeyedAccess { visitKeyedRead(ast: KeyedRead): KeyedRead {
return new KeyedAccess(ast.obj.visit(this), ast.key.visit(this)); return new KeyedRead(ast.obj.visit(this), ast.key.visit(this));
}
visitKeyedWrite(ast: KeyedWrite): KeyedWrite {
return new KeyedWrite(ast.obj.visit(this), ast.key.visit(this), ast.value.visit(this));
} }
visitAll(asts: List<any>): List<any> { visitAll(asts: List<any>): List<any> {
@ -419,39 +228,8 @@ export class AstTransformer implements AstVisitor {
visitChain(ast: Chain): Chain { return new Chain(this.visitAll(ast.expressions)); } visitChain(ast: Chain): Chain { return new Chain(this.visitAll(ast.expressions)); }
visitAssignment(ast: Assignment): Assignment {
return new Assignment(ast.target.visit(this), ast.value.visit(this));
}
visitIf(ast: If): If { visitIf(ast: If): If {
let falseExp = isPresent(ast.falseExp) ? ast.falseExp.visit(this) : null; let falseExp = isPresent(ast.falseExp) ? ast.falseExp.visit(this) : null;
return new If(ast.condition.visit(this), ast.trueExp.visit(this), falseExp); return new If(ast.condition.visit(this), ast.trueExp.visit(this), falseExp);
} }
} }
var _evalListCache = [
[],
[0],
[0, 0],
[0, 0, 0],
[0, 0, 0, 0],
[0, 0, 0, 0, 0],
[0, 0, 0, 0, 0, 0],
[0, 0, 0, 0, 0, 0, 0],
[0, 0, 0, 0, 0, 0, 0, 0],
[0, 0, 0, 0, 0, 0, 0, 0, 0],
[0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
];
function evalList(context, locals: Locals, exps: List<any>): any[] {
var length = exps.length;
if (length > 10) {
throw new BaseException("Cannot have more than 10 argument");
}
var result = _evalListCache[length];
for (var i = 0; i < length; i++) {
result[i] = exps[i].eval(context, locals);
}
return result;
}

View File

@ -21,17 +21,18 @@ import {
AST, AST,
EmptyExpr, EmptyExpr,
ImplicitReceiver, ImplicitReceiver,
AccessMember, PropertyRead,
SafeAccessMember, PropertyWrite,
SafePropertyRead,
LiteralPrimitive, LiteralPrimitive,
Binary, Binary,
PrefixNot, PrefixNot,
Conditional, Conditional,
If, If,
BindingPipe, BindingPipe,
Assignment,
Chain, Chain,
KeyedAccess, KeyedRead,
KeyedWrite,
LiteralArray, LiteralArray,
LiteralMap, LiteralMap,
Interpolation, Interpolation,
@ -245,27 +246,7 @@ export class _ParseAST {
return result; return result;
} }
parseExpression(): AST { parseExpression(): AST { return this.parseConditional(); }
var start = this.inputIndex;
var result = this.parseConditional();
while (this.next.isOperator('=')) {
if (!result.isAssignable) {
var end = this.inputIndex;
var expression = this.input.substring(start, end);
this.error(`Expression ${expression} is not assignable`);
}
if (!this.parseAction) {
this.error("Binding expression cannot contain assignments");
}
this.expectOperator('=');
result = new Assignment(result, this.parseConditional());
}
return result;
}
parseConditional(): AST { parseConditional(): AST {
var start = this.inputIndex; var start = this.inputIndex;
@ -393,7 +374,12 @@ export class _ParseAST {
} else if (this.optionalCharacter($LBRACKET)) { } else if (this.optionalCharacter($LBRACKET)) {
var key = this.parsePipe(); var key = this.parsePipe();
this.expectCharacter($RBRACKET); this.expectCharacter($RBRACKET);
result = new KeyedAccess(result, key); if (this.optionalOperator("=")) {
var value = this.parseConditional();
result = new KeyedWrite(result, key, value);
} else {
result = new KeyedRead(result, key);
}
} else if (this.optionalCharacter($LPAREN)) { } else if (this.optionalCharacter($LPAREN)) {
var args = this.parseCallArguments(); var args = this.parseCallArguments();
@ -506,9 +492,28 @@ export class _ParseAST {
} else { } else {
let getter = this.reflector.getter(id); let getter = this.reflector.getter(id);
let setter = this.reflector.setter(id); let setter = this.reflector.setter(id);
return isSafe ? new SafeAccessMember(receiver, id, getter, setter) :
new AccessMember(receiver, id, getter, setter); if (isSafe) {
if (this.optionalOperator("=")) {
this.error("The '?.' operator cannot be used in the assignment");
} else {
return new SafePropertyRead(receiver, id, getter);
}
} else {
if (this.optionalOperator("=")) {
if (!this.parseAction) {
this.error("Bindings cannot contain assignments");
}
let value = this.parseConditional();
return new PropertyWrite(receiver, id, setter, value);
} else {
return new PropertyRead(receiver, id, getter);
}
}
} }
return null;
} }
parseCallArguments(): BindingPipe[] { parseCallArguments(): BindingPipe[] {
@ -629,9 +634,11 @@ class SimpleExpressionChecker implements AstVisitor {
visitLiteralPrimitive(ast: LiteralPrimitive) {} visitLiteralPrimitive(ast: LiteralPrimitive) {}
visitAccessMember(ast: AccessMember) {} visitPropertyRead(ast: PropertyRead) {}
visitSafeAccessMember(ast: SafeAccessMember) { this.simple = false; } visitPropertyWrite(ast: PropertyWrite) { this.simple = false; }
visitSafePropertyRead(ast: SafePropertyRead) { this.simple = false; }
visitMethodCall(ast: MethodCall) { this.simple = false; } visitMethodCall(ast: MethodCall) { this.simple = false; }
@ -651,7 +658,9 @@ class SimpleExpressionChecker implements AstVisitor {
visitPipe(ast: BindingPipe) { this.simple = false; } visitPipe(ast: BindingPipe) { this.simple = false; }
visitKeyedAccess(ast: KeyedAccess) { this.simple = false; } visitKeyedRead(ast: KeyedRead) { this.simple = false; }
visitKeyedWrite(ast: KeyedWrite) { this.simple = false; }
visitAll(asts: List<any>): List<any> { visitAll(asts: List<any>): List<any> {
var res = ListWrapper.createFixedSize(asts.length); var res = ListWrapper.createFixedSize(asts.length);
@ -663,7 +672,5 @@ class SimpleExpressionChecker implements AstVisitor {
visitChain(ast: Chain) { this.simple = false; } visitChain(ast: Chain) { this.simple = false; }
visitAssignment(ast: Assignment) { this.simple = false; }
visitIf(ast: If) { this.simple = false; } visitIf(ast: If) { this.simple = false; }
} }

View File

@ -2,8 +2,9 @@ import {BaseException, Type, isBlank, isPresent, isString} from 'angular2/src/fa
import {List, ListWrapper, MapWrapper, StringMapWrapper} from 'angular2/src/facade/collection'; import {List, ListWrapper, MapWrapper, StringMapWrapper} from 'angular2/src/facade/collection';
import { import {
AccessMember, PropertyRead,
Assignment, PropertyWrite,
KeyedWrite,
AST, AST,
ASTWithSource, ASTWithSource,
AstVisitor, AstVisitor,
@ -15,13 +16,13 @@ import {
FunctionCall, FunctionCall,
ImplicitReceiver, ImplicitReceiver,
Interpolation, Interpolation,
KeyedAccess, KeyedRead,
LiteralArray, LiteralArray,
LiteralMap, LiteralMap,
LiteralPrimitive, LiteralPrimitive,
MethodCall, MethodCall,
PrefixNot, PrefixNot,
SafeAccessMember, SafePropertyRead,
SafeMethodCall SafeMethodCall
} from './parser/ast'; } from './parser/ast';
@ -30,29 +31,42 @@ import {ChangeDetectionUtil} from './change_detection_util';
import {DynamicChangeDetector} from './dynamic_change_detector'; import {DynamicChangeDetector} from './dynamic_change_detector';
import {BindingRecord} from './binding_record'; import {BindingRecord} from './binding_record';
import {DirectiveRecord, DirectiveIndex} from './directive_record'; import {DirectiveRecord, DirectiveIndex} from './directive_record';
import {EventBinding} from './event_binding';
import {coalesce} from './coalesce'; import {coalesce} from './coalesce';
import {ProtoRecord, RecordType} from './proto_record'; import {ProtoRecord, RecordType} from './proto_record';
export class DynamicProtoChangeDetector implements ProtoChangeDetector { export class DynamicProtoChangeDetector implements ProtoChangeDetector {
_records: List<ProtoRecord>; _propertyBindingRecords: ProtoRecord[];
_eventBindingRecords: EventBinding[];
constructor(private definition: ChangeDetectorDefinition) { constructor(private definition: ChangeDetectorDefinition) {
this._records = this._createRecords(definition); this._propertyBindingRecords = createPropertyRecords(definition);
this._eventBindingRecords = createEventRecords(definition);
} }
instantiate(dispatcher: any): ChangeDetector { instantiate(dispatcher: any): ChangeDetector {
return new DynamicChangeDetector(this.definition.id, this.definition.strategy, dispatcher, return new DynamicChangeDetector(this.definition.id, this.definition.strategy, dispatcher,
this._records, this.definition.directiveRecords); this._propertyBindingRecords, this._eventBindingRecords,
this.definition.directiveRecords);
} }
}
_createRecords(definition: ChangeDetectorDefinition) { export function createPropertyRecords(definition: ChangeDetectorDefinition): ProtoRecord[] {
var recordBuilder = new ProtoRecordBuilder(); var recordBuilder = new ProtoRecordBuilder();
ListWrapper.forEach(definition.bindingRecords, ListWrapper.forEach(definition.bindingRecords,
(b) => { recordBuilder.add(b, definition.variableNames); }); (b) => { recordBuilder.add(b, definition.variableNames); });
return coalesce(recordBuilder.records); return coalesce(recordBuilder.records);
} }
export function createEventRecords(definition: ChangeDetectorDefinition): EventBinding[] {
// TODO: vsavkin: remove $event when the compiler handles render-side variables properly
var varNames = ListWrapper.concat(['$event'], definition.variableNames);
return definition.eventRecords.map(er => {
var records = _ConvertAstIntoProtoRecords.create(er, varNames);
var dirIndex = er.implicitReceiver instanceof DirectiveIndex ? er.implicitReceiver : null;
return new EventBinding(er.eventName, er.elementIndex, dirIndex, records);
});
} }
export class ProtoRecordBuilder { export class ProtoRecordBuilder {
@ -105,6 +119,13 @@ class _ConvertAstIntoProtoRecords implements AstVisitor {
b.ast.visit(c); b.ast.visit(c);
} }
static create(b: BindingRecord, variableNames: List<any>): ProtoRecord[] {
var rec = [];
_ConvertAstIntoProtoRecords.append(rec, b, variableNames);
rec[rec.length - 1].lastInBinding = true;
return rec;
}
visitImplicitReceiver(ast: ImplicitReceiver): any { return this._bindingRecord.implicitReceiver; } visitImplicitReceiver(ast: ImplicitReceiver): any { return this._bindingRecord.implicitReceiver; }
visitInterpolation(ast: Interpolation): number { visitInterpolation(ast: Interpolation): number {
@ -117,17 +138,36 @@ class _ConvertAstIntoProtoRecords implements AstVisitor {
return this._addRecord(RecordType.CONST, "literal", ast.value, [], null, 0); return this._addRecord(RecordType.CONST, "literal", ast.value, [], null, 0);
} }
visitAccessMember(ast: AccessMember): number { visitPropertyRead(ast: PropertyRead): number {
var receiver = ast.receiver.visit(this); var receiver = ast.receiver.visit(this);
if (isPresent(this._variableNames) && ListWrapper.contains(this._variableNames, ast.name) && if (isPresent(this._variableNames) && ListWrapper.contains(this._variableNames, ast.name) &&
ast.receiver instanceof ImplicitReceiver) { ast.receiver instanceof ImplicitReceiver) {
return this._addRecord(RecordType.LOCAL, ast.name, ast.name, [], null, receiver); return this._addRecord(RecordType.LOCAL, ast.name, ast.name, [], null, receiver);
} else { } else {
return this._addRecord(RecordType.PROPERTY, ast.name, ast.getter, [], null, receiver); return this._addRecord(RecordType.PROPERTY_READ, ast.name, ast.getter, [], null, receiver);
} }
} }
visitSafeAccessMember(ast: SafeAccessMember): number { visitPropertyWrite(ast: PropertyWrite): number {
if (isPresent(this._variableNames) && ListWrapper.contains(this._variableNames, ast.name) &&
ast.receiver instanceof ImplicitReceiver) {
throw new BaseException(`Cannot reassign a variable binding ${ast.name}`);
} else {
var receiver = ast.receiver.visit(this);
var value = ast.value.visit(this);
return this._addRecord(RecordType.PROPERTY_WRITE, ast.name, ast.setter, [value], null,
receiver);
}
}
visitKeyedWrite(ast: KeyedWrite): number {
var obj = ast.obj.visit(this);
var key = ast.key.visit(this);
var value = ast.value.visit(this);
return this._addRecord(RecordType.KEYED_WRITE, null, null, [key, value], null, obj);
}
visitSafePropertyRead(ast: SafePropertyRead): number {
var receiver = ast.receiver.visit(this); var receiver = ast.receiver.visit(this);
return this._addRecord(RecordType.SAFE_PROPERTY, ast.name, ast.getter, [], null, receiver); return this._addRecord(RecordType.SAFE_PROPERTY, ast.name, ast.getter, [], null, receiver);
} }
@ -195,16 +235,17 @@ class _ConvertAstIntoProtoRecords implements AstVisitor {
return this._addRecord(RecordType.PIPE, ast.name, ast.name, args, null, value); return this._addRecord(RecordType.PIPE, ast.name, ast.name, args, null, value);
} }
visitKeyedAccess(ast: KeyedAccess): number { visitKeyedRead(ast: KeyedRead): number {
var obj = ast.obj.visit(this); var obj = ast.obj.visit(this);
var key = ast.key.visit(this); var key = ast.key.visit(this);
return this._addRecord(RecordType.KEYED_ACCESS, "keyedAccess", ChangeDetectionUtil.keyedAccess, return this._addRecord(RecordType.KEYED_READ, "keyedAccess", ChangeDetectionUtil.keyedAccess,
[key], null, obj); [key], null, obj);
} }
visitAssignment(ast: Assignment) { throw new BaseException('Not supported'); } visitChain(ast: Chain): number {
var args = ast.expressions.map(e => e.visit(this));
visitChain(ast: Chain) { throw new BaseException('Not supported'); } return this._addRecord(RecordType.CHAIN, "chain", null, args, null, 0);
}
visitIf(ast: If) { throw new BaseException('Not supported'); } visitIf(ast: If) { throw new BaseException('Not supported'); }

View File

@ -6,17 +6,20 @@ export enum RecordType {
SELF, SELF,
CONST, CONST,
PRIMITIVE_OP, PRIMITIVE_OP,
PROPERTY, PROPERTY_READ,
PROPERTY_WRITE,
LOCAL, LOCAL,
INVOKE_METHOD, INVOKE_METHOD,
INVOKE_CLOSURE, INVOKE_CLOSURE,
KEYED_ACCESS, KEYED_READ,
KEYED_WRITE,
PIPE, PIPE,
INTERPOLATE, INTERPOLATE,
SAFE_PROPERTY, SAFE_PROPERTY,
COLLECTION_LITERAL, COLLECTION_LITERAL,
SAFE_INVOKE_METHOD, SAFE_INVOKE_METHOD,
DIRECTIVE_LIFECYCLE DIRECTIVE_LIFECYCLE,
CHAIN
} }
export class ProtoRecord { export class ProtoRecord {

View File

@ -1,15 +1,11 @@
import {AST} from 'angular2/src/change_detection/change_detection';
import {isBlank, isPresent, BaseException} from 'angular2/src/facade/lang'; import {isBlank, isPresent, BaseException} from 'angular2/src/facade/lang';
import * as eiModule from './element_injector'; import * as eiModule from './element_injector';
import {DirectiveBinding} from './element_injector'; import {DirectiveBinding} from './element_injector';
import {List, StringMap} from 'angular2/src/facade/collection';
import * as viewModule from './view'; import * as viewModule from './view';
export class ElementBinder { export class ElementBinder {
// updated later, so we are able to resolve cycles // updated later, so we are able to resolve cycles
nestedProtoView: viewModule.AppProtoView = null; nestedProtoView: viewModule.AppProtoView = null;
// updated later when events are bound
hostListeners: StringMap<string, Map<number, AST>> = null;
constructor(public index: int, public parent: ElementBinder, public distanceToParent: int, constructor(public index: int, public parent: ElementBinder, public distanceToParent: int,
public protoElementInjector: eiModule.ProtoElementInjector, public protoElementInjector: eiModule.ProtoElementInjector,

View File

@ -23,12 +23,50 @@ import {AppProtoView} from './view';
import {ElementBinder} from './element_binder'; import {ElementBinder} from './element_binder';
import {ProtoElementInjector, DirectiveBinding} from './element_injector'; import {ProtoElementInjector, DirectiveBinding} from './element_injector';
class BindingRecordsCreator { export class BindingRecordsCreator {
_directiveRecordsMap: Map<number, DirectiveRecord> = new Map(); _directiveRecordsMap: Map<number, DirectiveRecord> = new Map();
getBindingRecords(textBindings: List<ASTWithSource>, getEventBindingRecords(elementBinders: List<renderApi.ElementBinder>,
elementBinders: List<renderApi.ElementBinder>, allDirectiveMetadatas: renderApi.DirectiveMetadata[]): BindingRecord[] {
allDirectiveMetadatas: List<renderApi.DirectiveMetadata>): List<BindingRecord> { var res = [];
for (var boundElementIndex = 0; boundElementIndex < elementBinders.length;
boundElementIndex++) {
var renderElementBinder = elementBinders[boundElementIndex];
this._createTemplateEventRecords(res, renderElementBinder, boundElementIndex);
this._createHostEventRecords(res, renderElementBinder, allDirectiveMetadatas,
boundElementIndex);
}
return res;
}
private _createTemplateEventRecords(res: BindingRecord[],
renderElementBinder: renderApi.ElementBinder,
boundElementIndex: number): void {
renderElementBinder.eventBindings.forEach(eb => {
res.push(BindingRecord.createForEvent(eb.source, eb.fullName, boundElementIndex));
});
}
private _createHostEventRecords(res: BindingRecord[],
renderElementBinder: renderApi.ElementBinder,
allDirectiveMetadatas: renderApi.DirectiveMetadata[],
boundElementIndex: number): void {
for (var i = 0; i < renderElementBinder.directives.length; ++i) {
var dir = renderElementBinder.directives[i];
var directiveMetadata = allDirectiveMetadatas[dir.directiveIndex];
var dirRecord = this._getDirectiveRecord(boundElementIndex, i, directiveMetadata);
dir.eventBindings.forEach(heb => {
res.push(
BindingRecord.createForHostEvent(heb.source, heb.fullName, dirRecord.directiveIndex));
});
}
}
getPropertyBindingRecords(textBindings: List<ASTWithSource>,
elementBinders: List<renderApi.ElementBinder>,
allDirectiveMetadatas:
List<renderApi.DirectiveMetadata>): List<BindingRecord> {
var bindings = []; var bindings = [];
this._createTextNodeRecords(bindings, textBindings); this._createTextNodeRecords(bindings, textBindings);
@ -232,8 +270,10 @@ function _getChangeDetectorDefinitions(
return ListWrapper.map(nestedPvsWithIndex, (pvWithIndex) => { return ListWrapper.map(nestedPvsWithIndex, (pvWithIndex) => {
var elementBinders = pvWithIndex.renderProtoView.elementBinders; var elementBinders = pvWithIndex.renderProtoView.elementBinders;
var bindingRecordsCreator = new BindingRecordsCreator(); var bindingRecordsCreator = new BindingRecordsCreator();
var bindingRecords = bindingRecordsCreator.getBindingRecords( var propBindingRecords = bindingRecordsCreator.getPropertyBindingRecords(
pvWithIndex.renderProtoView.textBindings, elementBinders, allRenderDirectiveMetadata); pvWithIndex.renderProtoView.textBindings, elementBinders, allRenderDirectiveMetadata);
var eventBindingRecords =
bindingRecordsCreator.getEventBindingRecords(elementBinders, allRenderDirectiveMetadata);
var directiveRecords = var directiveRecords =
bindingRecordsCreator.getDirectiveRecords(elementBinders, allRenderDirectiveMetadata); bindingRecordsCreator.getDirectiveRecords(elementBinders, allRenderDirectiveMetadata);
var strategyName = DEFAULT; var strategyName = DEFAULT;
@ -248,8 +288,8 @@ function _getChangeDetectorDefinitions(
} }
var id = `${hostComponentMetadata.id}_${typeString}_${pvWithIndex.index}`; var id = `${hostComponentMetadata.id}_${typeString}_${pvWithIndex.index}`;
var variableNames = nestedPvVariableNames[pvWithIndex.index]; var variableNames = nestedPvVariableNames[pvWithIndex.index];
return new ChangeDetectorDefinition(id, strategyName, variableNames, bindingRecords, return new ChangeDetectorDefinition(id, strategyName, variableNames, propBindingRecords,
directiveRecords, assertionsEnabled()); eventBindingRecords, directiveRecords, assertionsEnabled());
}); });
} }
@ -266,8 +306,6 @@ function _createAppProtoView(
protoChangeDetector, variableBindings, createVariableLocations(elementBinders), protoChangeDetector, variableBindings, createVariableLocations(elementBinders),
renderProtoView.textBindings.length, protoPipes); renderProtoView.textBindings.length, protoPipes);
_createElementBinders(protoView, elementBinders, allDirectives); _createElementBinders(protoView, elementBinders, allDirectives);
_bindDirectiveEvents(protoView, elementBinders);
return protoView; return protoView;
} }
@ -393,8 +431,6 @@ function _createElementBinder(protoView: AppProtoView, boundElementIndex, render
} }
var elBinder = protoView.bindElement(parent, renderElementBinder.distanceToParent, var elBinder = protoView.bindElement(parent, renderElementBinder.distanceToParent,
protoElementInjector, componentDirectiveBinding); protoElementInjector, componentDirectiveBinding);
protoView.bindEvent(renderElementBinder.eventBindings, boundElementIndex, -1);
// variables
// The view's locals needs to have a full set of variable names at construction time // The view's locals needs to have a full set of variable names at construction time
// in order to prevent new variables from being set later in the lifecycle. Since we don't want // in order to prevent new variables from being set later in the lifecycle. Since we don't want
// to actually create variable bindings for the $implicit bindings, add to the // to actually create variable bindings for the $implicit bindings, add to the
@ -450,19 +486,6 @@ function _directiveExportAs(directive): string {
} }
} }
function _bindDirectiveEvents(protoView, elementBinders: List<renderApi.ElementBinder>) {
for (var boundElementIndex = 0; boundElementIndex < elementBinders.length; ++boundElementIndex) {
var dirs = elementBinders[boundElementIndex].directives;
for (var i = 0; i < dirs.length; i++) {
var directiveBinder = dirs[i];
// directive events
protoView.bindEvent(directiveBinder.eventBindings, boundElementIndex, i);
}
}
}
class RenderProtoViewWithIndex { class RenderProtoViewWithIndex {
constructor(public renderProtoView: renderApi.ProtoViewDto, public index: number, constructor(public renderProtoView: renderApi.ProtoViewDto, public index: number,
public parentIndex: number, public boundElementIndex: number) {} public parentIndex: number, public boundElementIndex: number) {}

View File

@ -262,29 +262,12 @@ export class AppView implements ChangeDispatcher, RenderEventDispatcher {
// returns false if preventDefault must be applied to the DOM event // returns false if preventDefault must be applied to the DOM event
dispatchEvent(boundElementIndex: number, eventName: string, locals: Map<string, any>): boolean { dispatchEvent(boundElementIndex: number, eventName: string, locals: Map<string, any>): boolean {
try { try {
// Most of the time the event will be fired only when the view is in the live document.
// However, in a rare circumstance the view might get dehydrated, in between the event
// queuing up and firing.
var allowDefaultBehavior = true;
if (this.hydrated()) { if (this.hydrated()) {
var elBinder = this.proto.elementBinders[boundElementIndex - this.elementOffset]; return !this.changeDetector.handleEvent(eventName, boundElementIndex - this.elementOffset,
if (isBlank(elBinder.hostListeners)) return allowDefaultBehavior; new Locals(this.locals, locals));
var eventMap = elBinder.hostListeners[eventName]; } else {
if (isBlank(eventMap)) return allowDefaultBehavior; return true;
MapWrapper.forEach(eventMap, (expr, directiveIndex) => {
var context;
if (directiveIndex === -1) {
context = this.context;
} else {
context = this.elementInjectors[boundElementIndex].getDirectiveAtIndex(directiveIndex);
}
var result = expr.eval(context, new Locals(this.locals, locals));
if (isPresent(result)) {
allowDefaultBehavior = allowDefaultBehavior && result == true;
}
});
} }
return allowDefaultBehavior;
} catch (e) { } catch (e) {
var c = this.getDebugContext(boundElementIndex - this.elementOffset, null); var c = this.getDebugContext(boundElementIndex - this.elementOffset, null);
var context = isPresent(c) ? new _Context(c.element, c.componentElement, c.context, c.locals, var context = isPresent(c) ? new _Context(c.element, c.componentElement, c.context, c.locals,
@ -354,37 +337,4 @@ export class AppProtoView {
this.elementBinders.push(elBinder); this.elementBinders.push(elBinder);
return elBinder; return elBinder;
} }
/**
* Adds an event binding for the last created ElementBinder via bindElement.
*
* If the directive index is a positive integer, the event is evaluated in the context of
* the given directive.
*
* If the directive index is -1, the event is evaluated in the context of the enclosing view.
*
* @param {string} eventName
* @param {AST} expression
* @param {int} directiveIndex The directive index in the binder or -1 when the event is not bound
* to a directive
*/
bindEvent(eventBindings: List<renderApi.EventBinding>, boundElementIndex: number,
directiveIndex: int = -1): void {
var elBinder = this.elementBinders[boundElementIndex];
var events = elBinder.hostListeners;
if (isBlank(events)) {
events = StringMapWrapper.create();
elBinder.hostListeners = events;
}
for (var i = 0; i < eventBindings.length; i++) {
var eventBinding = eventBindings[i];
var eventName = eventBinding.fullName;
var event = StringMapWrapper.get(events, eventName);
if (isBlank(event)) {
event = new Map();
StringMapWrapper.set(events, eventName, event);
}
event.set(directiveIndex, eventBinding.source);
}
}
} }

View File

@ -13,7 +13,7 @@ import {
ASTWithSource, ASTWithSource,
AST, AST,
AstTransformer, AstTransformer,
AccessMember, PropertyRead,
LiteralArray, LiteralArray,
ImplicitReceiver ImplicitReceiver
} from 'angular2/src/change_detection/change_detection'; } from 'angular2/src/change_detection/change_detection';
@ -278,11 +278,11 @@ export class EventBuilder extends AstTransformer {
return result; return result;
} }
visitAccessMember(ast: AccessMember): AccessMember { visitPropertyRead(ast: PropertyRead): PropertyRead {
var isEventAccess = false; var isEventAccess = false;
var current: AST = ast; var current: AST = ast;
while (!isEventAccess && (current instanceof AccessMember)) { while (!isEventAccess && (current instanceof PropertyRead)) {
var am = <AccessMember>current; var am = <PropertyRead>current;
if (am.name == '$event') { if (am.name == '$event') {
isEventAccess = true; isEventAccess = true;
} }
@ -292,7 +292,7 @@ export class EventBuilder extends AstTransformer {
if (isEventAccess) { if (isEventAccess) {
this.locals.push(ast); this.locals.push(ast);
var index = this.locals.length - 1; var index = this.locals.length - 1;
return new AccessMember(this._implicitReceiver, `${index}`, (arr) => arr[index], null); return new PropertyRead(this._implicitReceiver, `${index}`, (arr) => arr[index]);
} else { } else {
return ast; return ast;
} }

View File

@ -1,7 +1,6 @@
library angular2.transform.template_compiler.change_detector_codegen; library angular2.transform.template_compiler.change_detector_codegen;
import 'package:angular2/src/change_detection/change_detection_util.dart'; import 'package:angular2/src/change_detection/change_detection_util.dart';
import 'package:angular2/src/change_detection/coalesce.dart';
import 'package:angular2/src/change_detection/codegen_facade.dart'; import 'package:angular2/src/change_detection/codegen_facade.dart';
import 'package:angular2/src/change_detection/codegen_logic_util.dart'; import 'package:angular2/src/change_detection/codegen_logic_util.dart';
import 'package:angular2/src/change_detection/codegen_name_util.dart'; import 'package:angular2/src/change_detection/codegen_name_util.dart';
@ -9,6 +8,7 @@ import 'package:angular2/src/change_detection/directive_record.dart';
import 'package:angular2/src/change_detection/interfaces.dart'; import 'package:angular2/src/change_detection/interfaces.dart';
import 'package:angular2/src/change_detection/proto_change_detector.dart'; import 'package:angular2/src/change_detection/proto_change_detector.dart';
import 'package:angular2/src/change_detection/proto_record.dart'; import 'package:angular2/src/change_detection/proto_record.dart';
import 'package:angular2/src/change_detection/event_binding.dart';
import 'package:angular2/src/facade/lang.dart' show BaseException; import 'package:angular2/src/facade/lang.dart' show BaseException;
/// Responsible for generating change detector classes for Angular 2. /// Responsible for generating change detector classes for Angular 2.
@ -74,8 +74,9 @@ class _CodegenState {
/// detail and should not be visible to users. /// detail and should not be visible to users.
final String _changeDetectorTypeName; final String _changeDetectorTypeName;
final String _changeDetectionMode; final String _changeDetectionMode;
final List<ProtoRecord> _records;
final List<DirectiveRecord> _directiveRecords; final List<DirectiveRecord> _directiveRecords;
final List<ProtoRecord> _records;
final List<EventBinding> _eventBindings;
final CodegenLogicUtil _logic; final CodegenLogicUtil _logic;
final CodegenNameUtil _names; final CodegenNameUtil _names;
final bool _generateCheckNoChanges; final bool _generateCheckNoChanges;
@ -86,6 +87,7 @@ class _CodegenState {
this._changeDetectorTypeName, this._changeDetectorTypeName,
String changeDetectionStrategy, String changeDetectionStrategy,
this._records, this._records,
this._eventBindings,
this._directiveRecords, this._directiveRecords,
this._logic, this._logic,
this._names, this._names,
@ -95,10 +97,9 @@ class _CodegenState {
factory _CodegenState(String typeName, String changeDetectorTypeName, factory _CodegenState(String typeName, String changeDetectorTypeName,
ChangeDetectorDefinition def) { ChangeDetectorDefinition def) {
var recBuilder = new ProtoRecordBuilder(); var protoRecords = createPropertyRecords(def);
def.bindingRecords.forEach((rec) => recBuilder.add(rec, def.variableNames)); var eventBindings = createEventRecords(def);
var protoRecords = coalesce(recBuilder.records); var names = new CodegenNameUtil(protoRecords, eventBindings, def.directiveRecords, _UTIL);
var names = new CodegenNameUtil(protoRecords, def.directiveRecords, _UTIL);
var logic = new CodegenLogicUtil(names, _UTIL); var logic = new CodegenLogicUtil(names, _UTIL);
return new _CodegenState._( return new _CodegenState._(
def.id, def.id,
@ -106,6 +107,7 @@ class _CodegenState {
changeDetectorTypeName, changeDetectorTypeName,
def.strategy, def.strategy,
protoRecords, protoRecords,
eventBindings,
def.directiveRecords, def.directiveRecords,
logic, logic,
names, names,
@ -123,6 +125,13 @@ class _CodegenState {
dehydrateDirectives(false); dehydrateDirectives(false);
} }
bool handleEvent(eventName, elIndex, locals) {
var ${_names.getPreventDefaultAccesor()} = false;
${_names.genInitEventLocals()}
${_genHandleEvent()}
return ${this._names.getPreventDefaultAccesor()};
}
void detectChangesInRecordsInternal(throwOnChange) { void detectChangesInRecordsInternal(throwOnChange) {
${_names.genInitLocals()} ${_names.genInitLocals()}
var $_IS_CHANGED_LOCAL = false; var $_IS_CHANGED_LOCAL = false;
@ -152,6 +161,33 @@ class _CodegenState {
'''); ''');
} }
String _genHandleEvent() {
return _eventBindings.map((eb) => _genEventBinding(eb)).join("\n");
}
String _genEventBinding(EventBinding eb) {
var recs = eb.records.map((r) => _genEventBindingEval(eb, r)).join("\n");
return '''
if (eventName == "${eb.eventName}" && elIndex == ${eb.elIndex}) {
${recs}
}''';
}
String _genEventBindingEval(EventBinding eb, ProtoRecord r){
if (r.lastInBinding) {
var evalRecord = _logic.genEventBindingEvalValue(eb, r);
var prevDefault = _genUpdatePreventDefault(eb, r);
return "${evalRecord}\n${prevDefault}";
} else {
return _logic.genEventBindingEvalValue(eb, r);
}
}
String _genUpdatePreventDefault(EventBinding eb, ProtoRecord r) {
var local = this._names.getEventLocalName(eb, r.selfIndex);
return """if (${local} == false) { ${_names.getPreventDefaultAccesor()} = true; }""";
}
void _writeInitToBuf(StringBuffer buf) { void _writeInitToBuf(StringBuffer buf) {
buf.write(''' buf.write('''
$_GEN_PREFIX.preGeneratedProtoDetectors['$_changeDetectorDefId'] = $_GEN_PREFIX.preGeneratedProtoDetectors['$_changeDetectorDefId'] =
@ -295,7 +331,7 @@ class _CodegenState {
var oldValue = _names.getFieldName(r.selfIndex); var oldValue = _names.getFieldName(r.selfIndex);
var newValue = _names.getLocalName(r.selfIndex); var newValue = _names.getLocalName(r.selfIndex);
var read = ''' var read = '''
${_logic.genUpdateCurrentValue(r)} ${_logic.genPropertyBindingEvalValue(r)}
'''; ''';
var check = ''' var check = '''

View File

@ -23,7 +23,7 @@ export function main() {
beforeEach(() => { beforeEach(() => {
proto = new SpyProtoChangeDetector(); proto = new SpyProtoChangeDetector();
def = new ChangeDetectorDefinition('id', null, [], [], [], true); def = new ChangeDetectorDefinition('id', null, [], [], [], [], true);
}); });
it("should return a proto change detector when one is available", () => { it("should return a proto change detector when one is available", () => {

View File

@ -31,6 +31,23 @@ function _createBindingRecords(expression: string): List<BindingRecord> {
return [BindingRecord.createForElementProperty(ast, 0, PROP_NAME)]; return [BindingRecord.createForElementProperty(ast, 0, PROP_NAME)];
} }
function _createEventRecords(expression: string): List<BindingRecord> {
var eq = expression.indexOf("=");
var eventName = expression.substring(1, eq - 1);
var exp = expression.substring(eq + 2, expression.length - 1);
var ast = _getParser().parseAction(exp, 'location');
return [BindingRecord.createForEvent(ast, eventName, 0)];
}
function _createHostEventRecords(expression: string): List<BindingRecord> {
var parts = expression.split("=");
var eventName = parts[0].substring(1, parts[0].length - 1);
var exp = parts[1].substring(1, parts[1].length - 1);
var ast = _getParser().parseAction(exp, 'location');
return [BindingRecord.createForHostEvent(ast, eventName, new DirectiveIndex(0, 0))];
}
function _convertLocalsToVariableBindings(locals: Locals): List<any> { function _convertLocalsToVariableBindings(locals: Locals): List<any> {
var variableBindings = []; var variableBindings = [];
var loc = locals; var loc = locals;
@ -53,24 +70,38 @@ export function getDefinition(id: string): TestDefinition {
let cdDef = val.createChangeDetectorDefinition(); let cdDef = val.createChangeDetectorDefinition();
cdDef.id = id; cdDef.id = id;
testDef = new TestDefinition(id, cdDef, val.locals); testDef = new TestDefinition(id, cdDef, val.locals);
} else if (StringMapWrapper.contains(_ExpressionWithMode.availableDefinitions, id)) { } else if (StringMapWrapper.contains(_ExpressionWithMode.availableDefinitions, id)) {
let val = StringMapWrapper.get(_ExpressionWithMode.availableDefinitions, id); let val = StringMapWrapper.get(_ExpressionWithMode.availableDefinitions, id);
let cdDef = val.createChangeDetectorDefinition(); let cdDef = val.createChangeDetectorDefinition();
cdDef.id = id; cdDef.id = id;
testDef = new TestDefinition(id, cdDef, null); testDef = new TestDefinition(id, cdDef, null);
} else if (StringMapWrapper.contains(_DirectiveUpdating.availableDefinitions, id)) { } else if (StringMapWrapper.contains(_DirectiveUpdating.availableDefinitions, id)) {
let val = StringMapWrapper.get(_DirectiveUpdating.availableDefinitions, id); let val = StringMapWrapper.get(_DirectiveUpdating.availableDefinitions, id);
let cdDef = val.createChangeDetectorDefinition(); let cdDef = val.createChangeDetectorDefinition();
cdDef.id = id; cdDef.id = id;
testDef = new TestDefinition(id, cdDef, null); testDef = new TestDefinition(id, cdDef, null);
} else if (ListWrapper.indexOf(_availableDefinitions, id) >= 0) { } else if (ListWrapper.indexOf(_availableDefinitions, id) >= 0) {
var strategy = null; var strategy = null;
var variableBindings = []; var variableBindings = [];
var bindingRecords = _createBindingRecords(id); var eventRecords = _createBindingRecords(id);
var directiveRecords = []; var directiveRecords = [];
let cdDef = new ChangeDetectorDefinition(id, strategy, variableBindings, bindingRecords, let cdDef = new ChangeDetectorDefinition(id, strategy, variableBindings, eventRecords, [],
directiveRecords, true); directiveRecords, true);
testDef = new TestDefinition(id, cdDef, null); testDef = new TestDefinition(id, cdDef, null);
} else if (ListWrapper.indexOf(_availableEventDefinitions, id) >= 0) {
var eventRecords = _createEventRecords(id);
let cdDef = new ChangeDetectorDefinition(id, null, [], [], eventRecords, [], true);
testDef = new TestDefinition(id, cdDef, null);
} else if (ListWrapper.indexOf(_availableHostEventDefinitions, id) >= 0) {
var eventRecords = _createHostEventRecords(id);
let cdDef = new ChangeDetectorDefinition(id, null, [], [], eventRecords,
[_DirectiveUpdating.basicRecords[0]], true);
testDef = new TestDefinition(id, cdDef, null);
} }
if (isBlank(testDef)) { if (isBlank(testDef)) {
throw `No ChangeDetectorDefinition for ${id} available. Please modify this file if necessary.`; throw `No ChangeDetectorDefinition for ${id} available. Please modify this file if necessary.`;
@ -95,6 +126,8 @@ export function getAllDefinitions(): List<TestDefinition> {
ListWrapper.concat(allDefs, StringMapWrapper.keys(_ExpressionWithMode.availableDefinitions)); ListWrapper.concat(allDefs, StringMapWrapper.keys(_ExpressionWithMode.availableDefinitions));
allDefs = allDefs =
ListWrapper.concat(allDefs, StringMapWrapper.keys(_DirectiveUpdating.availableDefinitions)); ListWrapper.concat(allDefs, StringMapWrapper.keys(_DirectiveUpdating.availableDefinitions));
allDefs = ListWrapper.concat(allDefs, _availableEventDefinitions);
allDefs = ListWrapper.concat(allDefs, _availableHostEventDefinitions);
return ListWrapper.map(allDefs, (id) => getDefinition(id)); return ListWrapper.map(allDefs, (id) => getDefinition(id));
} }
@ -107,7 +140,7 @@ class _ExpressionWithLocals {
var bindingRecords = _createBindingRecords(this._expression); var bindingRecords = _createBindingRecords(this._expression);
var directiveRecords = []; var directiveRecords = [];
return new ChangeDetectorDefinition('(empty id)', strategy, variableBindings, bindingRecords, return new ChangeDetectorDefinition('(empty id)', strategy, variableBindings, bindingRecords,
directiveRecords, true); [], directiveRecords, true);
} }
/** /**
@ -151,7 +184,7 @@ class _ExpressionWithMode {
directiveRecords = []; directiveRecords = [];
} }
return new ChangeDetectorDefinition('(empty id)', this._strategy, variableBindings, return new ChangeDetectorDefinition('(empty id)', this._strategy, variableBindings,
bindingRecords, directiveRecords, true); bindingRecords, [], directiveRecords, true);
} }
/** /**
@ -174,7 +207,7 @@ class _DirectiveUpdating {
var variableBindings = []; var variableBindings = [];
return new ChangeDetectorDefinition('(empty id)', strategy, variableBindings, return new ChangeDetectorDefinition('(empty id)', strategy, variableBindings,
this._bindingRecords, this._directiveRecords, true); this._bindingRecords, [], this._directiveRecords, true);
} }
static updateA(expression: string, dirRecord): BindingRecord { static updateA(expression: string, dirRecord): BindingRecord {
@ -317,3 +350,15 @@ var _availableDefinitions = [
'passThrough([12])', 'passThrough([12])',
'invalidFn(1)' 'invalidFn(1)'
]; ];
var _availableEventDefinitions = [
'(event)="onEvent(\$event)"',
'(event)="b=a=\$event"',
'(event)="a[0]=\$event"',
// '(event)="\$event=1"',
'(event)="a=a+1; a=a+1;"',
'(event)="false"',
'(event)="true"'
];
var _availableHostEventDefinitions = ['(host-event)="onEvent(\$event)"'];

View File

@ -839,6 +839,67 @@ export function main() {
expect(val.dispatcher.log).toEqual(['propName=Megatron']); expect(val.dispatcher.log).toEqual(['propName=Megatron']);
}); });
describe('handleEvent', () => {
var locals;
var d: TestDirective;
beforeEach(() => {
locals = new Locals(null, MapWrapper.createFromStringMap({"$event": "EVENT"}));
d = new TestDirective();
});
it('should execute events', () => {
var val = _createChangeDetector('(event)="onEvent($event)"', d, null);
val.changeDetector.handleEvent("event", 0, locals);
expect(d.event).toEqual("EVENT");
});
it('should execute host events', () => {
var val = _createWithoutHydrate('(host-event)="onEvent($event)"');
val.changeDetector.hydrate(_DEFAULT_CONTEXT, null, new FakeDirectives([d], []), null);
val.changeDetector.handleEvent("host-event", 0, locals);
expect(d.event).toEqual("EVENT");
});
it('should support field assignments', () => {
var val = _createChangeDetector('(event)="b=a=$event"', d, null);
val.changeDetector.handleEvent("event", 0, locals);
expect(d.a).toEqual("EVENT");
expect(d.b).toEqual("EVENT");
});
it('should support keyed assignments', () => {
d.a = ["OLD"];
var val = _createChangeDetector('(event)="a[0]=$event"', d, null);
val.changeDetector.handleEvent("event", 0, locals);
expect(d.a).toEqual(["EVENT"]);
});
it('should support chains', () => {
d.a = 0;
var val = _createChangeDetector('(event)="a=a+1; a=a+1;"', d, null);
val.changeDetector.handleEvent("event", 0, locals);
expect(d.a).toEqual(2);
});
// TODO: enable after chaning dart infrastructure for generating tests
// it('should throw when trying to assign to a local', () => {
// expect(() => {
// _createChangeDetector('(event)="$event=1"', d, null)
// }).toThrowError(new RegExp("Cannot reassign a variable binding"));
// });
it('should return the prevent default value', () => {
var val = _createChangeDetector('(event)="false"', d, null);
var res = val.changeDetector.handleEvent("event", 0, locals);
expect(res).toBe(true);
val = _createChangeDetector('(event)="true"', d, null);
res = val.changeDetector.handleEvent("event", 0, locals);
expect(res).toBe(false);
});
});
}); });
}); });
} }
@ -892,6 +953,7 @@ class TestDirective {
onChangesDoneSpy; onChangesDoneSpy;
onCheckCalled; onCheckCalled;
onInitCalled; onInitCalled;
event;
constructor(onChangesDoneSpy = null) { constructor(onChangesDoneSpy = null) {
this.onChangesDoneCalled = false; this.onChangesDoneCalled = false;
@ -903,6 +965,8 @@ class TestDirective {
this.changes = null; this.changes = null;
} }
onEvent(event) { this.event = event; }
onCheck() { this.onCheckCalled = true; } onCheck() { this.onCheckCalled = true; }
onInit() { this.onInitCalled = true; } onInit() { this.onInitCalled = true; }

View File

@ -15,7 +15,7 @@ export function main() {
argumentToPureFunction?: boolean argumentToPureFunction?: boolean
} = {}) { } = {}) {
if (isBlank(lastInBinding)) lastInBinding = false; if (isBlank(lastInBinding)) lastInBinding = false;
if (isBlank(mode)) mode = RecordType.PROPERTY; if (isBlank(mode)) mode = RecordType.PROPERTY_READ;
if (isBlank(name)) name = "name"; if (isBlank(name)) name = "name";
if (isBlank(directiveIndex)) directiveIndex = null; if (isBlank(directiveIndex)) directiveIndex = null;
if (isBlank(argumentToPureFunction)) argumentToPureFunction = false; if (isBlank(argumentToPureFunction)) argumentToPureFunction = false;

View File

@ -5,9 +5,7 @@ import {MapWrapper, ListWrapper} from 'angular2/src/facade/collection';
import {Parser} from 'angular2/src/change_detection/parser/parser'; import {Parser} from 'angular2/src/change_detection/parser/parser';
import {Unparser} from './unparser'; import {Unparser} from './unparser';
import {Lexer} from 'angular2/src/change_detection/parser/lexer'; import {Lexer} from 'angular2/src/change_detection/parser/lexer';
import {Locals} from 'angular2/src/change_detection/parser/locals';
import {BindingPipe, LiteralPrimitive, AST} from 'angular2/src/change_detection/parser/ast'; import {BindingPipe, LiteralPrimitive, AST} from 'angular2/src/change_detection/parser/ast';
import {IS_DART} from '../../platform';
class TestData { class TestData {
constructor(public a?: any, public b?: any, public fnReturnValue?: any) {} constructor(public a?: any, public b?: any, public fnReturnValue?: any) {}
@ -18,10 +16,6 @@ class TestData {
} }
export function main() { export function main() {
function td(a: any = 0, b: any = 0, fnReturnValue: any = "constant") {
return new TestData(a, b, fnReturnValue);
}
function createParser() { return new Parser(new Lexer(), reflector); } function createParser() { return new Parser(new Lexer(), reflector); }
function parseAction(text, location = null): any { function parseAction(text, location = null): any {
@ -46,364 +40,164 @@ export function main() {
function unparse(ast: AST): string { return new Unparser().unparse(ast); } function unparse(ast: AST): string { return new Unparser().unparse(ast); }
function emptyLocals() { return new Locals(null, new Map()); } function checkBinding(exp: string, expected?: string) {
var ast = parseBinding(exp);
function evalAction(text, passedInContext = null, passedInLocals = null) { if (isBlank(expected)) expected = exp;
var c = isBlank(passedInContext) ? td() : passedInContext; expect(unparse(ast)).toEqual(expected);
var l = isBlank(passedInLocals) ? emptyLocals() : passedInLocals;
return parseAction(text).eval(c, l);
} }
function expectEval(text, passedInContext = null, passedInLocals = null) { function checkAction(exp: string, expected?: string) {
return expect(evalAction(text, passedInContext, passedInLocals)); var ast = parseAction(exp);
if (isBlank(expected)) expected = exp;
expect(unparse(ast)).toEqual(expected);
} }
function expectEvalError(text, passedInContext = null, passedInLocals = null) { function expectActionError(text) { return expect(() => parseAction(text)); }
var c = isBlank(passedInContext) ? td() : passedInContext;
var l = isBlank(passedInLocals) ? emptyLocals() : passedInLocals;
return expect(() => parseAction(text).eval(c, l));
}
function evalAsts(asts, passedInContext = null) { function expectBindingError(text) { return expect(() => parseBinding(text)); }
var c = isBlank(passedInContext) ? td() : passedInContext;
var res = [];
for (var i = 0; i < asts.length; i++) {
res.push(asts[i].eval(c, emptyLocals()));
}
return res;
}
describe("parser", () => { describe("parser", () => {
describe("parseAction", () => { describe("parseAction", () => {
describe("basic expressions", () => { it('should parse numbers', () => { checkAction("1"); });
it('should parse numerical expressions', () => { expectEval("1").toEqual(1); });
it('should parse strings', () => { it('should parse strings', () => {
expectEval("'1'").toEqual('1'); checkAction("'1'", '"1"');
expectEval('"1"').toEqual('1'); checkAction('"1"');
});
it('should parse null', () => { expectEval("null").toBe(null); });
it('should parse unary - expressions', () => {
expectEval("-1").toEqual(-1);
expectEval("+1").toEqual(1);
});
it('should parse unary ! expressions', () => {
expectEval("!true").toEqual(!true);
expectEval("!!true").toEqual(!!true);
expectEval("!!!true").toEqual(!!!true);
});
it('should parse multiplicative expressions',
() => { expectEval("3*4/2%5").toEqual(3 * 4 / 2 % 5); });
it('should parse additive expressions', () => { expectEval("3+6-2").toEqual(3 + 6 - 2); });
it('should parse relational expressions', () => {
expectEval("2<3").toEqual(2 < 3);
expectEval("2>3").toEqual(2 > 3);
expectEval("2<=2").toEqual(2 <= 2);
expectEval("2>=2").toEqual(2 >= 2);
});
it('should parse equality expressions', () => {
expectEval("2==3").toEqual(2 == 3);
expectEval("2=='2'").toEqual(2 == <any>'2');
expectEval("2=='3'").toEqual(2 == <any>'3');
expectEval("2!=3").toEqual(2 != 3);
expectEval("2!='3'").toEqual(2 != <any>'3');
expectEval("2!='2'").toEqual(2 != <any>'2');
expectEval("2!=!false").toEqual(2 != <any>!false);
});
it('should parse strict equality expressions', () => {
expectEval("2===3").toEqual(2 === 3);
expectEval("2==='3'").toEqual(2 === <any>'3');
expectEval("2==='2'").toEqual(2 === <any>'2');
expectEval("2!==3").toEqual(2 !== 3);
expectEval("2!=='3'").toEqual(2 !== <any>'3');
expectEval("2!=='2'").toEqual(2 !== <any>'2');
expectEval("false===!true").toEqual(false === !true);
expectEval("false!==!!true").toEqual(false !== !!true);
});
it('should parse logicalAND expressions', () => {
expectEval("true&&true").toEqual(true && true);
expectEval("true&&false").toEqual(true && false);
});
it('should parse logicalOR expressions', () => {
expectEval("false||true").toEqual(false || true);
expectEval("false||false").toEqual(false || false);
});
it('should short-circuit AND operator',
() => { expectEval('false && a()', td(() => {throw "BOOM"})).toBe(false); });
it('should short-circuit OR operator',
() => { expectEval('true || a()', td(() => {throw "BOOM"})).toBe(true); });
it('should evaluate grouped expressions',
() => { expectEval("(1+2)*3").toEqual((1 + 2) * 3); });
it('should parse an empty string', () => { expectEval('').toBeNull(); });
}); });
it('should parse null', () => { checkAction("null"); });
it('should parse unary - expressions', () => {
checkAction("-1", "0 - 1");
checkAction("+1", "1");
});
it('should parse unary ! expressions', () => {
checkAction("!true");
checkAction("!!true");
checkAction("!!!true");
});
it('should parse multiplicative expressions',
() => { checkAction("3*4/2%5", "3 * 4 / 2 % 5"); });
it('should parse additive expressions', () => { checkAction("3 + 6 - 2"); });
it('should parse relational expressions', () => {
checkAction("2 < 3");
checkAction("2 > 3");
checkAction("2 <= 2");
checkAction("2 >= 2");
});
it('should parse equality expressions', () => {
checkAction("2 == 3");
checkAction("2 != 3");
});
it('should parse strict equality expressions', () => {
checkAction("2 === 3");
checkAction("2 !== 3");
});
it('should parse expressions', () => {
checkAction("true && true");
checkAction("true || false");
});
it('should parse grouped expressions', () => { checkAction("(1 + 2) * 3", "1 + 2 * 3"); });
it('should parse an empty string', () => { checkAction(''); });
describe("literals", () => { describe("literals", () => {
it('should evaluate array', () => { it('should parse array', () => {
expectEval("[1][0]").toEqual(1); checkAction("[1][0]");
expectEval("[[1]][0][0]").toEqual(1); checkAction("[[1]][0][0]");
expectEval("[]").toEqual([]); checkAction("[]");
expectEval("[].length").toEqual(0); checkAction("[].length");
expectEval("[1, 2].length").toEqual(2); checkAction("[1, 2].length");
}); });
it('should evaluate map', () => { it('should parse map', () => {
expectEval("{}").toEqual({}); checkAction("{}");
expectEval("{a:'b'}['a']").toEqual('b'); checkAction("{a: 1}[2]");
expectEval("{'a':'b'}['a']").toEqual('b'); checkAction("{}[\"a\"]");
expectEval("{\"a\":'b'}['a']").toEqual('b');
expectEval("{\"a\":'b'}['a']").toEqual("b");
expectEval("{}['a']").not.toBeDefined();
expectEval("{\"a\":'b'}['invalid']").not.toBeDefined();
}); });
it('should only allow identifier, string, or keyword as map key', () => { it('should only allow identifier, string, or keyword as map key', () => {
expectEvalError('{(:0}') expectActionError('{(:0}')
.toThrowError(new RegExp('expected identifier, keyword, or string')); .toThrowError(new RegExp('expected identifier, keyword, or string'));
expectEvalError('{1234:0}') expectActionError('{1234:0}')
.toThrowError(new RegExp('expected identifier, keyword, or string')); .toThrowError(new RegExp('expected identifier, keyword, or string'));
}); });
}); });
describe("member access", () => { describe("member access", () => {
it("should parse field access", () => { it("should parse field access", () => {
expectEval("a", td(999)).toEqual(999); checkAction("a");
expectEval("a.a", td(td(999))).toEqual(999); checkAction("a.a");
}); });
it('should throw when accessing a field on null',
() => { expectEvalError("a.a.a").toThrowError(); });
it('should only allow identifier or keyword as member names', () => { it('should only allow identifier or keyword as member names', () => {
expectEvalError('x.(').toThrowError(new RegExp('identifier or keyword')); expectActionError('x.(').toThrowError(new RegExp('identifier or keyword'));
expectEvalError('x. 1234').toThrowError(new RegExp('identifier or keyword')); expectActionError('x. 1234').toThrowError(new RegExp('identifier or keyword'));
expectEvalError('x."foo"').toThrowError(new RegExp('identifier or keyword')); expectActionError('x."foo"').toThrowError(new RegExp('identifier or keyword'));
}); });
it("should read a field from Locals", () => { it('should parse safe field access', () => {
var locals = new Locals(null, MapWrapper.createFromPairs([["key", "value"]])); checkAction('a?.a');
expectEval("key", null, locals).toEqual("value"); checkAction('a.a?.a');
});
it("should handle nested Locals", () => {
var nested = new Locals(null, MapWrapper.createFromPairs([["key", "value"]]));
var locals = new Locals(nested, new Map());
expectEval("key", null, locals).toEqual("value");
});
it("should fall back to a regular field read when Locals " +
"does not have the requested field",
() => {
var locals = new Locals(null, new Map());
expectEval("a", td(999), locals).toEqual(999);
});
});
describe('safe navigation operator', () => {
it('should parse field access', () => {
expectEval('a?.a', td(td(999))).toEqual(999);
expectEval('a.a?.a', td(td(td(999)))).toEqual(999);
});
it('should return null when accessing a field on null',
() => { expect(() => { expectEval('null?.a', td()).toEqual(null); }).not.toThrow(); });
it('should have the same priority as .', () => {
expect(() => { expectEval('null?.a.a', td()).toEqual(null); }).toThrowError();
});
if (!IS_DART) {
it('should return null when accessing a field on undefined', () => {
expect(() => { expectEval('_undefined?.a', td()).toEqual(null); }).not.toThrow();
});
}
it('should evaluate method calls',
() => { expectEval('a?.add(1,2)', td(td())).toEqual(3); });
it('should return null when accessing a method on null', () => {
expect(() => { expectEval('null?.add(1, 2)', td()).toEqual(null); }).not.toThrow();
}); });
}); });
describe("method calls", () => { describe("method calls", () => {
it("should evaluate method calls", () => { it("should parse method calls", () => {
expectEval("fn()", td(0, 0, "constant")).toEqual("constant"); checkAction("fn()");
expectEval("add(1,2)").toEqual(3); checkAction("add(1, 2)");
expectEval("a.add(1,2)", td(td())).toEqual(3); checkAction("a.add(1, 2)");
expectEval("fn().add(1,2)", td(0, 0, td())).toEqual(3); checkAction("fn().add(1, 2)");
}); });
it('should throw when more than 10 arguments', () => {
expectEvalError("fn(1,2,3,4,5,6,7,8,9,10,11)").toThrowError(new RegExp('more than'));
});
it('should throw when no method', () => { expectEvalError("blah()").toThrowError(); });
it('should evaluate a method from Locals', () => {
var locals = new Locals(null, MapWrapper.createFromPairs([['fn', () => 'child']]));
expectEval("fn()", td(0, 0, 'parent'), locals).toEqual('child');
});
it('should fall back to the parent context when Locals does not ' +
'have the requested method',
() => {
var locals = new Locals(null, new Map());
expectEval("fn()", td(0, 0, 'parent'), locals).toEqual('parent');
});
}); });
describe("functional calls", () => { describe("functional calls",
it("should evaluate function calls", () => { it("should parse function calls", () => { checkAction("fn()(1, 2)"); }); });
() => { expectEval("fn()(1,2)", td(0, 0, (a, b) => a + b)).toEqual(3); });
it('should throw on non-function function calls',
() => { expectEvalError("4()").toThrowError(new RegExp('4 is not a function')); });
it('should parse functions for object indices',
() => { expectEval('a[b()]()', td([() => 6], () => 0)).toEqual(6); });
});
describe("conditional", () => { describe("conditional", () => {
it('should parse ternary/conditional expressions', () => { it('should parse ternary/conditional expressions', () => {
expectEval("7==3+4?10:20").toEqual(10); checkAction("7 == 3 + 4 ? 10 : 20");
expectEval("false?10:20").toEqual(20); checkAction("false ? 10 : 20");
}); });
it('should throw on incorrect ternary operator syntax', () => { it('should throw on incorrect ternary operator syntax', () => {
expectEvalError("true?1").toThrowError(new RegExp( expectActionError("true?1").toThrowError(new RegExp(
'Parser Error: Conditional expression true\\?1 requires all 3 expressions')); 'Parser Error: Conditional expression true\\?1 requires all 3 expressions'));
}); });
}); });
describe("if", () => { describe("if", () => {
it('should parse if statements', () => { it('should parse if statements', () => {
checkAction("if (true) a = 0");
var fixtures = [ checkAction("if (true) {a = 0;}", "if (true) a = 0");
['if (true) a = 0', 0, null],
['if (false) a = 0', null, null],
['if (a == null) b = 0', null, 0],
['if (true) { a = 0; b = 0 }', 0, 0],
['if (true) { a = 0; b = 0 } else { a = 1; b = 1; }', 0, 0],
['if (false) { a = 0; b = 0 } else { a = 1; b = 1; }', 1, 1],
['if (false) { } else { a = 1; b = 1; }', 1, 1],
];
fixtures.forEach(fix => {
var testData = td(null, null);
evalAction(fix[0], testData);
expect(testData.a).toEqual(fix[1]);
expect(testData.b).toEqual(fix[2]);
});
}); });
}); });
describe("assignment", () => { describe("assignment", () => {
it("should support field assignments", () => { it("should support field assignments", () => {
var context = td(); checkAction("a = 12");
expectEval("a=12", context).toEqual(12); checkAction("a.a.a = 123");
expect(context.a).toEqual(12); checkAction("a = 123; b = 234;");
}); });
it("should support nested field assignments", () => { it("should throw on safe field assignments", () => {
var context = td(td(td())); expectActionError("a?.a = 123")
expectEval("a.a.a=123;", context).toEqual(123); .toThrowError(new RegExp('cannot be used in the assignment'));
expect(context.a.a.a).toEqual(123);
}); });
it("should support multiple assignments", () => { it("should support array updates", () => { checkAction("a[0] = 200"); });
var context = td();
expectEval("a=123; b=234", context).toEqual(234);
expect(context.a).toEqual(123);
expect(context.b).toEqual(234);
});
it("should support array updates", () => {
var context = td([100]);
expectEval('a[0] = 200', context).toEqual(200);
expect(context.a[0]).toEqual(200);
});
it("should support map updates", () => {
var context = td({"key": 100});
expectEval('a["key"] = 200', context).toEqual(200);
expect(context.a["key"]).toEqual(200);
});
it("should support array/map updates", () => {
var context = td([{"key": 100}]);
expectEval('a[0]["key"] = 200', context).toEqual(200);
expect(context.a[0]["key"]).toEqual(200);
});
it('should allow assignment after array dereference', () => {
var context = td([td()]);
expectEval('a[0].a = 200', context).toEqual(200);
expect(context.a[0].a).toEqual(200);
});
it('should throw on bad assignment', () => {
expectEvalError("5=4").toThrowError(new RegExp("Expression 5 is not assignable"));
});
it('should reassign when no variable binding with the given name', () => {
var context = td();
var locals = new Locals(null, new Map());
expectEval('a = 200', context, locals).toEqual(200);
expect(context.a).toEqual(200);
});
it('should throw when reassigning a variable binding', () => {
var locals = new Locals(null, MapWrapper.createFromPairs([["key", "value"]]));
expectEvalError('key = 200', null, locals)
.toThrowError(new RegExp("Cannot reassign a variable binding"));
});
});
describe("general error handling", () => {
it("should throw on an unexpected token", () => {
expectEvalError("[1,2] trac").toThrowError(new RegExp('Unexpected token \'trac\''));
});
it('should throw a reasonable error for unconsumed tokens', () => {
expectEvalError(")")
.toThrowError(new RegExp("Unexpected token \\) at column 1 in \\[\\)\\]"));
});
it('should throw on missing expected token', () => {
expectEvalError("a(b").toThrowError(
new RegExp("Missing expected \\) at the end of the expression \\[a\\(b\\]"));
});
}); });
it("should error when using pipes", it("should error when using pipes",
() => { expectEvalError('x|blah').toThrowError(new RegExp('Cannot have a pipe')); }); () => { expectActionError('x|blah').toThrowError(new RegExp('Cannot have a pipe')); });
it('should pass exceptions', () => {
expect(() => {
parseAction('a()').eval(td(() => {throw new BaseException("boo to you")}), emptyLocals());
}).toThrowError('boo to you');
});
describe("multiple statements", () => {
it("should return the last non-blank value", () => {
expectEval("a=1;b=3;a+b").toEqual(4);
expectEval("1;;").toEqual(1);
});
});
it('should store the source in the result', it('should store the source in the result',
() => { expect(parseAction('someExpr').source).toBe('someExpr'); }); () => { expect(parseAction('someExpr').source).toBe('someExpr'); });
@ -412,51 +206,40 @@ export function main() {
() => { expect(parseAction('someExpr', 'location').location).toBe('location'); }); () => { expect(parseAction('someExpr', 'location').location).toBe('location'); });
}); });
describe("general error handling", () => {
it("should throw on an unexpected token", () => {
expectActionError("[1,2] trac").toThrowError(new RegExp('Unexpected token \'trac\''));
});
it('should throw a reasonable error for unconsumed tokens', () => {
expectActionError(")")
.toThrowError(new RegExp("Unexpected token \\) at column 1 in \\[\\)\\]"));
});
it('should throw on missing expected token', () => {
expectActionError("a(b").toThrowError(
new RegExp("Missing expected \\) at the end of the expression \\[a\\(b\\]"));
});
});
describe("parseBinding", () => { describe("parseBinding", () => {
describe("pipes", () => { describe("pipes", () => {
it("should parse pipes", () => { it("should parse pipes", () => {
var originalExp = '"Foo" | uppercase'; checkBinding('a(b | c)', 'a((b | c))');
var ast = parseBinding(originalExp).ast; checkBinding('a.b(c.d(e) | f)', 'a.b((c.d(e) | f))');
expect(ast).toBeAnInstanceOf(BindingPipe); checkBinding('[1, 2, 3] | a', '([1, 2, 3] | a)');
expect(new Unparser().unparse(ast)).toEqual(`(${originalExp})`); checkBinding('{a: 1} | b', '({a: 1} | b)');
}); checkBinding('a[b] | c', '(a[b] | c)');
checkBinding('a?.b | c', '(a?.b | c)');
it("should parse pipes in the middle of a binding", () => { checkBinding('true | a', '(true | a)');
var ast = parseBinding('(user | a | b).name').ast; checkBinding('a | b:c | d', '(a | b:(c | d))');
expect(new Unparser().unparse(ast)).toEqual('((user | a) | b).name'); checkBinding('(a | b:c) | d', '((a | b:c) | d)');
});
it("should parse pipes with args", () => {
var ast = parseBinding("(1|a:2)|b:3").ast;
expect(new Unparser().unparse(ast)).toEqual('((1 | a:2) | b:3)');
}); });
it('should only allow identifier or keyword as formatter names', () => { it('should only allow identifier or keyword as formatter names', () => {
expect(() => parseBinding('"Foo"|(')).toThrowError(new RegExp('identifier or keyword')); expectBindingError('"Foo"|(').toThrowError(new RegExp('identifier or keyword'));
expect(() => parseBinding('"Foo"|1234')) expectBindingError('"Foo"|1234').toThrowError(new RegExp('identifier or keyword'));
.toThrowError(new RegExp('identifier or keyword')); expectBindingError('"Foo"|"uppercase"').toThrowError(new RegExp('identifier or keyword'));
expect(() => parseBinding('"Foo"|"uppercase"'))
.toThrowError(new RegExp('identifier or keyword'));
});
it('should parse pipes', () => {
let unparser = new Unparser();
let exps = [
['a(b | c)', 'a((b | c))'],
['a.b(c.d(e) | f)', 'a.b((c.d(e) | f))'],
['[1, 2, 3] | a', '([1, 2, 3] | a)'],
['{a: 1} | b', '({a: 1} | b)'],
['a[b] | c', '(a[b] | c)'],
['a?.b | c', '(a?.b | c)'],
['true | a', '(true | a)'],
['a | b:c | d', '(a | b:(c | d))'],
['(a | b:c) | d', '((a | b:c) | d)']
];
ListWrapper.forEach(exps, e => {
var ast = parseBinding(e[0]).ast;
expect(unparser.unparse(ast)).toEqual(e[1]);
});
}); });
}); });
@ -471,7 +254,7 @@ export function main() {
}); });
it('should throw on assignment', () => { it('should throw on assignment', () => {
expect(() => parseBinding("1;2")).toThrowError(new RegExp("contain chained expression")); expect(() => parseBinding("a=2")).toThrowError(new RegExp("contain assignments"));
}); });
}); });
@ -497,21 +280,10 @@ export function main() {
null); null);
} }
function exprAsts(templateBindings) { it('should parse an empty string', () => { expect(parseTemplateBindings('')).toEqual([]); });
return ListWrapper.map(templateBindings, (binding) => isPresent(binding.expression) ?
binding.expression :
null);
}
it('should parse an empty string', () => { it('should parse a string without a value',
var bindings = parseTemplateBindings(''); () => { expect(keys(parseTemplateBindings('a'))).toEqual(['a']); });
expect(bindings).toEqual([]);
});
it('should parse a string without a value', () => {
var bindings = parseTemplateBindings('a');
expect(keys(bindings)).toEqual(['a']);
});
it('should only allow identifier, string, or keyword including dashes as keys', () => { it('should only allow identifier, string, or keyword including dashes as keys', () => {
var bindings = parseTemplateBindings("a:'b'"); var bindings = parseTemplateBindings("a:'b'");
@ -536,11 +308,9 @@ export function main() {
it('should detect expressions as value', () => { it('should detect expressions as value', () => {
var bindings = parseTemplateBindings("a:b"); var bindings = parseTemplateBindings("a:b");
expect(exprSources(bindings)).toEqual(['b']); expect(exprSources(bindings)).toEqual(['b']);
expect(evalAsts(exprAsts(bindings), td(0, 23))).toEqual([23]);
bindings = parseTemplateBindings("a:1+1"); bindings = parseTemplateBindings("a:1+1");
expect(exprSources(bindings)).toEqual(['1+1']); expect(exprSources(bindings)).toEqual(['1+1']);
expect(evalAsts(exprAsts(bindings))).toEqual([2]);
}); });
it('should detect names as value', () => { it('should detect names as value', () => {
@ -657,8 +427,7 @@ export function main() {
describe('wrapLiteralPrimitive', () => { describe('wrapLiteralPrimitive', () => {
it('should wrap a literal primitive', () => { it('should wrap a literal primitive', () => {
expect(createParser().wrapLiteralPrimitive("foo", null).eval(null, emptyLocals())) expect(unparse(createParser().wrapLiteralPrimitive("foo", null))).toEqual('"foo"');
.toEqual("foo");
}); });
}); });
}); });

View File

@ -1,8 +1,8 @@
import { import {
AST, AST,
AstVisitor, AstVisitor,
AccessMember, PropertyRead,
Assignment, PropertyWrite,
Binary, Binary,
Chain, Chain,
Conditional, Conditional,
@ -12,13 +12,14 @@ import {
FunctionCall, FunctionCall,
ImplicitReceiver, ImplicitReceiver,
Interpolation, Interpolation,
KeyedAccess, KeyedRead,
KeyedWrite,
LiteralArray, LiteralArray,
LiteralMap, LiteralMap,
LiteralPrimitive, LiteralPrimitive,
MethodCall, MethodCall,
PrefixNot, PrefixNot,
SafeAccessMember, SafePropertyRead,
SafeMethodCall SafeMethodCall
} from 'angular2/src/change_detection/parser/ast'; } from 'angular2/src/change_detection/parser/ast';
@ -35,15 +36,15 @@ export class Unparser implements AstVisitor {
return this._expression; return this._expression;
} }
visitAccessMember(ast: AccessMember) { visitPropertyRead(ast: PropertyRead) {
this._visit(ast.receiver); this._visit(ast.receiver);
this._expression += ast.receiver instanceof ImplicitReceiver ? `${ast.name}` : `.${ast.name}`; this._expression += ast.receiver instanceof ImplicitReceiver ? `${ast.name}` : `.${ast.name}`;
} }
visitAssignment(ast: Assignment) { visitPropertyWrite(ast: PropertyWrite) {
this._visit(ast.target); this._visit(ast.receiver);
this._expression += ' = '; this._expression +=
ast.receiver instanceof ImplicitReceiver ? `${ast.name} = ` : `.${ast.name} = `;
this._visit(ast.value); this._visit(ast.value);
} }
@ -116,13 +117,21 @@ export class Unparser implements AstVisitor {
} }
} }
visitKeyedAccess(ast: KeyedAccess) { visitKeyedRead(ast: KeyedRead) {
this._visit(ast.obj); this._visit(ast.obj);
this._expression += '['; this._expression += '[';
this._visit(ast.key); this._visit(ast.key);
this._expression += ']'; this._expression += ']';
} }
visitKeyedWrite(ast: KeyedWrite) {
this._visit(ast.obj);
this._expression += '[';
this._visit(ast.key);
this._expression += '] = ';
this._visit(ast.value);
}
visitLiteralArray(ast: LiteralArray) { visitLiteralArray(ast: LiteralArray) {
this._expression += '['; this._expression += '[';
var isFirst = true; var isFirst = true;
@ -173,7 +182,7 @@ export class Unparser implements AstVisitor {
this._visit(ast.expression); this._visit(ast.expression);
} }
visitSafeAccessMember(ast: SafeAccessMember) { visitSafePropertyRead(ast: SafePropertyRead) {
this._visit(ast.receiver); this._visit(ast.receiver);
this._expression += `?.${ast.name}`; this._expression += `?.${ast.name}`;
} }

View File

@ -1,132 +0,0 @@
import {ddescribe, describe, it, xit, iit, expect, beforeEach} from 'angular2/test_lib';
import {
AST,
ASTWithSource,
AccessMember,
Assignment,
Binary,
Chain,
Conditional,
EmptyExpr,
If,
BindingPipe,
ImplicitReceiver,
Interpolation,
KeyedAccess,
LiteralArray,
LiteralMap,
LiteralPrimitive,
MethodCall,
PrefixNot,
SafeAccessMember,
SafeMethodCall
} from 'angular2/src/change_detection/parser/ast';
import {Parser} from 'angular2/src/change_detection/parser/parser';
import {Lexer} from 'angular2/src/change_detection/parser/lexer';
import {Unparser} from './unparser';
import {reflector} from 'angular2/src/reflection/reflection';
import {isPresent, Type} from 'angular2/src/facade/lang';
export function main() {
let parser: Parser = new Parser(new Lexer(), reflector);
let unparser: Unparser = new Unparser();
function parseAction(text, location = null): ASTWithSource {
return parser.parseAction(text, location);
}
function parseBinding(text, location = null): ASTWithSource {
return parser.parseBinding(text, location);
}
function check(expression: string, type: Type): void {
var ast = parseAction(expression).ast;
if (isPresent(type)) {
expect(ast).toBeAnInstanceOf(type);
}
expect(unparser.unparse(ast)).toEqual(expression);
}
describe('Unparser', () => {
it('should support AccessMember', () => {
check('a', AccessMember);
check('a.b', AccessMember);
});
it('should support Assignment', () => { check('a = b', Assignment); });
it('should support Binary', () => { check('a && b', Binary); });
it('should support Chain', () => { check('a; b;', Chain); });
it('should support Conditional', () => { check('a ? b : c', Conditional); });
it('should support Pipe', () => {
var originalExp = '(a | b)';
var ast = parseBinding(originalExp).ast;
expect(ast).toBeAnInstanceOf(BindingPipe);
expect(unparser.unparse(ast)).toEqual(originalExp);
});
it('should support KeyedAccess', () => { check('a[b]', KeyedAccess); });
it('should support LiteralArray', () => { check('[a, b]', LiteralArray); });
it('should support LiteralMap', () => { check('{a: b, c: d}', LiteralMap); });
it('should support LiteralPrimitive', () => {
check('true', LiteralPrimitive);
check('"a"', LiteralPrimitive);
check('1.234', LiteralPrimitive);
});
it('should support MethodCall', () => {
check('a(b, c)', MethodCall);
check('a.b(c, d)', MethodCall);
});
it('should support PrefixNot', () => { check('!a', PrefixNot); });
it('should support SafeAccessMember', () => { check('a?.b', SafeAccessMember); });
it('should support SafeMethodCall', () => { check('a?.b(c, d)', SafeMethodCall); });
it('should support if statements', () => {
var ifs = [
'if (true) a()',
'if (true) a() else b()',
'if (a()) { b = 1; c = 2; }',
'if (a()) b = 1 else { c = 2; d = e(); }'
];
ifs.forEach(ifStmt => check(ifStmt, If));
});
it('should support complex expression', () => {
var originalExp = 'a + 3 * fn([(c + d | e).f], {a: 3})[g].h && i';
var ast = parseBinding(originalExp).ast;
expect(unparser.unparse(ast)).toEqual(originalExp);
});
it('should support Interpolation', () => {
var ast = parser.parseInterpolation('a {{ b }}', null).ast;
expect(ast).toBeAnInstanceOf(Interpolation);
expect(unparser.unparse(ast)).toEqual('a {{ b }}');
ast = parser.parseInterpolation('a {{ b }} c', null).ast;
expect(ast).toBeAnInstanceOf(Interpolation);
expect(unparser.unparse(ast)).toEqual('a {{ b }} c');
});
it('should support EmptyExpr', () => {
var ast = parser.parseAction('if (true) { }', null).ast;
expect(ast).toBeAnInstanceOf(If);
expect((<If>ast).trueExp).toBeAnInstanceOf(EmptyExpr);
expect(unparser.unparse(ast)).toEqual('if (true) { }');
});
});
}

View File

@ -14,7 +14,7 @@ export function main() {
referencedBySelf?: boolean referencedBySelf?: boolean
} = {}) { } = {}) {
if (isBlank(lastInBinding)) lastInBinding = false; if (isBlank(lastInBinding)) lastInBinding = false;
if (isBlank(mode)) mode = RecordType.PROPERTY; if (isBlank(mode)) mode = RecordType.PROPERTY_READ;
if (isBlank(name)) name = "name"; if (isBlank(name)) name = "name";
if (isBlank(directiveIndex)) directiveIndex = null; if (isBlank(directiveIndex)) directiveIndex = null;
if (isBlank(argumentToPureFunction)) argumentToPureFunction = false; if (isBlank(argumentToPureFunction)) argumentToPureFunction = false;

View File

@ -937,7 +937,7 @@ export function main() {
}); });
it("should inject ChangeDetectorRef of the component's view into the component", () => { it("should inject ChangeDetectorRef of the component's view into the component", () => {
var cd = new DynamicChangeDetector(null, null, null, [], []); var cd = new DynamicChangeDetector(null, null, null, [], [], []);
var view = <any>new DummyView(); var view = <any>new DummyView();
var childView = new DummyView(); var childView = new DummyView();
childView.changeDetector = cd; childView.changeDetector = cd;
@ -950,7 +950,7 @@ export function main() {
}); });
it("should inject ChangeDetectorRef of the containing component into directives", () => { it("should inject ChangeDetectorRef of the containing component into directives", () => {
var cd = new DynamicChangeDetector(null, null, null, [], []); var cd = new DynamicChangeDetector(null, null, null, [], [], []);
var view = <any>new DummyView(); var view = <any>new DummyView();
view.changeDetector =cd; view.changeDetector =cd;
var binding = DirectiveBinding.createFromType(DirectiveNeedsChangeDetectorRef, new dirAnn.Directive()); var binding = DirectiveBinding.createFromType(DirectiveNeedsChangeDetectorRef, new dirAnn.Directive());

View File

@ -18,9 +18,12 @@ import {MapWrapper} from 'angular2/src/facade/collection';
import { import {
ChangeDetection, ChangeDetection,
ChangeDetectorDefinition ChangeDetectorDefinition,
BindingRecord,
DirectiveIndex
} from 'angular2/src/change_detection/change_detection'; } from 'angular2/src/change_detection/change_detection';
import { import {
BindingRecordsCreator,
ProtoViewFactory, ProtoViewFactory,
getChangeDetectorDefinitions, getChangeDetectorDefinitions,
createDirectiveVariableBindings, createDirectiveVariableBindings,
@ -162,6 +165,50 @@ export function main() {
])).toEqual(MapWrapper.createFromStringMap<number>({'a': 0, 'b': 1})); ])).toEqual(MapWrapper.createFromStringMap<number>({'a': 0, 'b': 1}));
}); });
}); });
describe('BindingRecordsCreator', () => {
var creator: BindingRecordsCreator;
beforeEach(() => { creator = new BindingRecordsCreator(); });
describe('getEventBindingRecords', () => {
it("should return template event records", () => {
var rec = creator.getEventBindingRecords(
[
new renderApi.ElementBinder(
{eventBindings: [new renderApi.EventBinding("a", null)], directives: []}),
new renderApi.ElementBinder(
{eventBindings: [new renderApi.EventBinding("b", null)], directives: []})
],
[]);
expect(rec).toEqual([
BindingRecord.createForEvent(null, "a", 0),
BindingRecord.createForEvent(null, "b", 1)
]);
});
it('should return host event records', () => {
var rec = creator.getEventBindingRecords(
[
new renderApi.ElementBinder({
eventBindings: [],
directives: [
new renderApi.DirectiveBinder({
directiveIndex: 0,
eventBindings: [new renderApi.EventBinding("a", null)]
})
]
})
],
[renderApi.DirectiveMetadata.create({id: 'some-id'})]);
expect(rec.length).toEqual(1);
expect(rec[0].eventName).toEqual("a");
expect(rec[0].implicitReceiver).toBeAnInstanceOf(DirectiveIndex);
});
});
});
}); });
} }

View File

@ -79,6 +79,7 @@ export function main() {
tcb.overrideTemplate(MyComp, t).createAsync(MyComp).then((root) => { rootTC = root; }); tcb.overrideTemplate(MyComp, t).createAsync(MyComp).then((root) => { rootTC = root; });
tick(); tick();
rootTC.componentInstance.form = new ControlGroup({}); rootTC.componentInstance.form = new ControlGroup({});
rootTC.componentInstance.name = 'old'; rootTC.componentInstance.name = 'old';

View File

@ -36,6 +36,11 @@ class _MyComponent_ChangeDetector0
dehydrateDirectives(false); dehydrateDirectives(false);
} }
bool handleEvent(eventName, elIndex, locals) {
var preventDefault = false;
return preventDefault;
}
void detectChangesInRecordsInternal(throwOnChange) { void detectChangesInRecordsInternal(throwOnChange) {
var l_context = this.context, l_myNum0, c_myNum0, l_interpolate1; var l_context = this.context, l_myNum0, c_myNum0, l_interpolate1;
c_myNum0 = false; c_myNum0 = false;

View File

@ -250,7 +250,7 @@ function setUpChangeDetection(changeDetection: ChangeDetection, iterations, obje
var parser = new Parser(new Lexer()); var parser = new Parser(new Lexer());
var parentProto = changeDetection.createProtoChangeDetector( var parentProto = changeDetection.createProtoChangeDetector(
new ChangeDetectorDefinition('parent', null, [], [], [], false)); new ChangeDetectorDefinition('parent', null, [], [], [], [], false));
var parentCd = parentProto.instantiate(dispatcher); var parentCd = parentProto.instantiate(dispatcher);
var directiveRecord = new DirectiveRecord({directiveIndex: new DirectiveIndex(0, 0)}); var directiveRecord = new DirectiveRecord({directiveIndex: new DirectiveIndex(0, 0)});
@ -278,7 +278,7 @@ function setUpChangeDetection(changeDetection: ChangeDetection, iterations, obje
]; ];
var proto = changeDetection.createProtoChangeDetector( var proto = changeDetection.createProtoChangeDetector(
new ChangeDetectorDefinition("proto", null, [], bindings, [directiveRecord], false)); new ChangeDetectorDefinition("proto", null, [], bindings, [], [directiveRecord], false));
var targetObj = new Obj(); var targetObj = new Obj();
parentCd.hydrate(object, null, new FakeDirectives(targetObj), null); parentCd.hydrate(object, null, new FakeDirectives(targetObj), null);