honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ivy): update token used for fakeAsync test (#28383) 

This commit updates the token used in fakeAsync test to the one available in both VE and R3 TestBeds. The goal of the test is to verify that fakeAsync works with inject function, so the actual token that is used for a test is irrelevant in that case. The logic to retrieve tokens from compiler injector (that the comment in "fixmeIvy" refers to) was implemented in PR #28196.

PR Close #28383
This commit is contained in:
Andrew Kushnir 2019-01-25 16:00:50 -08:00 committed by Jason Aden
parent 778d5739e2
commit 495a9dd445
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/core/test/fake_async_spec.ts
View File

@ -8,11 +8,8 @@
import {discardPeriodicTasks, fakeAsync, flush, flushMicrotasks, tick} from '@angular/core/testing'; import {discardPeriodicTasks, fakeAsync, flush, flushMicrotasks, tick} from '@angular/core/testing';
import {Log, beforeEach, describe, inject, it} from '@angular/core/testing/src/testing_internal'; import {Log, beforeEach, describe, inject, it} from '@angular/core/testing/src/testing_internal';
import {EventManager} from '@angular/platform-browser';
import {expect} from '@angular/platform-browser/testing/src/matchers'; import {expect} from '@angular/platform-browser/testing/src/matchers';
import {fixmeIvy} from '@angular/private/testing';
import {Parser} from '../../compiler/src/expression_parser/parser';
const resolvedPromise = Promise.resolve(null); const resolvedPromise = Promise.resolve(null);
const ProxyZoneSpec: {assertPresent: () => void} = (Zone as any)['ProxyZoneSpec']; const ProxyZoneSpec: {assertPresent: () => void} = (Zone as any)['ProxyZoneSpec'];
@ -33,11 +30,10 @@ const ProxyZoneSpec: {assertPresent: () => void} = (Zone as any)['ProxyZoneSpec'
})('foo', 'bar'); })('foo', 'bar');
}); });
fixmeIvy('FW-806: Ivy\'s TestBed implementation doesn\'t inject compiler-related tokens') it('should work with inject()',
.it('should work with inject()', fakeAsync(inject([EventManager], (eventManager: EventManager) => {
fakeAsync(inject([Parser], (parser: any /** TODO #9100 */) => { expect(eventManager).toBeAnInstanceOf(EventManager);
expect(parser).toBeAnInstanceOf(Parser); })));
})));
it('should throw on nested calls', () => { it('should throw on nested calls', () => {
expect(() => { expect(() => {