From 49dcb06dcaf766f6ed30c163c715d84cccf61544 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Wed, 13 Jan 2021 13:58:52 -0800 Subject: [PATCH] build: remove pre-check script from publish scripts as it no longer performs its check (#40422) Previously the pre-check confirmed that the stamping value was normal and expected, however with the new stamping methodology of marking for publish via flag, the check no longer will ever see anything but a passing version, since it is stamped as publish. PR Close #40422 --- scripts/release/pre-check | 15 --------------- scripts/release/publish-latest | 4 ---- scripts/release/publish-next | 4 ---- 3 files changed, 23 deletions(-) delete mode 100755 scripts/release/pre-check diff --git a/scripts/release/pre-check b/scripts/release/pre-check deleted file mode 100755 index 82ebf99255..0000000000 --- a/scripts/release/pre-check +++ /dev/null @@ -1,15 +0,0 @@ -#!/usr/bin/env bash - -# Runs the Bazel workspace status command in order to ensure that the version placeholder -# will be replaced with the proper version name when building the release output. - -versionName=$(yarn -s ng-dev release build-env-stamp | grep -e "BUILD_SCM_VERSION" | cut -d " " -f2) - -if [[ ! ${versionName} =~ ^[0-9]+\.[0-9]+\.[0-9]+(-(rc|next).[0-9]+)?$ ]]; then - echo "ERROR: The release will currently have the following version: ${versionName}" - echo "This does not match the version format for releases to NPM." - echo "" - echo "Please ensure that the most recent commit in the current branch is tagged" - echo "with the proper version tag." - exit 1 -fi diff --git a/scripts/release/publish-latest b/scripts/release/publish-latest index 3e3bafd981..57b2d34273 100755 --- a/scripts/release/publish-latest +++ b/scripts/release/publish-latest @@ -2,10 +2,6 @@ set -u -e -o pipefail -# Runs the pre-check before performing the publish to ensure -# the version is valid for release. -sh "$(dirname "$0")/pre-check"; - # Use for production releases # Query Bazel for npm_package and ng_package rules with tags=["release-with-framework"] # Publish them to npm (tagged next) diff --git a/scripts/release/publish-next b/scripts/release/publish-next index 5a30b0db5d..5f49d1b79e 100755 --- a/scripts/release/publish-next +++ b/scripts/release/publish-next @@ -2,10 +2,6 @@ set -u -e -o pipefail -# Runs the pre-check before performing the publish to ensure -# the version is valid for release. -sh "$(dirname "$0")/pre-check"; - # Use for BETA and RC releases # Query Bazel for npm_package and ng_package rules with tags=["release-with-framework"] # Publish them to npm (tagged next)