honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(common): add URLSearchParams to request body (#37852)

Browse Source 
URLSearch params are by default supported in the browser but are not supported by angular/http package added support for URLSearchParams

Fixes #36317

PR Close #37852
This commit is contained in:
Ajit Singh 2020-06-30 21:35:30 +05:30 committed by Alex Rickabaugh
parent e1c5cea2e7
commit 4bc3cf216d
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/common/http/src/request.ts
View File

@ -68,6 +68,15 @@ function isFormData(value: any): value is FormData {
return typeof FormData !== 'undefined' && value instanceof FormData; return typeof FormData !== 'undefined' && value instanceof FormData;
} }
/**
* Safely assert whether the given value is a URLSearchParams instance.
*
* In some execution environments URLSearchParams is not defined.
*/
function isUrlSearchParams(value: any): value is URLSearchParams {
return typeof URLSearchParams !== 'undefined' && value instanceof URLSearchParams;
}
/** /**
* An outgoing HTTP request with an optional typed body. * An outgoing HTTP request with an optional typed body.
* *
@ -273,7 +282,7 @@ export class HttpRequest<T> {
// Check whether the body is already in a serialized form. If so, // Check whether the body is already in a serialized form. If so,
// it can just be returned directly. // it can just be returned directly.
if (isArrayBuffer(this.body) || isBlob(this.body) || isFormData(this.body) || if (isArrayBuffer(this.body) || isBlob(this.body) || isFormData(this.body) ||
typeof this.body === 'string') { isUrlSearchParams(this.body) || typeof this.body === 'string') {
return this.body; return this.body;
} }
// Check whether the body is an instance of HttpUrlEncodedParams. // Check whether the body is an instance of HttpUrlEncodedParams.

4
packages/common/http/test/request_spec.ts
View File

@ -143,6 +143,10 @@ const TEST_STRING = `I'm a body!`;
const body = new ArrayBuffer(4); const body = new ArrayBuffer(4);
expect(baseReq.clone({body}).serializeBody()).toBe(body); expect(baseReq.clone({body}).serializeBody()).toBe(body);
}); });
it('passes URLSearchParams through', () => {
const body = new URLSearchParams('foo=1&bar=2');
expect(baseReq.clone({body}).serializeBody()).toBe(body);
});
it('passes strings through', () => { it('passes strings through', () => {
const body = 'hello world'; const body = 'hello world';
expect(baseReq.clone({body}).serializeBody()).toBe(body); expect(baseReq.clone({body}).serializeBody()).toBe(body);