honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(router): opening links in new window 

Shift-clicks on router-links should not prevent browser default action.

A follow on to:
1ac9dda93d
This commit is contained in:
Robert Spier 2017-05-25 17:52:55 -07:00 committed by Alex Rickabaugh
parent 35f714e438
commit 4c32cb952f
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/router/src/directives/router_link.ts
View File

@ -209,9 +209,9 @@ export class RouterLinkWithHref implements OnChanges, OnDestroy {
ngOnChanges(changes: {}): any { this.updateTargetUrlAndHref(); } ngOnChanges(changes: {}): any { this.updateTargetUrlAndHref(); }
ngOnDestroy(): any { this.subscription.unsubscribe(); } ngOnDestroy(): any { this.subscription.unsubscribe(); }
@HostListener('click', ['$event.button', '$event.ctrlKey', '$event.metaKey']) @HostListener('click', ['$event.button', '$event.ctrlKey', '$event.metaKey', '$event.shiftKey'])
onClick(button: number, ctrlKey: boolean, metaKey: boolean): boolean { onClick(button: number, ctrlKey: boolean, metaKey: boolean, shiftKey: boolean): boolean {
if (button !== 0 || ctrlKey || metaKey) { if (button !== 0 || ctrlKey || metaKey || shiftKey) {
return true; return true;
} }

2
tools/public_api_guard/router/router.d.ts vendored
View File

@ -337,7 +337,7 @@ export declare class RouterLinkWithHref implements OnChanges, OnDestroy {
constructor(router: Router, route: ActivatedRoute, locationStrategy: LocationStrategy); constructor(router: Router, route: ActivatedRoute, locationStrategy: LocationStrategy);
ngOnChanges(changes: {}): any; ngOnChanges(changes: {}): any;
ngOnDestroy(): any; ngOnDestroy(): any;
onClick(button: number, ctrlKey: boolean, metaKey: boolean): boolean; onClick(button: number, ctrlKey: boolean, metaKey: boolean, shiftKey: boolean): boolean;
} }
/** @stable */ /** @stable */