honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci: re-enable payload size tracking (#31138)

Browse Source 
Payload size tracking was temporarily disabled in #31057, due to
`CIRCLE_COMPARE_URL` stopping being available. It turned out this was
related to turning on the new [Pipelines][1] feature, which was required
for testing Windows on CircleCI.

Since then, we have turned `Pipelines` off and got `CIRCLE_COMPARE_URL`
back (e.g. see [build 362971][2]). According to CircleCI, failing to
populate `CIRCLE_COMPARE_URL` with `Pipelines` on is a bug and they are
working on fixing it.

[1]: https://circleci.com/docs/2.0/build-processing/
[2]: https://circleci.com/gh/angular/angular/362971

Fixes #31121

PR Close #31138
This commit is contained in:
George Kalpakas 2019-06-19 19:05:54 +03:00 committed by Kara Erickson
parent c5d1e1a3da
commit 4c45aa39e4
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
scripts/ci/payload-size.sh
View File

@ -136,17 +136,15 @@ trackPayloadSize() {
# Save the file sizes to be retrieved from `payload-size.js`. # Save the file sizes to be retrieved from `payload-size.js`.
echo "$(payloadToJson)" > /tmp/current.log echo "$(payloadToJson)" > /tmp/current.log
# TODO: Temporarily disabled until we get back `CIRCLE_COMPARE_URL` or another way to get the
# commit range. Re-enable once the issue is resolved.
# If this is a non-PR build, upload the data to firebase. # If this is a non-PR build, upload the data to firebase.
# if [[ "$CI_PULL_REQUEST" == "false" ]]; then if [[ "$CI_PULL_REQUEST" == "false" ]]; then
# if [[ $trackChangeType = true ]]; then if [[ $trackChangeType = true ]]; then
# addChangeType $CI_COMMIT_RANGE addChangeType $CI_COMMIT_RANGE
# fi fi
# addTimestamp addTimestamp
# addMessage $CI_COMMIT_RANGE addMessage $CI_COMMIT_RANGE
# uploadData $name uploadData $name
# fi fi
# Check the file sizes against the specified limits. # Check the file sizes against the specified limits.
if [[ $checkSize = true ]]; then if [[ $checkSize = true ]]; then