From 4c7f89ff6d35f1ca639b54b7d08c26042dd9b8b7 Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Sat, 7 Mar 2020 16:23:11 +0000 Subject: [PATCH] ci: exclude ngcc directory from fw-compiler pull-approve rule (#35933) ngcc has its own pull-approve group PR Close #35933 --- .pullapprove.yml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index 6d79b06082..29637b8f9a 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -123,10 +123,10 @@ pullapprove_conditions: groups: # ========================================================= # Global Approvers - # + # # All reviews performed for global approvals require using # the `Reviewed-for:` specifier to set the approval - # specificity as documented at: + # specificity as documented at: # https://docs.pullapprove.com/reviewed-for/ # ========================================================= global-approvers: @@ -141,10 +141,10 @@ groups: # ========================================================= # Global Approvers For Docs - # + # # All reviews performed for global docs approvals require # using the `Reviewed-for:` specifier to set the approval - # specificity as documented at: + # specificity as documented at: # https://docs.pullapprove.com/reviewed-for/ # ========================================================= global-docs-approvers: @@ -198,6 +198,10 @@ groups: 'aio/content/guide/aot-metadata-errors.md', 'aio/content/guide/template-typecheck.md ' ]) + - > + not contains_any_globs(files, [ + 'packages/compiler-cli/ngcc/**' + ]) reviewers: users: - alxhub