honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "fix(router): process empty path segment when preceding a named outlet (#26243)" (#27516) 

This reverts commit 20cef5078d.

Breaks Pantheon see cl/224256517.

PR Close #27516
This commit is contained in:
Igor Minar 2018-12-06 08:27:20 -08:00
parent 6740d0de74
commit 4f61832d1c
2 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/router/src/recognize.ts
View File

@ -70,14 +70,6 @@ class Recognizer {
processSegmentGroup(config: Route[], segmentGroup: UrlSegmentGroup, outlet: string):
TreeNode<ActivatedRouteSnapshot>[] {
if (segmentGroup.segments.length === 0 && segmentGroup.hasChildren()) {
const empties = config.filter(r => emptyPathMatch(segmentGroup, segmentGroup.segments, r));
if (empties.length !== 0) {
try {
return this.processSegment(empties, segmentGroup, segmentGroup.segments, outlet);
} catch (e) {
if (!(e instanceof NoMatch)) throw e;
}
}
return this.processChildren(config, segmentGroup);
}

14
packages/router/test/recognize.spec.ts
View File

@ -263,20 +263,6 @@ describe('recognize', () => {
});
});
it('should work with children outlets', () => {
checkRecognize(
[{
path: '',
component: ComponentA,
children: [{path: 'b', outlet: 'b', component: ComponentB}]
}],
'(b:b)', (s: RouterStateSnapshot) => {
checkActivatedRoute((s as any).firstChild(s.root) !, '', {}, ComponentA);
checkActivatedRoute(
(s as any).firstChild((s as any).firstChild(s.root)) !, 'b', {}, ComponentB, 'b');
});
});
it('should match when terminal', () => {
checkRecognize(
[{path: '', pathMatch: 'full', component: ComponentA}], '',