From 50687e11cf1173475e9388b290a9bfb0a84c4d17 Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Mon, 10 Dec 2018 14:36:45 -0800 Subject: [PATCH] build: fix type-check errors introduced during rules_ts 0.21 (#27586) PR Close #27586 --- packages/bazel/src/schematics/ng-new/index.ts | 2 +- packages/benchpress/test/BUILD.bazel | 7 +++++++ .../bazel/injectable_def/app/test/BUILD.bazel | 1 + packages/compiler-cli/src/ngcc/test/BUILD.bazel | 1 + packages/compiler/test/css_parser/BUILD.bazel | 1 + packages/compiler/test/selector/BUILD.bazel | 3 +++ packages/service-worker/config/test/BUILD.bazel | 1 + 7 files changed, 15 insertions(+), 1 deletion(-) diff --git a/packages/bazel/src/schematics/ng-new/index.ts b/packages/bazel/src/schematics/ng-new/index.ts index 0f16b6e7ac..430cc451d3 100755 --- a/packages/bazel/src/schematics/ng-new/index.ts +++ b/packages/bazel/src/schematics/ng-new/index.ts @@ -8,7 +8,7 @@ * @fileoverview Schematics for ng-new project that builds with Bazel. */ -import {apply, applyTemplates, chain, externalSchematic, MergeStrategy, mergeWith, move, Rule, schematic, Tree, url, SchematicsException, UpdateRecorder,} from '@angular-devkit/schematics'; +import {SchematicContext, apply, applyTemplates, chain, externalSchematic, MergeStrategy, mergeWith, move, Rule, schematic, Tree, url, SchematicsException, UpdateRecorder,} from '@angular-devkit/schematics'; import {parseJsonAst, JsonAstObject, strings, JsonValue} from '@angular-devkit/core'; import {findPropertyInAstObject, insertPropertyInAstObjectInOrder} from '@schematics/angular/utility/json-utils'; import {validateProjectName} from '@schematics/angular/utility/validation'; diff --git a/packages/benchpress/test/BUILD.bazel b/packages/benchpress/test/BUILD.bazel index bf9fb6c395..9e6d8e46a1 100644 --- a/packages/benchpress/test/BUILD.bazel +++ b/packages/benchpress/test/BUILD.bazel @@ -4,6 +4,13 @@ ts_library( name = "test_lib", testonly = True, srcs = glob(["**/*.ts"]), + deps = [ + "//packages:types", + "//packages/benchpress", + "//packages/core", + "//packages/core/testing", + "@ngdeps//protractor", + ], ) jasmine_node_test( diff --git a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel index e8bec6db54..bf2ce1a645 100644 --- a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel +++ b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel @@ -18,6 +18,7 @@ ts_library( "//packages/core", "//packages/core/testing", "//packages/platform-server", + "//packages/private/testing", ], ) diff --git a/packages/compiler-cli/src/ngcc/test/BUILD.bazel b/packages/compiler-cli/src/ngcc/test/BUILD.bazel index 187153676a..826a437aed 100644 --- a/packages/compiler-cli/src/ngcc/test/BUILD.bazel +++ b/packages/compiler-cli/src/ngcc/test/BUILD.bazel @@ -11,6 +11,7 @@ ts_library( deps = [ "//packages/compiler-cli/src/ngcc", "//packages/compiler-cli/src/ngtsc/host", + "//packages/compiler-cli/src/ngtsc/metadata", "//packages/compiler-cli/src/ngtsc/testing", "//packages/compiler-cli/src/ngtsc/transform", "@ngdeps//@types/convert-source-map", diff --git a/packages/compiler/test/css_parser/BUILD.bazel b/packages/compiler/test/css_parser/BUILD.bazel index f81c8a0de2..e9764767e3 100644 --- a/packages/compiler/test/css_parser/BUILD.bazel +++ b/packages/compiler/test/css_parser/BUILD.bazel @@ -6,6 +6,7 @@ ts_library( srcs = glob(["**/*.ts"]), deps = [ "//packages:types", + "//packages/compiler", "//packages/compiler/testing", "//packages/core/testing", "//packages/platform-browser", diff --git a/packages/compiler/test/selector/BUILD.bazel b/packages/compiler/test/selector/BUILD.bazel index 5928f7d796..291e85ccc3 100644 --- a/packages/compiler/test/selector/BUILD.bazel +++ b/packages/compiler/test/selector/BUILD.bazel @@ -6,8 +6,11 @@ ts_library( srcs = glob(["**/*.ts"]), deps = [ "//packages:types", + "//packages/compiler", "//packages/compiler/testing", "//packages/core/testing", + "//packages/platform-browser", + "//packages/platform-browser/testing", ], ) diff --git a/packages/service-worker/config/test/BUILD.bazel b/packages/service-worker/config/test/BUILD.bazel index 7de207f086..f133a418b5 100644 --- a/packages/service-worker/config/test/BUILD.bazel +++ b/packages/service-worker/config/test/BUILD.bazel @@ -8,6 +8,7 @@ ts_library( ), deps = [ "//packages/service-worker/config", + "//packages/service-worker/config/testing", ], )