honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: update CLI integration tests to run only for Ivy ()

Browse Source 
In Angular CLI 12, application can only be compiled using Ivy, therefore we shouldn't run these tests when Bazel runs with View Engine context.

PR Close
This commit is contained in:
Alan Agius 2021-04-12 11:22:24 +02:00 committed by Zach Arend
parent 852b5e366e
commit 528e7d787c
3 changed files with 29 additions and 20 deletions
goldens/size-tracking
integration-payloads.json
integration
BUILD.bazel
ng_elements_schematics
test.ts

14
goldens/size-tracking/integration-payloads.json

@ -11,7 +11,7 @@
"cli-hello-world-ivy-minimal": {
"master": {
"uncompressed": {
"runtime-es2015": 1170,
"runtime-es2015": 1190,
"main-es2015": 17597,
"polyfills-es2015": 36709
}
@ -20,7 +20,7 @@
"cli-hello-world-ivy-compat": {
"master": {
"uncompressed": {
"runtime-es2015": 1170,
"runtime-es2015": 1190,
"main-es2015": 144579,
"polyfills-es2015": 36964
}
@ -29,7 +29,7 @@
"cli-hello-world-ivy-i18n": {
"master": {
"uncompressed": {
"runtime-es2015": 1170,
"runtime-es2015": 1190,
"main-es2015": 136546,
"polyfills-es2015": 37641
}
@ -38,17 +38,17 @@
"cli-hello-world-lazy": {
"master": {
"uncompressed": {
"runtime-es2015": 2285,
"main-es2015": 241389,
"runtime-es2015": 3354,
"main-es2015": 295076,
"polyfills-es2015": 36975,
"5-es2015": 753
"434-es2015": 796
}
}
},
"forms": {
"master": {
"uncompressed": {
"runtime-es2015": 1170,
"runtime-es2015": 1150,
"main-es2015": 162346,
"polyfills-es2015": 36975
}

33
integration/BUILD.bazel

@ -33,24 +33,33 @@ INTEGRATION_TESTS = {
"no-ivy-aot",
],
},
"cli-elements-universal": {},
"cli-hello-world": {"commands": "payload_size_tracking"},
"cli-hello-world-ivy-compat": {"commands": "payload_size_tracking"},
"cli-elements-universal": {
"tags": ["ivy-only"],
},
"cli-hello-world": {
"commands": "payload_size_tracking",
"tags": ["ivy-only"],
},
"cli-hello-world-ivy-compat": {
"commands": "payload_size_tracking",
"tags": ["ivy-only"],
},
"cli-hello-world-ivy-i18n": {
"commands": "payload_size_tracking",
# TODO: (FW-2165) cli-hello-world-ivy-i18n fails on a bundle size check with Ivy bundles
"tags": ["fixme-ivy-aot"],
"tags": ["ivy-only"],
},
"cli-hello-world-ivy-minimal": {
"commands": "payload_size_tracking",
"tags": ["ivy-only"],
},
"cli-hello-world-ivy-minimal": {"commands": "payload_size_tracking"},
"cli-hello-world-lazy": {
"commands": "payload_size_tracking",
# TODO: (FW-2165) cli-hello-world-lazy fails on a bundle size check with Ivy bundles
"tags": ["fixme-ivy-aot"],
"tags": ["ivy-only"],
},
"dynamic-compiler": {"tags": ["no-ivy-aot"]},
"forms": {
"commands": "payload_size_tracking",
"tags": ["no-ivy-aot"],
"tags": ["ivy-only"],
},
"hello_world__closure": {
# TODO: Re-enable the payload_size_tracking command:
@ -68,11 +77,11 @@ INTEGRATION_TESTS = {
},
"i18n": {"tags": ["no-ivy-aot"]},
"injectable-def": {"tags": ["no-ivy-aot"]},
"ivy-i18n": {"tags": ["no-ivy-aot"]},
"trusted-types": {},
"ivy-i18n": {"tags": ["ivy-only"]},
"trusted-types": {"tags": ["ivy-only"]},
"language_service_plugin": {},
"ng_elements": {"tags": ["no-ivy-aot"]},
"ng_elements_schematics": {"tags": ["no-ivy-aot"]},
"ng_elements_schematics": {"tags": ["ivy-only"]},
"ng_update": {},
"ng_update_migrations": {"tags": ["no-ivy-aot"]},
"ngcc": {"tags": ["no-ivy-aot"]},

2
integration/ng_elements_schematics/test.ts

@ -46,7 +46,7 @@ for (let p of nodePackages) {
}
// TODO(alan-agius4): remove once the main repo dependency on `@angular-devkut/build-angular` is `0.1200.0-next.9` or greater.
packages['@angular-devkit/build-angular'] = 'file:../../../node_modules/@angular-devkit/build-angular';
packages['@angular-devkit/build-angular'] = 'github:angular/angular-devkit-build-angular-builds#e0c1374b12cfc892844030431bc19f631c0086a5';
// Clean up previously run test
cd(__dirname);