honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs: document the `PR action: review` label in `TRIAGE_AND_LABELS.md` (#30171) 

PR Close #30171
This commit is contained in:
George Kalpakas 2019-05-18 00:20:47 +03:00 committed by Jason Aden
parent 8c00fced1c
commit 53a0b26348
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/TRIAGE_AND_LABELS.md
View File

@ -125,6 +125,9 @@ Every triaged PR must have a `PR action` label assigned to it:
* `PR action: discuss`: Discussion is needed, to be led by the author.
* _**Who adds it:** Typically the PR author._
* _**Who removes it:** Whoever added it._
* `PR action: review` (optional): One or more reviews are pending. The label is optional, since the review status can be derived from GitHub's Reviewers interface.
* _**Who adds it:** Any team member. The caretaker can use it to differentiate PRs pending review from merge-ready PRs._
* _**Who removes it:** Whoever added it or the reviewer adding the last missing review._
* `PR action: cleanup`: More work is needed from the author.
* _**Who adds it:** The reviewer requesting changes to the PR._
* _**Who removes it:** Either the author (after implementing the requested changes) or the reviewer (after confirming the requested changes have been implemented)._