honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(compiler): remove unreachable code (#40984) 

1. The error function throws, so no code after it is reachable.
2. Some switch statements are exhaustive, so no code after them are reachable.

PR Close #40984
This commit is contained in:
Andrew Scott 2021-02-24 10:06:39 -08:00 committed by Zach Arend
parent a31da48507
commit 54b088967a
6 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/compiler-cli/src/ngtsc/scope/src/dependency.ts
View File

@ -124,7 +124,6 @@ export class MetadataDtsModuleScopeResolver implements DtsModuleScopeResolver {
// The export was not a directive, a pipe, or a module. This is an error. // The export was not a directive, a pipe, or a module. This is an error.
// TODO(alxhub): produce a ts.Diagnostic // TODO(alxhub): produce a ts.Diagnostic
throw new Error(`Exported value ${exportRef.debugName} was not a directive, pipe, or module`);
} }
const exportScope: ExportScope = { const exportScope: ExportScope = {

1
packages/compiler-cli/src/transformers/node_emitter.ts
View File

@ -784,7 +784,6 @@ function modifierFromModifier(modifier: StmtModifier): ts.Modifier {
case StmtModifier.Static: case StmtModifier.Static:
return ts.createToken(ts.SyntaxKind.StaticKeyword); return ts.createToken(ts.SyntaxKind.StaticKeyword);
} }
return error(`unknown statement modifier`);
} }
function translateModifiers(modifiers: StmtModifier[]|null): ts.Modifier[]|undefined { function translateModifiers(modifiers: StmtModifier[]|null): ts.Modifier[]|undefined {

4
packages/compiler/src/constant_pool.ts
View File

@ -252,8 +252,6 @@ export class ConstantPool {
case DefinitionKind.Pipe: case DefinitionKind.Pipe:
return this.pipeDefinitions; return this.pipeDefinitions;
} }
error(`Unknown definition kind ${kind}`);
return this.componentDefinitions;
} }
public propertyNameOf(kind: DefinitionKind): string { public propertyNameOf(kind: DefinitionKind): string {
@ -267,8 +265,6 @@ export class ConstantPool {
case DefinitionKind.Pipe: case DefinitionKind.Pipe:
return 'ɵpipe'; return 'ɵpipe';
} }
error(`Unknown definition kind ${kind}`);
return '<unknown>';
} }
private freshName(): string { private freshName(): string {

1
packages/compiler/src/render3/view/compiler.ts
View File

@ -432,7 +432,6 @@ function selectorsFromGlobalMetadata(
} }
error('Unexpected query form'); error('Unexpected query form');
return o.NULL_EXPR;
} }
function prepareQueryParams(query: R3QueryMetadata, constantPool: ConstantPool): o.Expression[] { function prepareQueryParams(query: R3QueryMetadata, constantPool: ConstantPool): o.Expression[] {

2
packages/core/schematics/migrations/renderer-to-renderer2/helpers.ts
View File

@ -56,8 +56,6 @@ function getHelperDeclaration(name: HelperFunction): ts.Node {
case HelperFunction.splitNamespace: case HelperFunction.splitNamespace:
return getSplitNamespaceHelper(); return getSplitNamespaceHelper();
} }
throw new Error(`Unsupported helper called "${name}".`);
} }
/** Creates a helper for a custom `any` type during the migration. */ /** Creates a helper for a custom `any` type during the migration. */

1
packages/core/src/render3/instructions/lview_debug.ts
View File

@ -102,7 +102,6 @@ function getLViewToClone(type: TViewType, name: string|null): Array<any> {
} }
return embeddedArray; return embeddedArray;
} }
throw new Error('unreachable code');
} }
function nameSuffix(text: string|null|undefined): string { function nameSuffix(text: string|null|undefined): string {