ci: extend and update the reviewer groups (#37467)
Update the pullapprove config to require multiple reviews for sensitive groups in order to force distribution of knowledge and improve the review quality. PR Close #37467
This commit is contained in:
parent
17996bf719
commit
5568d824dd
|
@ -80,8 +80,8 @@
|
||||||
# Used for approving minor changes, large-scale refactorings, and in emergency situations.
|
# Used for approving minor changes, large-scale refactorings, and in emergency situations.
|
||||||
#
|
#
|
||||||
# IgorMinar
|
# IgorMinar
|
||||||
|
# jelbourn
|
||||||
# josephperrott
|
# josephperrott
|
||||||
# kara
|
|
||||||
# mhevery
|
# mhevery
|
||||||
#
|
#
|
||||||
# =========================================================
|
# =========================================================
|
||||||
|
@ -203,7 +203,6 @@ groups:
|
||||||
- alxhub
|
- alxhub
|
||||||
- AndrewKushnir
|
- AndrewKushnir
|
||||||
- JoostK
|
- JoostK
|
||||||
- kara
|
|
||||||
|
|
||||||
|
|
||||||
# =========================================================
|
# =========================================================
|
||||||
|
@ -235,7 +234,6 @@ groups:
|
||||||
- alxhub
|
- alxhub
|
||||||
- crisbeto
|
- crisbeto
|
||||||
- devversion
|
- devversion
|
||||||
- kara
|
|
||||||
|
|
||||||
|
|
||||||
# =========================================================
|
# =========================================================
|
||||||
|
@ -352,7 +350,7 @@ groups:
|
||||||
- alxhub
|
- alxhub
|
||||||
- AndrewKushnir
|
- AndrewKushnir
|
||||||
- atscott
|
- atscott
|
||||||
- kara
|
- ~kara # do not request reviews from Kara, but allow her to approve PRs
|
||||||
- mhevery
|
- mhevery
|
||||||
- pkozlowski-opensource
|
- pkozlowski-opensource
|
||||||
|
|
||||||
|
@ -579,7 +577,6 @@ groups:
|
||||||
users:
|
users:
|
||||||
- AndrewKushnir
|
- AndrewKushnir
|
||||||
- IgorMinar
|
- IgorMinar
|
||||||
- kara
|
|
||||||
- pkozlowski-opensource
|
- pkozlowski-opensource
|
||||||
|
|
||||||
|
|
||||||
|
@ -596,7 +593,6 @@ groups:
|
||||||
reviewers:
|
reviewers:
|
||||||
users:
|
users:
|
||||||
- IgorMinar
|
- IgorMinar
|
||||||
- kara
|
|
||||||
- pkozlowski-opensource
|
- pkozlowski-opensource
|
||||||
|
|
||||||
|
|
||||||
|
@ -613,7 +609,8 @@ groups:
|
||||||
reviewers:
|
reviewers:
|
||||||
users:
|
users:
|
||||||
- IgorMinar
|
- IgorMinar
|
||||||
- kara
|
- jelbourn
|
||||||
|
- pkozlowski-opensource
|
||||||
|
|
||||||
|
|
||||||
# =========================================================
|
# =========================================================
|
||||||
|
@ -637,6 +634,13 @@ groups:
|
||||||
users:
|
users:
|
||||||
- IgorMinar
|
- IgorMinar
|
||||||
- mhevery
|
- mhevery
|
||||||
|
- jelbourn
|
||||||
|
- pkozlowski-opensource
|
||||||
|
reviews:
|
||||||
|
request: -1 # request reviews from everyone
|
||||||
|
required: 2 # require at least 2 approvals
|
||||||
|
reviewed_for: required
|
||||||
|
|
||||||
|
|
||||||
# =========================================================
|
# =========================================================
|
||||||
# Bazel
|
# Bazel
|
||||||
|
@ -707,6 +711,7 @@ groups:
|
||||||
reviewers:
|
reviewers:
|
||||||
users:
|
users:
|
||||||
- alxhub
|
- alxhub
|
||||||
|
- josephperrott
|
||||||
|
|
||||||
|
|
||||||
# =========================================================
|
# =========================================================
|
||||||
|
@ -723,7 +728,6 @@ groups:
|
||||||
users:
|
users:
|
||||||
- IgorMinar
|
- IgorMinar
|
||||||
- josephperrott
|
- josephperrott
|
||||||
- kara
|
|
||||||
- mhevery
|
- mhevery
|
||||||
|
|
||||||
|
|
||||||
|
@ -836,7 +840,7 @@ groups:
|
||||||
reviewers:
|
reviewers:
|
||||||
users:
|
users:
|
||||||
- IgorMinar
|
- IgorMinar
|
||||||
- kara
|
- jelbourn
|
||||||
|
|
||||||
|
|
||||||
# =========================================================
|
# =========================================================
|
||||||
|
@ -1023,8 +1027,14 @@ groups:
|
||||||
])
|
])
|
||||||
reviewers:
|
reviewers:
|
||||||
users:
|
users:
|
||||||
|
- alxhub
|
||||||
- IgorMinar
|
- IgorMinar
|
||||||
- kara
|
- jelbourn
|
||||||
|
- pkozlowski-opensource
|
||||||
|
reviews:
|
||||||
|
request: -1 # request reviews from everyone
|
||||||
|
required: 3 # require at least 3 approvals
|
||||||
|
reviewed_for: required
|
||||||
|
|
||||||
|
|
||||||
# ================================================
|
# ================================================
|
||||||
|
@ -1039,8 +1049,14 @@ groups:
|
||||||
])
|
])
|
||||||
reviewers:
|
reviewers:
|
||||||
users:
|
users:
|
||||||
|
- alxhub
|
||||||
- IgorMinar
|
- IgorMinar
|
||||||
- kara
|
- jelbourn
|
||||||
|
- pkozlowski-opensource
|
||||||
|
reviews:
|
||||||
|
request: -1 # request reviews from everyone
|
||||||
|
required: 2 # require at least 2 approvals
|
||||||
|
reviewed_for: required
|
||||||
|
|
||||||
|
|
||||||
# ================================================
|
# ================================================
|
||||||
|
@ -1056,8 +1072,9 @@ groups:
|
||||||
reviewers:
|
reviewers:
|
||||||
users:
|
users:
|
||||||
- IgorMinar
|
- IgorMinar
|
||||||
|
- jelbourn
|
||||||
- josephperrott
|
- josephperrott
|
||||||
- kara
|
- pkozlowski-opensource
|
||||||
|
|
||||||
|
|
||||||
####################################################################################
|
####################################################################################
|
||||||
|
|
Loading…
Reference in New Issue