honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci: do not update shared dev-infra package in components-repo-unit-tests job (#42268)

Browse Source 
The shared dev-infra package from `HEAD` should not be installed
when running the `components-repo-unit-tests` job. This is done
because otherwise changes to the dev-infra package can result in
build setup issues for the CI job (while the goal of the CI job
is to test the framework)

PR Close #42268
This commit is contained in:
Paul Gschwendtner 2021-05-24 17:07:07 +02:00 committed by Jessica Janiuk
parent a16f82b851
commit 57865b352a
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.circleci/config.yml
View File

@ -737,8 +737,8 @@ jobs:
- run:
# Updates the `angular/components` `package.json` file to refer to the release output
# inside the `packages-dist` directory.
name: Setting up release packages.
command: node scripts/ci/update-deps-to-dist-packages.js ${COMPONENTS_REPO_TMP_DIR}/package.json dist/packages-dist/
name: Setting up framework release packages.
command: node scripts/ci/update-framework-deps-to-dist-packages.js ${COMPONENTS_REPO_TMP_DIR}/package.json dist/packages-dist/
- run:
# Run `yarn install` again to install the Angular packages from `packages-dist/` and update the lockfile.
# NOTE: We cannot rely on Bazel to run `yarn install`, because it uses the `--frozen-lockfile` flag and fails.

2
docs/DEBUG_COMPONENTS_REPO_IVY.md
View File

@ -13,7 +13,7 @@ the `angular/angular` repo.
command in the `angular/angular` repo:
```bash
node ./scripts/ci/update-deps-to-dist-packages.js {COMPONENTS_REPO}/package.json ./dist/packages-dist
node ./scripts/ci/update-framework-deps-to-dist-packages.js {COMPONENTS_REPO}/package.json ./dist/packages-dist
```
4\) Switch into the `angular/components` repository and run the tests by using the

5
scripts/ci/update-deps-to-dist-packages.js → scripts/ci/update-framework-deps-to-dist-packages.js
View File

@ -29,8 +29,9 @@ const updated = [];
const skipped = [];
function updateDeps(dependencies) {
for (const packageName of Object.keys(dependencies)) {
// We're only interested to update packages in the @angular scope
if (!packageName.startsWith('@angular/')) {
// We're only interested to update packages in the `@angular` scope. The shared dev-infra
// package is not updated as it's not a package that is part of the Angular framework.
if (!packageName.startsWith('@angular/') || packageName === '@angular/dev-infra-private') {
continue;
}