honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(zone.js): ensure compatibility with noImplicitOverride (#42512)

Browse Source 
Adds the `override` keyword to the `zone.js` sources to ensure
compatibility with `noImplicitOverride`.

PR Close #42512
This commit is contained in:
Paul Gschwendtner 2021-06-07 21:05:50 +02:00 committed by Andrew Kushnir
parent bfc4c3cf43
commit 5b5868d592
3 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
packages/zone.js/test/common/Error.spec.ts
View File

@ -19,22 +19,22 @@ class BaseError extends Error {
this._nativeError = nativeError; this._nativeError = nativeError;
} }
get message() { override get message() {
return this._nativeError.message; return this._nativeError.message;
} }
set message(message) { override set message(message) {
this._nativeError.message = message; this._nativeError.message = message;
} }
get name() { override get name() {
return this._nativeError.name; return this._nativeError.name;
} }
get stack() { override get stack() {
return (this._nativeError as any).stack; return (this._nativeError as any).stack;
} }
set stack(value) { override set stack(value) {
(this._nativeError as any).stack = value; (this._nativeError as any).stack = value;
} }
toString() { override toString() {
return this._nativeError.toString(); return this._nativeError.toString();
} }
} }
@ -47,7 +47,7 @@ class WrappedError extends BaseError {
this.originalError = error; this.originalError = error;
} }
get stack() { override get stack() {
return ((this.originalError instanceof Error ? this.originalError : this._nativeError) as any) return ((this.originalError instanceof Error ? this.originalError : this._nativeError) as any)
.stack; .stack;
} }
@ -58,7 +58,7 @@ class TestError extends WrappedError {
super(`${message} caused by: ${error instanceof Error ? error.message : error}`, error); super(`${message} caused by: ${error instanceof Error ? error.message : error}`, error);
} }
get message() { override get message() {
return 'test ' + this.originalError.message; return 'test ' + this.originalError.message;
} }
} }
@ -68,11 +68,11 @@ class TestMessageError extends WrappedError {
super(`${message} caused by: ${error instanceof Error ? error.message : error}`, error); super(`${message} caused by: ${error instanceof Error ? error.message : error}`, error);
} }
get message() { override get message() {
return 'test ' + this.originalError.message; return 'test ' + this.originalError.message;
} }
set message(value) { override set message(value) {
this.originalError.message = value; this.originalError.message = value;
} }
} }

2
packages/zone.js/test/common/Promise.spec.ts
View File

@ -122,7 +122,7 @@ describe(
super(fn); super(fn);
} }
static get[Symbol.species]() { static override get[Symbol.species]() {
return MyPromise; return MyPromise;
} }
} }

2
packages/zone.js/test/common/util.spec.ts
View File

@ -91,7 +91,7 @@ describe('utils', function() {
} }
} }
class ChildType extends Type { class ChildType extends Type {
method(..._args: any[]) { override method(..._args: any[]) {
childArgs = _args; childArgs = _args;
childSelf = this; childSelf = this;
return 'ChildOK'; return 'ChildOK';