From 5ba77f4f6a8a492cf2cc36080a70da3e9a31b710 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Sun, 18 Apr 2021 12:43:49 +0300 Subject: [PATCH] docs(dev-infra): fix typos in `dev-infra` docs/comments (#41688) PR Close #41688 --- dev-infra/browsers/README.md | 2 +- dev-infra/build-worker.js | 4 ++-- dev-infra/ng-dev.js | 4 ++-- dev-infra/utils/git/index.ts | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dev-infra/browsers/README.md b/dev-infra/browsers/README.md index 0ecb57c0ed..4c866fcbb6 100644 --- a/dev-infra/browsers/README.md +++ b/dev-infra/browsers/README.md @@ -51,7 +51,7 @@ The process of updating the Chrome or Firefox version is not straightforward, bu > The version of Chrome does not necessarily correspond exactly with the version of ChromeDriver. > For example, you might have to use ChromeDriver v87.0.4280.x to drive Chrome v87.0.4272.x. -3. Update `scripts/puppeteer-chromedriver-versions.js` to include and entry with the new version of puppeteer as key and the new version of ChromeDriver as value (as determined in the two previous steps). +3. Update `scripts/puppeteer-chromedriver-versions.js` to include an entry with the new version of puppeteer as key and the new version of ChromeDriver as value (as determined in the two previous steps). 4. Update all of the puppeteer versions throughout the repo: diff --git a/dev-infra/build-worker.js b/dev-infra/build-worker.js index 1ee07bfd30..84cb6bd41e 100644 --- a/dev-infra/build-worker.js +++ b/dev-infra/build-worker.js @@ -456,8 +456,8 @@ var GitClient = /** @class */ (function () { * for each new line. Git commands typically return multiple output values for a command a set of * strings separated by new lines. * - * Note: This is specifically created as a locally available function for usage as convience utility - * within `GitClient`'s methods to create outputs as array. + * Note: This is specifically created as a locally available function for usage as convenience + * utility within `GitClient`'s methods to create outputs as array. */ function gitOutputAsArray(gitCommandResult) { return gitCommandResult.stdout.split('\n').map(function (x) { return x.trim(); }).filter(function (x) { return !!x; }); diff --git a/dev-infra/ng-dev.js b/dev-infra/ng-dev.js index 9bc6e766b5..a6a8eb7ff6 100755 --- a/dev-infra/ng-dev.js +++ b/dev-infra/ng-dev.js @@ -622,8 +622,8 @@ var GitClient = /** @class */ (function () { * for each new line. Git commands typically return multiple output values for a command a set of * strings separated by new lines. * - * Note: This is specifically created as a locally available function for usage as convience utility - * within `GitClient`'s methods to create outputs as array. + * Note: This is specifically created as a locally available function for usage as convenience + * utility within `GitClient`'s methods to create outputs as array. */ function gitOutputAsArray(gitCommandResult) { return gitCommandResult.stdout.split('\n').map(function (x) { return x.trim(); }).filter(function (x) { return !!x; }); diff --git a/dev-infra/utils/git/index.ts b/dev-infra/utils/git/index.ts index d44c3afaed..f57561ecfd 100644 --- a/dev-infra/utils/git/index.ts +++ b/dev-infra/utils/git/index.ts @@ -354,8 +354,8 @@ export class GitClient { * for each new line. Git commands typically return multiple output values for a command a set of * strings separated by new lines. * - * Note: This is specifically created as a locally available function for usage as convience utility - * within `GitClient`'s methods to create outputs as array. + * Note: This is specifically created as a locally available function for usage as convenience + * utility within `GitClient`'s methods to create outputs as array. */ function gitOutputAsArray(gitCommandResult: SpawnSyncReturns): string[] { return gitCommandResult.stdout.split('\n').map(x => x.trim()).filter(x => !!x);