honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(record-range): fixes bug when disabling empty ranges.

This commit is contained in:
Rado Kirov 2014-12-03 11:59:50 -08:00
parent c59cc8631a
commit 5bdefee6c9
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
modules/change_detection/src/record_range.js
View File

@ -188,8 +188,11 @@ export class RecordRange {
var firstEnabledChildRecord = this.findFirstEnabledRecord();
var lastEnabledChildRecord = this.findLastEnabledRecord();
var nextEnabled = lastEnabledChildRecord.nextEnabled;
var prevEnabled = firstEnabledChildRecord.prevEnabled;
var nextEnabled = isPresent(lastEnabledChildRecord) ?
lastEnabledChildRecord.nextEnabled : null;
var prevEnabled = isPresent(firstEnabledChildRecord) ?
firstEnabledChildRecord.prevEnabled : null;
if (isPresent(nextEnabled)) nextEnabled.prevEnabled = prevEnabled;
if (isPresent(prevEnabled)) prevEnabled.nextEnabled = nextEnabled;

8
modules/change_detection/test/record_range_spec.js
View File

@ -107,6 +107,14 @@ export function main() {
expect(enabledRecords(parent, recordNames)).toEqual(['record1', 'record2']);
});
it('should handle enabling/disabling an empty range', () => {
var emptyRange = new RecordRange(null, null);
emptyRange.disable();
emptyRange.enable();
expect(enabledRecords(emptyRange, recordNames)).toEqual([]);
});
it('should handle adding a range into an empty range', () => {
var emptyRange = new RecordRange(null, null);
parent.addRange(emptyRange);