From 606e51881a20242abc1adf1922057a67c79843fc Mon Sep 17 00:00:00 2001 From: Victor Berchet Date: Wed, 12 Oct 2016 16:36:18 -0700 Subject: [PATCH] perf(benchmarks): update ng2-switch to match ng2 - use the ~same template layout (text nodes), - use trackBy both benchmark now show about the same perfs. --- modules/benchmarks/src/largetable/ng2/table.ts | 9 +++++++-- .../src/largetable/ng2_switch/table.ts | 16 ++++++++-------- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/modules/benchmarks/src/largetable/ng2/table.ts b/modules/benchmarks/src/largetable/ng2/table.ts index dc3a07be0a..53ecbcd1d5 100644 --- a/modules/benchmarks/src/largetable/ng2/table.ts +++ b/modules/benchmarks/src/largetable/ng2/table.ts @@ -5,8 +5,13 @@ import {TableCell, emptyTable} from '../util'; @Component({ selector: 'largetable', - template: - `
{{cell.value}}
` + template: ` + + + +
+ {{cell.value}} +
`, }) export class TableComponent { @Input() diff --git a/modules/benchmarks/src/largetable/ng2_switch/table.ts b/modules/benchmarks/src/largetable/ng2_switch/table.ts index 0ab2f7df6e..bcb307076a 100644 --- a/modules/benchmarks/src/largetable/ng2_switch/table.ts +++ b/modules/benchmarks/src/largetable/ng2_switch/table.ts @@ -6,18 +6,18 @@ import {TableCell, emptyTable} from '../util'; @Component({ selector: 'largetable', template: ` - - -
` + + + + ` }) export class TableComponent { @Input() data: TableCell[][] = emptyTable; + + trackByIndex(index: number, item: any) { return index; } } @NgModule({imports: [BrowserModule], bootstrap: [TableComponent], declarations: [TableComponent]})