From 626e1cda5f5793a2f7dfe40d50272579e0eee593 Mon Sep 17 00:00:00 2001 From: Peter Bacon Darwin Date: Wed, 16 Sep 2015 23:01:47 +0100 Subject: [PATCH] chore(doc-gen): fix blank line trimming for Jade docs Closes #4217 --- .../rendering/trimBlankLines.js | 4 ++-- .../rendering/trimBlankLines.spec.js | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 docs/angular.io-package/rendering/trimBlankLines.spec.js diff --git a/docs/angular.io-package/rendering/trimBlankLines.js b/docs/angular.io-package/rendering/trimBlankLines.js index 82728d7635..510c7617ac 100644 --- a/docs/angular.io-package/rendering/trimBlankLines.js +++ b/docs/angular.io-package/rendering/trimBlankLines.js @@ -1,9 +1,9 @@ -module.exports = function(encodeCodeBlock) { +module.exports = function() { return { name: 'trimBlankLines', process: function(str) { var lines = str.split(/\r?\n/); - while(lines[0] === '') { + while(lines.length && (lines[0].trim() === '')) { lines.shift(); } return lines.join('\n'); diff --git a/docs/angular.io-package/rendering/trimBlankLines.spec.js b/docs/angular.io-package/rendering/trimBlankLines.spec.js new file mode 100644 index 0000000000..762fc9fd2e --- /dev/null +++ b/docs/angular.io-package/rendering/trimBlankLines.spec.js @@ -0,0 +1,18 @@ +var factory = require('./trimBlankLines'); + +describe('trimBlankLines filter', function() { + var filter; + + beforeEach(function() { + filter = factory(); + }); + + it('should be called "trimBlankLines"', function() { + expect(filter.name).toEqual('trimBlankLines'); + }); + + it('should remove all empty lines from the start of the string', function() { + expect(filter.process('\n\n\nsome text\n\nmore text\n\n')) + .toEqual('some text\n\nmore text\n\n'); + }); +}); \ No newline at end of file