honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(forms): disabled input acceptance member not properly applied (#34502) 

With 5cecd97493 we intended to expand
the input type of the `disabled` input of the `NgModel` directive.
Read more about the reason for this in the actual commit message.

Currently though, the acceptance coercion member does not have any
effect. This is because the acceptance member needs to refer to the
actual input property name, and not to the public input name.
`disabled` corresponds to the `isDisabled` property.

PR Close #34502
This commit is contained in:
Paul Gschwendtner 2019-12-19 23:34:36 +01:00 committed by atscott
parent c3f14bb7a5
commit 6315acae94
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/forms/src/directives/ng_model.ts
View File

@ -144,7 +144,7 @@ export class NgModel extends NgControl implements OnChanges,
// This static member tells the compiler that values of type "string" can also be assigned
// to the input in a template.
/** @nodoc */
static ngAcceptInputType_disabled: boolean|string;
static ngAcceptInputType_isDisabled: boolean|string;
/** @internal */
_registered = false;

2
tools/public_api_guard/forms/forms.d.ts vendored
View File

@ -415,7 +415,7 @@ export declare class NgModel extends NgControl implements OnChanges, OnDestroy {
ngOnChanges(changes: SimpleChanges): void;
ngOnDestroy(): void;
viewToModelUpdate(newValue: any): void;
static ngAcceptInputType_disabled: boolean | string;
static ngAcceptInputType_isDisabled: boolean | string;
}
export declare class NgModelGroup extends AbstractFormGroupDirective implements OnInit, OnDestroy {