From 65775a36d72a7c47a87c27b585d45a5f2db25b37 Mon Sep 17 00:00:00 2001 From: Ben Lesh Date: Tue, 27 Nov 2018 17:40:05 -0800 Subject: [PATCH] refactor(ivy): add fixmeIvy blocks to ivy failing tests (#27311) PR Close #27311 --- packages/platform-webworker/test/BUILD.bazel | 5 +- .../worker/renderer_v2_integration_spec.ts | 77 ++++++++++--------- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a/packages/platform-webworker/test/BUILD.bazel b/packages/platform-webworker/test/BUILD.bazel index 826bf30e21..0844a10223 100644 --- a/packages/platform-webworker/test/BUILD.bazel +++ b/packages/platform-webworker/test/BUILD.bazel @@ -14,13 +14,13 @@ ts_library( "//packages/platform-browser-dynamic/testing", "//packages/platform-browser/testing", "//packages/platform-webworker", + "//packages/private/testing", ], ) jasmine_node_test( name = "test", bootstrap = ["angular/tools/testing/init_node_spec.js"], - tags = ["fixme-ivy-aot"], deps = [ ":test_lib", "//tools/testing:node", @@ -29,9 +29,6 @@ jasmine_node_test( ts_web_test_suite( name = "test_web", - tags = [ - "fixme-ivy-aot", - ], deps = [ ":test_lib", ], diff --git a/packages/platform-webworker/test/web_workers/worker/renderer_v2_integration_spec.ts b/packages/platform-webworker/test/web_workers/worker/renderer_v2_integration_spec.ts index 786c55a787..54460a63e7 100644 --- a/packages/platform-webworker/test/web_workers/worker/renderer_v2_integration_spec.ts +++ b/packages/platform-webworker/test/web_workers/worker/renderer_v2_integration_spec.ts @@ -14,13 +14,14 @@ import {DomRendererFactory2} from '@angular/platform-browser/src/dom/dom_rendere import {BrowserTestingModule} from '@angular/platform-browser/testing'; import {browserDetection, dispatchEvent} from '@angular/platform-browser/testing/src/browser_util'; import {expect} from '@angular/platform-browser/testing/src/matchers'; - import {ClientMessageBrokerFactory} from '@angular/platform-webworker/src/web_workers/shared/client_message_broker'; import {RenderStore} from '@angular/platform-webworker/src/web_workers/shared/render_store'; import {Serializer} from '@angular/platform-webworker/src/web_workers/shared/serializer'; import {ServiceMessageBrokerFactory} from '@angular/platform-webworker/src/web_workers/shared/service_message_broker'; import {MessageBasedRenderer2} from '@angular/platform-webworker/src/web_workers/ui/renderer'; import {WebWorkerRendererFactory2} from '@angular/platform-webworker/src/web_workers/worker/renderer'; +import {fixmeIvy} from '@angular/private/testing'; + import {PairedMessageBuses, createPairedMessageBuses} from '../shared/web_worker_test_util'; let lastCreatedRenderer: Renderer2; @@ -94,50 +95,52 @@ let lastCreatedRenderer: Renderer2; expect(renderEl).toHaveText('Hello World!'); }); - it('should update any element property/attributes/class/style(s) independent of the compilation on the root element and other elements', - () => { - const fixture = - TestBed.overrideTemplate(MyComp2, '') - .createComponent(MyComp2); + fixmeIvy('#FW-750 - fixture.debugElement is null') && + it('should update any element property/attributes/class/style(s) independent of the compilation on the root element and other elements', + () => { + const fixture = + TestBed.overrideTemplate(MyComp2, '') + .createComponent(MyComp2); - const checkSetters = (componentRef: ComponentRef, workerEl: any) => { - expect(lastCreatedRenderer).not.toBeNull(); + const checkSetters = (componentRef: ComponentRef, workerEl: any) => { + expect(lastCreatedRenderer).not.toBeNull(); - const el = getRenderElement(workerEl); - lastCreatedRenderer.setProperty(workerEl, 'tabIndex', 1); - expect(el.tabIndex).toEqual(1); + const el = getRenderElement(workerEl); + lastCreatedRenderer.setProperty(workerEl, 'tabIndex', 1); + expect(el.tabIndex).toEqual(1); - lastCreatedRenderer.addClass(workerEl, 'a'); - expect(getDOM().hasClass(el, 'a')).toBe(true); + lastCreatedRenderer.addClass(workerEl, 'a'); + expect(getDOM().hasClass(el, 'a')).toBe(true); - lastCreatedRenderer.removeClass(workerEl, 'a'); - expect(getDOM().hasClass(el, 'a')).toBe(false); + lastCreatedRenderer.removeClass(workerEl, 'a'); + expect(getDOM().hasClass(el, 'a')).toBe(false); - lastCreatedRenderer.setStyle(workerEl, 'width', '10px'); - expect(getDOM().getStyle(el, 'width')).toEqual('10px'); + lastCreatedRenderer.setStyle(workerEl, 'width', '10px'); + expect(getDOM().getStyle(el, 'width')).toEqual('10px'); - lastCreatedRenderer.removeStyle(workerEl, 'width'); - expect(getDOM().getStyle(el, 'width')).toEqual(''); + lastCreatedRenderer.removeStyle(workerEl, 'width'); + expect(getDOM().getStyle(el, 'width')).toEqual(''); - lastCreatedRenderer.setAttribute(workerEl, 'someattr', 'someValue'); - expect(getDOM().getAttribute(el, 'someattr')).toEqual('someValue'); - }; + lastCreatedRenderer.setAttribute(workerEl, 'someattr', 'someValue'); + expect(getDOM().getAttribute(el, 'someattr')).toEqual('someValue'); + }; - // root element - checkSetters(fixture.componentRef, fixture.nativeElement); - // nested elements - checkSetters(fixture.componentRef, fixture.debugElement.children[0].nativeElement); - }); + // root element + checkSetters(fixture.componentRef, fixture.nativeElement); + // nested elements + checkSetters(fixture.componentRef, fixture.debugElement.children[0].nativeElement); + }); - it('should update any template comment property/attributes', () => { - const fixture = - TestBed.overrideTemplate(MyComp2, '') - .createComponent(MyComp2); - fixture.componentInstance.ctxBoolProp = true; - fixture.detectChanges(); - const el = getRenderElement(fixture.nativeElement); - expect(getDOM().getInnerHTML(el)).toContain('"ng-reflect-ng-if": "true"'); - }); + fixmeIvy('#FW-664 ng-reflect-* is not supported') && + it('should update any template comment property/attributes', () => { + const fixture = + TestBed.overrideTemplate(MyComp2, '') + .createComponent(MyComp2); + fixture.componentInstance.ctxBoolProp = true; + fixture.detectChanges(); + const el = getRenderElement(fixture.nativeElement); + expect(getDOM().getInnerHTML(el)).toContain('"ng-reflect-ng-if": "true"'); + }); it('should add and remove fragments', () => { const fixture = @@ -158,7 +161,7 @@ let lastCreatedRenderer: Renderer2; }); if (getDOM().supportsDOMEvents()) { - it('should listen to events', () => { + fixmeIvy('#FW-750 - fixture.debugElement is null') && it('should listen to events', () => { const fixture = TestBed.overrideTemplate(MyComp2, '') .createComponent(MyComp2);