honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build: create google3 migration tests bazel target (#31817) 

Creates a separate bazel target for the google3 migration
tests. The benefit is that it's faster to run tests for
public migrations in development. Google3 lint rules are
usually another story/implementation and the tests are quite
slow due to how TSLint applies replacements.

Additionally if something changes in the google3 tslint rules,
the tests which aren't affected re-run unnecessarily.

PR Close #31817
This commit is contained in:
Paul Gschwendtner 2019-07-24 10:03:51 +02:00 committed by Kara Erickson
parent 695f322dc1
commit 684579b338
4 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/schematics/migrations/google3/BUILD.bazel
View File

@ -4,7 +4,7 @@ ts_library(
name = "google3",
srcs = glob(["**/*.ts"]),
tsconfig = "//packages/core/schematics:tsconfig.json",
visibility = ["//packages/core/schematics/test:__pkg__"],
visibility = ["//packages/core/schematics/test/google3:__pkg__"],
deps = [
"//packages/core/schematics/migrations/injectable-pipe",
"//packages/core/schematics/migrations/missing-injectable",

2
packages/core/schematics/migrations/renderer-to-renderer2/google3/BUILD.bazel
View File

@ -4,7 +4,7 @@ ts_library(
name = "google3",
srcs = glob(["**/*.ts"]),
tsconfig = "//packages/core/schematics:tsconfig.json",
visibility = ["//packages/core/schematics/test:__pkg__"],
visibility = ["//packages/core/schematics/test/google3:__pkg__"],
deps = [
"//packages/core/schematics/migrations/renderer-to-renderer2",
"@npm//tslint",

4
packages/core/schematics/test/BUILD.bazel
View File

@ -9,12 +9,10 @@ ts_library(
"//packages/core/schematics:migrations.json",
],
deps = [
"//packages/core/schematics/migrations/google3",
"//packages/core/schematics/migrations/injectable-pipe",
"//packages/core/schematics/migrations/missing-injectable",
"//packages/core/schematics/migrations/move-document",
"//packages/core/schematics/migrations/renderer-to-renderer2",
"//packages/core/schematics/migrations/renderer-to-renderer2/google3",
"//packages/core/schematics/migrations/static-queries",
"//packages/core/schematics/migrations/template-var-assignment",
"//packages/core/schematics/utils",
@ -26,7 +24,7 @@ ts_library(
)
jasmine_node_test(
name = "test",
name = "google3",
deps = [
":test_lib",
"@npm//shelljs",

21
packages/core/schematics/test/google3/BUILD.bazel Normal file
View File

@ -0,0 +1,21 @@
load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
ts_library(
name = "test_lib",
testonly = True,
srcs = glob(["**/*.ts"]),
deps = [
"//packages/core/schematics/migrations/google3",
"//packages/core/schematics/migrations/renderer-to-renderer2/google3",
"@npm//@types/shelljs",
"@npm//tslint",
],
)
jasmine_node_test(
name = "test",
deps = [
":test_lib",
"@npm//shelljs",
],
)