fix(ivy): make metadata calls side-effect free in Closure (#29947)

When compiling Angular classes, the compiler may decide to append statements with specific metadata that's only required for JIT. This includes things like decorator metadata as well as NgModule scope data.

When the compiler generates such calls, the call sites are marked with Uglify's PURE annotation, so the optimizer will remove them in production builds. However, Closure does not have the PURE (or similar) annotation. We have a utility function `noSideEffects` in the runtime for this purpose. This commit wraps `setClassMetadata` and `setNgModuleScope` function bodies in `noSideEffect` closures to allow Closure remove them.

PR Close #29947

packages/core/src/render3/definition.ts

@@ -402,10 +402,12 @@ export function ɵɵsetNgModuleScope(type: any, scope: {
    */
   exports?: Type<any>[] | (() => Type<any>[]);
 }): void {
+  return noSideEffects(() => {
     const ngModuleDef = getNgModuleDef(type, true);
     ngModuleDef.declarations = scope.declarations || EMPTY_ARRAY;
     ngModuleDef.imports = scope.imports || EMPTY_ARRAY;
     ngModuleDef.exports = scope.exports || EMPTY_ARRAY;
+  }) as never;
 }
 
 /**

packages/core/src/render3/metadata.ts

@@ -7,6 +7,7 @@
  */
 
 import {Type} from '../interface/type';
+import {noSideEffects} from '../util/closure';
 
 interface TypeWithMetadata extends Type<any> {
   decorators?: any[];
@@ -26,6 +27,7 @@ interface TypeWithMetadata extends Type<any> {
 export function setClassMetadata(
     type: Type<any>, decorators: any[] | null, ctorParameters: (() => any[]) | null,
     propDecorators: {[field: string]: any} | null): void {
+  return noSideEffects(() => {
     const clazz = type as TypeWithMetadata;
 
     // We determine whether a class has its own metadata by taking the metadata from the parent
@@ -61,4 +63,5 @@ export function setClassMetadata(
         clazz.propDecorators = propDecorators;
       }
     }
+  }) as never;
 }