test(compiler-cli): add additional safe keyed read tests (#42421)

This commit adds some tests that were mistakenly omitted from the original
change for safe keyed reads/writes.

PR Close #42421

packages/compiler-cli/src/ngtsc/typecheck/test/span_comments_spec.ts

@@ -129,6 +129,13 @@ describe('type check blocks diagnostics', () => {
               '(null as any ? (((ctx).a /*3,4*/) /*3,4*/)!.method /*6,12*/(((ctx).b /*13,14*/) /*13,14*/) : undefined) /*3,15*/');
     });
 
+    it('should annotate safe keyed reads', () => {
+      const TEMPLATE = `{{ a?.[0] }}`;
+      expect(tcbWithSpans(TEMPLATE))
+          .toContain(
+              '(null as any ? (((ctx).a /*3,4*/) /*3,4*/)![0 /*7,8*/] /*3,9*/ : undefined) /*3,9*/');
+    });
+
     it('should annotate $any casts', () => {
       const TEMPLATE = `{{ $any(a) }}`;
       expect(tcbWithSpans(TEMPLATE)).toContain('(((ctx).a /*8,9*/) /*8,9*/ as any) /*3,10*/');

packages/compiler-cli/src/ngtsc/typecheck/test/type_checker__get_symbol_of_template_node_spec.ts

@@ -394,6 +394,7 @@ runInEachFileSystem(() => {
         <div [inputA]="person?.address?.street"></div>
         <div [inputA]="person ? person.address : noPersonError"></div>
         <div [inputA]="person?.speak()"></div>
+        <div [inputA]="person?.cars?.[1].engine"></div>
       `;
           const testValues = setup(
               [
@@ -405,9 +406,14 @@ runInEachFileSystem(() => {
                 street: string;
               }
 
+              interface Car {
+                engine: string;
+              }
+
               interface Person {
                 address: Address;
                 speak(): string;
+                cars?: Car[];
               }
               export class Cmp {person?: Person; noPersonError = 'no person'}
             `,
@@ -448,6 +454,19 @@ runInEachFileSystem(() => {
               .toEqual('string | undefined');
         });
 
+        it('safe keyed reads', () => {
+          const nodes = getAstElements(templateTypeChecker, cmp);
+          const safeKeyedRead = nodes[3].inputs[0].value as ASTWithSource;
+          const keyedReadSymbol = templateTypeChecker.getSymbolOfNode(safeKeyedRead, cmp)!;
+          assertExpressionSymbol(keyedReadSymbol);
+          expect(program.getTypeChecker().symbolToString(keyedReadSymbol.tsSymbol!))
+              .toEqual('engine');
+          expect((keyedReadSymbol.tsSymbol!.declarations![0] as ts.PropertyDeclaration)
+                     .parent.name!.getText())
+              .toEqual('Car');
+          expect(program.getTypeChecker().typeToString(keyedReadSymbol.tsType)).toEqual('string');
+        });
+
         it('ternary expressions', () => {
           const nodes = getAstElements(templateTypeChecker, cmp);
 

packages/language-service/ivy/test/quick_info_spec.ts

@@ -357,6 +357,20 @@ describe('quick info', () => {
           expectedDisplayString: '(variable) name: { readonly name: "name"; }'
         });
       });
+
+      it('should work for safe keyed reads', () => {
+        expectQuickInfo({
+          templateOverride: `<div>{{constNames?.[0¦]}}</div>`,
+          expectedSpanText: '0',
+          expectedDisplayString: '(property) 0: {\n    readonly name: "name";\n}'
+        });
+
+        expectQuickInfo({
+          templateOverride: `<div>{{constNames?.[0]?.na¦me}}</div>`,
+          expectedSpanText: 'constNames?.[0]?.name',
+          expectedDisplayString: '(property) name: "name"'
+        });
+      });
     });
 
     describe('pipes', () => {