diff --git a/packages/compiler-cli/ngcc/src/analysis/util.ts b/packages/compiler-cli/ngcc/src/analysis/util.ts index 07f69a2c66..dfe2b6188b 100644 --- a/packages/compiler-cli/ngcc/src/analysis/util.ts +++ b/packages/compiler-cli/ngcc/src/analysis/util.ts @@ -5,12 +5,12 @@ * Use of this source code is governed by an MIT-style license that can be * found in the LICENSE file at https://angular.io/license */ -import {AbsoluteFsPath, relative} from '../../../src/ngtsc/file_system'; +import {AbsoluteFsPath, isLocalRelativePath, relative} from '../../../src/ngtsc/file_system'; import {DependencyTracker} from '../../../src/ngtsc/incremental/api'; export function isWithinPackage(packagePath: AbsoluteFsPath, filePath: AbsoluteFsPath): boolean { const relativePath = relative(packagePath, filePath); - return !relativePath.startsWith('..') && !relativePath.startsWith('node_modules/'); + return isLocalRelativePath(relativePath) && !relativePath.startsWith('node_modules/'); } class NoopDependencyTracker implements DependencyTracker { diff --git a/packages/compiler-cli/ngcc/src/entry_point_finder/targeted_entry_point_finder.ts b/packages/compiler-cli/ngcc/src/entry_point_finder/targeted_entry_point_finder.ts index d39f65d78c..7b24af8835 100644 --- a/packages/compiler-cli/ngcc/src/entry_point_finder/targeted_entry_point_finder.ts +++ b/packages/compiler-cli/ngcc/src/entry_point_finder/targeted_entry_point_finder.ts @@ -228,11 +228,13 @@ export class TargetedEntryPointFinder extends TracingEntryPointFinder { /** * Split the given `path` into path segments using an FS independent algorithm. */ - private splitPath(path: PathSegment) { + private splitPath(path: PathSegment|AbsoluteFsPath) { const segments = []; - while (path !== '.') { + let container = this.fs.dirname(path); + while (path !== container) { segments.unshift(this.fs.basename(path)); - path = this.fs.dirname(path); + path = container; + container = this.fs.dirname(container); } return segments; } diff --git a/packages/compiler-cli/ngcc/src/rendering/esm_rendering_formatter.ts b/packages/compiler-cli/ngcc/src/rendering/esm_rendering_formatter.ts index 94210bbb74..5f113661fb 100644 --- a/packages/compiler-cli/ngcc/src/rendering/esm_rendering_formatter.ts +++ b/packages/compiler-cli/ngcc/src/rendering/esm_rendering_formatter.ts @@ -9,7 +9,7 @@ import {Statement} from '@angular/compiler'; import MagicString from 'magic-string'; import * as ts from 'typescript'; -import {absoluteFromSourceFile, AbsoluteFsPath, dirname, relative} from '../../../src/ngtsc/file_system'; +import {absoluteFromSourceFile, AbsoluteFsPath, dirname, relative, toRelativeImport} from '../../../src/ngtsc/file_system'; import {NOOP_DEFAULT_IMPORT_RECORDER, Reexport} from '../../../src/ngtsc/imports'; import {Import, ImportManager, translateStatement} from '../../../src/ngtsc/translator'; import {isDtsPath} from '../../../src/ngtsc/util/src/typescript'; @@ -57,8 +57,9 @@ export class EsmRenderingFormatter implements RenderingFormatter { if (from) { const basePath = stripExtension(from); - const relativePath = './' + relative(dirname(entryPointBasePath), basePath); - exportFrom = entryPointBasePath !== basePath ? ` from '${relativePath}'` : ''; + const relativePath = relative(dirname(entryPointBasePath), basePath); + const relativeImport = toRelativeImport(relativePath); + exportFrom = entryPointBasePath !== basePath ? ` from '${relativeImport}'` : ''; } const exportStr = `\nexport {${e.identifier}}${exportFrom};`; @@ -197,10 +198,10 @@ export class EsmRenderingFormatter implements RenderingFormatter { const ngModuleName = info.ngModule.node.name.text; const declarationFile = absoluteFromSourceFile(info.declaration.getSourceFile()); const ngModuleFile = absoluteFromSourceFile(info.ngModule.node.getSourceFile()); + const relativePath = relative(dirname(declarationFile), ngModuleFile); + const relativeImport = toRelativeImport(relativePath); const importPath = info.ngModule.ownedByModuleGuess || - (declarationFile !== ngModuleFile ? - stripExtension(`./${relative(dirname(declarationFile), ngModuleFile)}`) : - null); + (declarationFile !== ngModuleFile ? stripExtension(relativeImport) : null); const ngModule = generateImportString(importManager, importPath, ngModuleName); if (info.declaration.type) { diff --git a/packages/compiler-cli/ngcc/src/writing/new_entry_point_file_writer.ts b/packages/compiler-cli/ngcc/src/writing/new_entry_point_file_writer.ts index d2139e4914..a3931bf926 100644 --- a/packages/compiler-cli/ngcc/src/writing/new_entry_point_file_writer.ts +++ b/packages/compiler-cli/ngcc/src/writing/new_entry_point_file_writer.ts @@ -6,7 +6,7 @@ * Use of this source code is governed by an MIT-style license that can be * found in the LICENSE file at https://angular.io/license */ -import {absoluteFromSourceFile, AbsoluteFsPath, dirname, FileSystem, join, relative} from '../../../src/ngtsc/file_system'; +import {absoluteFromSourceFile, AbsoluteFsPath, dirname, FileSystem, isLocalRelativePath, join, relative, resolve} from '../../../src/ngtsc/file_system'; import {Logger} from '../../../src/ngtsc/logging'; import {isDtsPath} from '../../../src/ngtsc/util/src/typescript'; import {EntryPoint, EntryPointJsonProperty} from '../packages/entry_point'; @@ -70,9 +70,9 @@ export class NewEntryPointFileWriter extends InPlaceFileWriter { bundle: EntryPointBundle, packagePath: AbsoluteFsPath, ngccFolder: AbsoluteFsPath) { bundle.src.program.getSourceFiles().forEach(sourceFile => { const relativePath = relative(packagePath, absoluteFromSourceFile(sourceFile)); - const isOutsidePackage = relativePath.startsWith('..'); - if (!sourceFile.isDeclarationFile && !isOutsidePackage) { - const newFilePath = join(ngccFolder, relativePath); + const isInsidePackage = isLocalRelativePath(relativePath); + if (!sourceFile.isDeclarationFile && isInsidePackage) { + const newFilePath = resolve(ngccFolder, relativePath); this.fs.ensureDir(dirname(newFilePath)); this.fs.copyFile(absoluteFromSourceFile(sourceFile), newFilePath); } @@ -86,7 +86,7 @@ export class NewEntryPointFileWriter extends InPlaceFileWriter { super.writeFileAndBackup(file); } else { const relativePath = relative(packagePath, file.path); - const newFilePath = join(ngccFolder, relativePath); + const newFilePath = resolve(ngccFolder, relativePath); this.fs.ensureDir(dirname(newFilePath)); this.fs.writeFile(newFilePath, file.contents); } @@ -98,7 +98,7 @@ export class NewEntryPointFileWriter extends InPlaceFileWriter { super.revertFileAndBackup(filePath); } else if (this.fs.exists(filePath)) { const relativePath = relative(packagePath, filePath); - const newFilePath = join(packagePath, NGCC_DIRECTORY, relativePath); + const newFilePath = resolve(packagePath, NGCC_DIRECTORY, relativePath); this.fs.removeFile(newFilePath); } } @@ -117,8 +117,9 @@ export class NewEntryPointFileWriter extends InPlaceFileWriter { // All format properties point to the same format-path. const oldFormatProp = formatProperties[0]!; const oldFormatPath = packageJson[oldFormatProp]!; - const oldAbsFormatPath = join(entryPoint.path, oldFormatPath); - const newAbsFormatPath = join(ngccFolder, relative(entryPoint.packagePath, oldAbsFormatPath)); + const oldAbsFormatPath = resolve(entryPoint.path, oldFormatPath); + const newAbsFormatPath = + resolve(ngccFolder, relative(entryPoint.packagePath, oldAbsFormatPath)); const newFormatPath = relative(entryPoint.path, newAbsFormatPath); // Update all properties in `package.json` (both in memory and on disk). diff --git a/packages/compiler-cli/src/ngtsc/file_system/index.ts b/packages/compiler-cli/src/ngtsc/file_system/index.ts index 7adae11b53..218f99de4b 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/index.ts +++ b/packages/compiler-cli/src/ngtsc/file_system/index.ts @@ -6,7 +6,7 @@ * found in the LICENSE file at https://angular.io/license */ export {NgtscCompilerHost} from './src/compiler_host'; -export {absoluteFrom, absoluteFromSourceFile, basename, dirname, getFileSystem, isRoot, isRooted, join, relative, relativeFrom, resolve, setFileSystem} from './src/helpers'; +export {absoluteFrom, absoluteFromSourceFile, basename, dirname, getFileSystem, isLocalRelativePath, isRoot, isRooted, join, relative, relativeFrom, resolve, setFileSystem, toRelativeImport} from './src/helpers'; export {LogicalFileSystem, LogicalProjectPath} from './src/logical'; export {NodeJSFileSystem} from './src/node_js_file_system'; export {AbsoluteFsPath, FileStats, FileSystem, PathSegment, PathString} from './src/types'; diff --git a/packages/compiler-cli/src/ngtsc/file_system/src/helpers.ts b/packages/compiler-cli/src/ngtsc/file_system/src/helpers.ts index b7324cb61c..9e3476e64b 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/src/helpers.ts +++ b/packages/compiler-cli/src/ngtsc/file_system/src/helpers.ts @@ -83,7 +83,7 @@ export function isRooted(path: string): boolean { /** * Static access to `relative`. */ -export function relative(from: T, to: T): PathSegment { +export function relative(from: T, to: T): PathSegment|AbsoluteFsPath { return fs.relative(from, to); } @@ -93,3 +93,23 @@ export function relative(from: T, to: T): PathSegment { export function basename(filePath: PathString, extension?: string): PathSegment { return fs.basename(filePath, extension) as PathSegment; } + +/** + * Returns true if the given path is locally relative. + * + * This is used to work out if the given path is relative (i.e. not absolute) but also is not + * escaping the current directory. + */ +export function isLocalRelativePath(relativePath: string): boolean { + return !isRooted(relativePath) && !relativePath.startsWith('..'); +} + +/** + * Converts a path to a form suitable for use as a relative module import specifier. + * + * In other words it adds the `./` to the path if it is locally relative. + */ +export function toRelativeImport(relativePath: PathSegment|AbsoluteFsPath): PathSegment| + AbsoluteFsPath { + return isLocalRelativePath(relativePath) ? `./${relativePath}` as PathSegment : relativePath; +} diff --git a/packages/compiler-cli/src/ngtsc/file_system/src/invalid_file_system.ts b/packages/compiler-cli/src/ngtsc/file_system/src/invalid_file_system.ts index 314923e5fd..b55223efa8 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/src/invalid_file_system.ts +++ b/packages/compiler-cli/src/ngtsc/file_system/src/invalid_file_system.ts @@ -82,7 +82,7 @@ export class InvalidFileSystem implements FileSystem { isRooted(path: string): boolean { throw makeError(); } - relative(from: T, to: T): PathSegment { + relative(from: T, to: T): PathSegment|AbsoluteFsPath { throw makeError(); } basename(filePath: string, extension?: string): PathSegment { diff --git a/packages/compiler-cli/src/ngtsc/file_system/src/logical.ts b/packages/compiler-cli/src/ngtsc/file_system/src/logical.ts index 875828c21c..02076286e3 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/src/logical.ts +++ b/packages/compiler-cli/src/ngtsc/file_system/src/logical.ts @@ -7,7 +7,7 @@ */ import * as ts from 'typescript'; -import {absoluteFrom, dirname, relative, resolve} from './helpers'; +import {absoluteFrom, dirname, isLocalRelativePath, relative, resolve, toRelativeImport} from './helpers'; import {AbsoluteFsPath, BrandedPath, PathSegment} from './types'; import {stripExtension} from './util'; @@ -29,11 +29,8 @@ export const LogicalProjectPath = { * importing from `to`. */ relativePathBetween: function(from: LogicalProjectPath, to: LogicalProjectPath): PathSegment { - let relativePath = relative(dirname(resolve(from)), resolve(to)); - if (!relativePath.startsWith('../')) { - relativePath = ('./' + relativePath) as PathSegment; - } - return relativePath as PathSegment; + const relativePath = relative(dirname(resolve(from)), resolve(to)); + return toRelativeImport(relativePath) as PathSegment; }, }; @@ -122,5 +119,5 @@ export class LogicalFileSystem { * E.g. `foo/bar/zee` is within `foo/bar` but not within `foo/car`. */ function isWithinBasePath(base: AbsoluteFsPath, path: AbsoluteFsPath): boolean { - return !relative(base, path).startsWith('..'); + return isLocalRelativePath(relative(base, path)); } diff --git a/packages/compiler-cli/src/ngtsc/file_system/src/node_js_file_system.ts b/packages/compiler-cli/src/ngtsc/file_system/src/node_js_file_system.ts index 11ec62e01a..44ad46a16d 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/src/node_js_file_system.ts +++ b/packages/compiler-cli/src/ngtsc/file_system/src/node_js_file_system.ts @@ -9,7 +9,7 @@ import * as fs from 'fs'; import * as fsExtra from 'fs-extra'; import * as p from 'path'; -import {absoluteFrom, relativeFrom} from './helpers'; +import {absoluteFrom} from './helpers'; import {AbsoluteFsPath, FileStats, FileSystem, PathSegment, PathString} from './types'; /** @@ -93,8 +93,8 @@ export class NodeJSFileSystem implements FileSystem { isRooted(path: string): boolean { return p.isAbsolute(path); } - relative(from: T, to: T): PathSegment { - return relativeFrom(this.normalize(p.relative(from, to))); + relative(from: T, to: T): PathSegment|AbsoluteFsPath { + return this.normalize(p.relative(from, to)) as PathSegment | AbsoluteFsPath; } basename(filePath: string, extension?: string): PathSegment { return p.basename(filePath, extension) as PathSegment; diff --git a/packages/compiler-cli/src/ngtsc/file_system/src/types.ts b/packages/compiler-cli/src/ngtsc/file_system/src/types.ts index 63a96a706c..b232db828c 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/src/types.ts +++ b/packages/compiler-cli/src/ngtsc/file_system/src/types.ts @@ -57,7 +57,14 @@ export interface FileSystem { resolve(...paths: string[]): AbsoluteFsPath; dirname(file: T): T; join(basePath: T, ...paths: string[]): T; - relative(from: T, to: T): PathSegment; + /** + * Compute the relative path between `from` and `to`. + * + * In file-systems that can have multiple file trees the returned path may not actually be + * "relative" (i.e. `PathSegment`). For example, Windows can have multiple drives : + * `relative('c:/a/b', 'd:/a/c')` would be `d:/a/c'. + */ + relative(from: T, to: T): PathSegment|AbsoluteFsPath; basename(filePath: string, extension?: string): PathSegment; realpath(filePath: AbsoluteFsPath): AbsoluteFsPath; getDefaultLibLocation(): AbsoluteFsPath; diff --git a/packages/compiler-cli/src/ngtsc/file_system/src/util.ts b/packages/compiler-cli/src/ngtsc/file_system/src/util.ts index 3520a166d9..728bc93fbd 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/src/util.ts +++ b/packages/compiler-cli/src/ngtsc/file_system/src/util.ts @@ -6,7 +6,7 @@ * found in the LICENSE file at https://angular.io/license */ import * as ts from 'typescript'; -import {AbsoluteFsPath} from './types'; +import {AbsoluteFsPath, PathString} from './types'; const TS_DTS_JS_EXTENSION = /(?:\.d)?\.ts$|\.js$/; @@ -21,8 +21,8 @@ export function normalizeSeparators(path: string): string { /** * Remove a .ts, .d.ts, or .js extension from a file name. */ -export function stripExtension(path: string): string { - return path.replace(TS_DTS_JS_EXTENSION, ''); +export function stripExtension(path: T): T { + return path.replace(TS_DTS_JS_EXTENSION, '') as T; } export function getSourceFileOrError(program: ts.Program, fileName: AbsoluteFsPath): ts.SourceFile { diff --git a/packages/compiler-cli/src/ngtsc/file_system/test/node_js_file_system_spec.ts b/packages/compiler-cli/src/ngtsc/file_system/test/node_js_file_system_spec.ts index af2602ea59..ea87f7dc62 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/test/node_js_file_system_spec.ts +++ b/packages/compiler-cli/src/ngtsc/file_system/test/node_js_file_system_spec.ts @@ -7,6 +7,7 @@ */ import * as realFs from 'fs'; import * as fsExtra from 'fs-extra'; +import * as os from 'os'; import {absoluteFrom, dirname, relativeFrom, setFileSystem} from '../src/helpers'; import {NodeJSFileSystem} from '../src/node_js_file_system'; import {AbsoluteFsPath} from '../src/types'; @@ -245,4 +246,13 @@ describe('NodeJSFileSystem', () => { expect(fs.isCaseSensitive()).toEqual(isCaseSensitive); }); }); + + if (os.platform() === 'win32') { + // Only relevant on Windows + describe('relative', () => { + it('should handle Windows paths on different drives', () => { + expect(fs.relative('C:\\a\\b\\c', 'D:\\a\\b\\d')).toEqual(absoluteFrom('D:\\a\\b\\d')); + }); + }); + } }); diff --git a/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system.ts b/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system.ts index 922f3bb81d..5d4cc337ba 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system.ts +++ b/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system.ts @@ -214,7 +214,7 @@ export abstract class MockFileSystem implements FileSystem { abstract resolve(...paths: string[]): AbsoluteFsPath; abstract dirname(file: T): T; abstract join(basePath: T, ...paths: string[]): T; - abstract relative(from: T, to: T): PathSegment; + abstract relative(from: T, to: T): PathSegment|AbsoluteFsPath; abstract basename(filePath: string, extension?: string): PathSegment; abstract isRooted(path: string): boolean; abstract normalize(path: T): T; diff --git a/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system_native.ts b/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system_native.ts index ce8b28fd15..e856448a35 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system_native.ts +++ b/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system_native.ts @@ -30,7 +30,7 @@ export class MockFileSystemNative extends MockFileSystem { join(basePath: T, ...paths: string[]): T { return NodeJSFileSystem.prototype.join.call(this, basePath, ...paths) as T; } - relative(from: T, to: T): PathSegment { + relative(from: T, to: T): PathSegment|AbsoluteFsPath { return NodeJSFileSystem.prototype.relative.call(this, from, to); } diff --git a/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system_posix.ts b/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system_posix.ts index d01558a2d9..a8e84806b5 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system_posix.ts +++ b/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system_posix.ts @@ -25,8 +25,8 @@ export class MockFileSystemPosix extends MockFileSystem { return this.normalize(p.posix.join(basePath, ...paths)) as T; } - relative(from: T, to: T): PathSegment { - return this.normalize(p.posix.relative(from, to)) as PathSegment; + relative(from: T, to: T): PathSegment|AbsoluteFsPath { + return this.normalize(p.posix.relative(from, to)) as PathSegment | AbsoluteFsPath; } basename(filePath: string, extension?: string): PathSegment { diff --git a/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system_windows.ts b/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system_windows.ts index 1102166075..a34a7f61b9 100644 --- a/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system_windows.ts +++ b/packages/compiler-cli/src/ngtsc/file_system/testing/src/mock_file_system_windows.ts @@ -25,8 +25,8 @@ export class MockFileSystemWindows extends MockFileSystem { return this.normalize(p.win32.join(basePath, ...paths)) as T; } - relative(from: T, to: T): PathSegment { - return this.normalize(p.win32.relative(from, to)) as PathSegment; + relative(from: T, to: T): PathSegment|AbsoluteFsPath { + return this.normalize(p.win32.relative(from, to)) as PathSegment | AbsoluteFsPath; } basename(filePath: string, extension?: string): PathSegment { diff --git a/packages/compiler-cli/src/ngtsc/imports/src/emitter.ts b/packages/compiler-cli/src/ngtsc/imports/src/emitter.ts index 7bf63a214c..2fa42012c8 100644 --- a/packages/compiler-cli/src/ngtsc/imports/src/emitter.ts +++ b/packages/compiler-cli/src/ngtsc/imports/src/emitter.ts @@ -9,7 +9,7 @@ import {Expression, ExternalExpr, ExternalReference, WrappedNodeExpr} from '@ang import * as ts from 'typescript'; import {UnifiedModulesHost} from '../../core/api'; -import {absoluteFromSourceFile, dirname, LogicalFileSystem, LogicalProjectPath, PathSegment, relative} from '../../file_system'; +import {absoluteFromSourceFile, dirname, LogicalFileSystem, LogicalProjectPath, relative, toRelativeImport} from '../../file_system'; import {stripExtension} from '../../file_system/src/util'; import {ReflectionHost} from '../../reflection'; import {getSourceFile, isDeclaration, isTypeDeclaration, nodeNameForError} from '../../util/src/typescript'; @@ -269,11 +269,9 @@ export class RelativePathStrategy implements ReferenceEmitStrategy { emit(ref: Reference, context: ts.SourceFile): Expression|null { const destSf = getSourceFile(ref.node); - let moduleName = stripExtension( - relative(dirname(absoluteFromSourceFile(context)), absoluteFromSourceFile(destSf))); - if (!moduleName.startsWith('../')) { - moduleName = ('./' + moduleName) as PathSegment; - } + const relativePath = + relative(dirname(absoluteFromSourceFile(context)), absoluteFromSourceFile(destSf)); + const moduleName = toRelativeImport(stripExtension(relativePath)); const name = findExportedNameOfNode(ref.node, destSf, this.reflector); return new ExternalExpr({moduleName, name}); diff --git a/packages/compiler-cli/src/ngtsc/util/src/path.ts b/packages/compiler-cli/src/ngtsc/util/src/path.ts index 37f90e6662..81bf17f5a9 100644 --- a/packages/compiler-cli/src/ngtsc/util/src/path.ts +++ b/packages/compiler-cli/src/ngtsc/util/src/path.ts @@ -5,23 +5,12 @@ * Use of this source code is governed by an MIT-style license that can be * found in the LICENSE file at https://angular.io/license */ -import {dirname, relative, resolve} from '../../file_system'; - -const TS_DTS_JS_EXTENSION = /(?:\.d)?\.ts$|\.js$/; +import {dirname, relative, resolve, toRelativeImport} from '../../file_system'; +import {stripExtension} from '../../file_system/src/util'; export function relativePathBetween(from: string, to: string): string|null { - let relativePath = relative(dirname(resolve(from)), resolve(to)).replace(TS_DTS_JS_EXTENSION, ''); - - if (relativePath === '') { - return null; - } - - // path.relative() does not include the leading './'. - if (!relativePath.startsWith('.')) { - relativePath = `./${relativePath}`; - } - - return relativePath; + const relativePath = stripExtension(relative(dirname(resolve(from)), resolve(to))); + return relativePath !== '' ? toRelativeImport(relativePath) : null; } export function normalizeSeparators(path: string): string { diff --git a/packages/compiler-cli/test/ngtsc/env.ts b/packages/compiler-cli/test/ngtsc/env.ts index 281ec58a88..dcf3a3f25d 100644 --- a/packages/compiler-cli/test/ngtsc/env.ts +++ b/packages/compiler-cli/test/ngtsc/env.ts @@ -12,7 +12,7 @@ import * as ts from 'typescript'; import {createCompilerHost, createProgram} from '../../index'; import {main, mainDiagnosticsForTest, readNgcCommandLineAndConfiguration} from '../../src/main'; -import {absoluteFrom, AbsoluteFsPath, FileSystem, getFileSystem, NgtscCompilerHost} from '../../src/ngtsc/file_system'; +import {absoluteFrom, AbsoluteFsPath, FileSystem, getFileSystem, NgtscCompilerHost, relativeFrom} from '../../src/ngtsc/file_system'; import {Folder, MockFileSystem} from '../../src/ngtsc/file_system/testing'; import {IndexedComponent} from '../../src/ngtsc/indexer'; import {NgtscProgram} from '../../src/ngtsc/program'; @@ -274,7 +274,8 @@ const ROOT_PREFIX = 'root/'; class FileNameToModuleNameHost extends AugmentedCompilerHost { fileNameToModuleName(importedFilePath: string): string { - const relativeFilePath = this.fs.relative(this.fs.pwd(), this.fs.resolve(importedFilePath)); + const relativeFilePath = + relativeFrom(this.fs.relative(this.fs.pwd(), this.fs.resolve(importedFilePath))); const rootedPath = this.fs.join('root', relativeFilePath); return rootedPath.replace(/(\.d)?.ts$/, ''); } diff --git a/packages/localize/src/tools/src/translate/asset_files/asset_translation_handler.ts b/packages/localize/src/tools/src/translate/asset_files/asset_translation_handler.ts index 2a2d6c0501..97ae7ba8a6 100644 --- a/packages/localize/src/tools/src/translate/asset_files/asset_translation_handler.ts +++ b/packages/localize/src/tools/src/translate/asset_files/asset_translation_handler.ts @@ -17,14 +17,14 @@ import {TranslationBundle, TranslationHandler} from '../translator'; export class AssetTranslationHandler implements TranslationHandler { constructor(private fs: FileSystem) {} - canTranslate(_relativeFilePath: PathSegment, _contents: Buffer): boolean { + canTranslate(_relativeFilePath: PathSegment|AbsoluteFsPath, _contents: Buffer): boolean { return true; } translate( - diagnostics: Diagnostics, _sourceRoot: AbsoluteFsPath, relativeFilePath: PathSegment, - contents: Buffer, outputPathFn: OutputPathFn, translations: TranslationBundle[], - sourceLocale?: string): void { + diagnostics: Diagnostics, _sourceRoot: AbsoluteFsPath, + relativeFilePath: PathSegment|AbsoluteFsPath, contents: Buffer, outputPathFn: OutputPathFn, + translations: TranslationBundle[], sourceLocale?: string): void { for (const translation of translations) { this.writeAssetFile( diagnostics, outputPathFn, translation.locale, relativeFilePath, contents); @@ -36,7 +36,7 @@ export class AssetTranslationHandler implements TranslationHandler { private writeAssetFile( diagnostics: Diagnostics, outputPathFn: OutputPathFn, locale: string, - relativeFilePath: PathSegment, contents: Buffer): void { + relativeFilePath: PathSegment|AbsoluteFsPath, contents: Buffer): void { try { const outputPath = absoluteFrom(outputPathFn(locale, relativeFilePath)); this.fs.ensureDir(this.fs.dirname(outputPath)); diff --git a/packages/localize/src/tools/src/translate/source_files/source_file_translation_handler.ts b/packages/localize/src/tools/src/translate/source_files/source_file_translation_handler.ts index 4e13c9b672..4d1e6cc763 100644 --- a/packages/localize/src/tools/src/translate/source_files/source_file_translation_handler.ts +++ b/packages/localize/src/tools/src/translate/source_files/source_file_translation_handler.ts @@ -5,7 +5,7 @@ * Use of this source code is governed by an MIT-style license that can be * found in the LICENSE file at https://angular.io/license */ -import {absoluteFrom, AbsoluteFsPath, FileSystem, PathSegment, relativeFrom} from '@angular/compiler-cli/src/ngtsc/file_system'; +import {absoluteFrom, AbsoluteFsPath, FileSystem, PathSegment} from '@angular/compiler-cli/src/ngtsc/file_system'; import {parseSync, transformFromAstSync} from '@babel/core'; import {File, Program} from '@babel/types'; @@ -27,8 +27,8 @@ export class SourceFileTranslationHandler implements TranslationHandler { TranslatePluginOptions = {...this.translationOptions, missingTranslation: 'ignore'}; constructor(private fs: FileSystem, private translationOptions: TranslatePluginOptions = {}) {} - canTranslate(relativeFilePath: PathSegment, _contents: Buffer): boolean { - return this.fs.extname(relativeFrom(relativeFilePath)) === '.js'; + canTranslate(relativeFilePath: PathSegment|AbsoluteFsPath, _contents: Buffer): boolean { + return this.fs.extname(relativeFilePath) === '.js'; } translate( diff --git a/packages/localize/src/tools/src/translate/translator.ts b/packages/localize/src/tools/src/translate/translator.ts index 5b95ff94ea..a72e1d87bb 100644 --- a/packages/localize/src/tools/src/translate/translator.ts +++ b/packages/localize/src/tools/src/translate/translator.ts @@ -35,7 +35,7 @@ export interface TranslationHandler { * @param relativeFilePath A relative path from the sourceRoot to the resource file to handle. * @param contents The contents of the file to handle. */ - canTranslate(relativeFilePath: PathSegment, contents: Buffer): boolean; + canTranslate(relativeFilePath: PathSegment|AbsoluteFsPath, contents: Buffer): boolean; /** * Translate the file at `relativeFilePath` containing `contents`, using the given `translations`, @@ -53,9 +53,9 @@ export interface TranslationHandler { * stripped out. */ translate( - diagnostics: Diagnostics, sourceRoot: AbsoluteFsPath, relativeFilePath: PathSegment, - contents: Buffer, outputPathFn: OutputPathFn, translations: TranslationBundle[], - sourceLocale?: string): void; + diagnostics: Diagnostics, sourceRoot: AbsoluteFsPath, + relativeFilePath: PathSegment|AbsoluteFsPath, contents: Buffer, outputPathFn: OutputPathFn, + translations: TranslationBundle[], sourceLocale?: string): void; } /**