honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(compiler): don’t throw for empty array literal in assignments (#14878)

Browse Source 
Closes #14782
This commit is contained in:
Tobias Bosch 2017-03-06 17:01:45 -08:00 committed by Chuck Jazdzewski
parent 6bc6482765
commit 6cd3326b55
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/@angular/compiler/src/expression_parser/ast.ts
View File

@ -320,7 +320,7 @@ export class AstTransformer implements AstVisitor {
} }
visitPropertyWrite(ast: PropertyWrite, context: any): AST { visitPropertyWrite(ast: PropertyWrite, context: any): AST {
return new PropertyWrite(ast.span, ast.receiver.visit(this), ast.name, ast.value); return new PropertyWrite(ast.span, ast.receiver.visit(this), ast.name, ast.value.visit(this));
} }
visitSafePropertyRead(ast: SafePropertyRead, context: any): AST { visitSafePropertyRead(ast: SafePropertyRead, context: any): AST {

8
modules/@angular/core/test/linker/change_detection_integration_spec.ts
View File

@ -619,6 +619,14 @@ export function main() {
expect(ctx.componentInstance.a).toEqual(2); expect(ctx.componentInstance.a).toEqual(2);
})); }));
it('should support empty literals', fakeAsync(() => {
const ctx = _bindSimpleProp('(event)="a=[{},[]]"');
const childEl = ctx.debugElement.children[0];
childEl.triggerEventHandler('event', 'EVENT');
expect(ctx.componentInstance.a).toEqual([{}, []]);
}));
it('should throw when trying to assign to a local', fakeAsync(() => { it('should throw when trying to assign to a local', fakeAsync(() => {
expect(() => { expect(() => {
_bindSimpleProp('(event)="$event=1"'); _bindSimpleProp('(event)="$event=1"');