From 6d7d2e439c9d3fbdb29973c814aaf3a734b28a9e Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Fri, 22 Nov 2019 12:17:20 -0800 Subject: [PATCH] build: remove remaining internal references to define=compile flag (#33983) Now that all compile decisions are determined by the define=angular_ivy_enabled flag, we can remove the setting of the define=compile flag throughout the repo. PR Close #33983 --- .bazelrc | 4 +--- integration/bazel/.bazelrc | 1 - packages/bazel/src/builders/files/__dot__bazelrc.template | 1 - 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.bazelrc b/.bazelrc index e72a141453..49d20925c2 100644 --- a/.bazelrc +++ b/.bazelrc @@ -69,9 +69,7 @@ test --test_output=errors build --define=angular_ivy_enabled=False build:view-engine --define=angular_ivy_enabled=False -build:ivy --define=angular_ivy_enabled=True --define=compile=aot - -build --define=compile=legacy +build:ivy --define=angular_ivy_enabled=True ################################## # Remote Build Execution support # diff --git a/integration/bazel/.bazelrc b/integration/bazel/.bazelrc index 6a605f64fb..0101e9a988 100644 --- a/integration/bazel/.bazelrc +++ b/integration/bazel/.bazelrc @@ -14,7 +14,6 @@ build --local_resources=14336,8.0,1.0 # Use the Angular Ivy compiler # See https://github.com/angular/angular/blob/master/docs/BAZEL.md#various-flags-used-for-tests build --define=angular_ivy_enabled=True -build --define=compile=aot # Temporary define while angular depends on the legacy rollup_bundle rule. # TODO: remove this setting after https://github.com/angular/angular/pull/33201 lands. diff --git a/packages/bazel/src/builders/files/__dot__bazelrc.template b/packages/bazel/src/builders/files/__dot__bazelrc.template index 69c05f64fe..5ab593b4e4 100644 --- a/packages/bazel/src/builders/files/__dot__bazelrc.template +++ b/packages/bazel/src/builders/files/__dot__bazelrc.template @@ -29,7 +29,6 @@ test --test_output=errors # Use the Angular Ivy compiler # See https://github.com/angular/angular/blob/master/docs/BAZEL.md#various-flags-used-for-tests -build --define=compile=aot build --define=angular_ivy_enabled=True # Temporary define while angular depends on the legacy rollup_bundle rule.