From 7059f7af11f1369f03c3740f2e18197dca51f9cd Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Fri, 6 Sep 2019 11:36:36 +0200 Subject: [PATCH] ci: exclude dev-app subpackage targets in material-unit-tests job (#32485) Ensures that the `material-unit-tests` job does not accidentally build subpackages of the `src/dev-app` in the components repo. This is now an issue because the components repository updated their dev-app to use Bazel with more individual subpackages. These subpackages are not excluded by the `--deleted_packages` flag. For best practice, we should use the exclusion target pattern instead of the undocumented `--deleted_packages` flag anyway. PR Close #32485 --- scripts/ci/run_angular_material_unit_tests.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/ci/run_angular_material_unit_tests.sh b/scripts/ci/run_angular_material_unit_tests.sh index c1ee7b81a6..025d1b3cf8 100755 --- a/scripts/ci/run_angular_material_unit_tests.sh +++ b/scripts/ci/run_angular_material_unit_tests.sh @@ -31,6 +31,6 @@ yarn --cwd ${MATERIAL_REPO_TMP_DIR} add ${angular_dir}/dist/packages-dist-ivy-ao # Create a symlink for the Bazel binary installed through NPM, as running through Yarn introduces OOM errors. ./scripts/circleci/setup_bazel_binary.sh -# Now actually run the tests. The dev-app target is excluded as it fails to compile due to -# limitations in Ivy's type checker (see FW-1352 and FW-1433) -bazel test src/... --deleted_packages=//src/dev-app --build_tag_filters=-docs-package,-e2e,-browser:firefox-local --test_tag_filters=-e2e,-browser:firefox-local --define=compile=aot +# Now actually run the tests. The dev-app and all its subpackages are excluded as they fail +# to compile due to limitations in Ivy's type checker (see FW-1352 and FW-1433) +bazel test --build_tag_filters=-docs-package,-e2e,-browser:firefox-local --test_tag_filters=-e2e,-browser:firefox-local --define=compile=aot -- src/... -src/dev-app/...