honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf(ivy): avoid repeat lview reads in pipe instructions (#32633) 

All of the `pipeBind` instructions call into `isPure` and `unwrapValue` which in turn call `getLView` internally. These internal calls are redundant, because we already have the `LView` from the `load` calls just before it.

PR Close #32633
This commit is contained in:
Kristiyan Kostadinov 2019-09-12 12:44:55 +02:00 committed by Kara Erickson
parent 527ce3b142
commit 73cb581728
1 changed files with 25 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
packages/core/src/render3/pipe.ts
View File

@ -12,7 +12,7 @@ import {PipeTransform} from '../change_detection/pipe_transform';
import {getFactoryDef} from './definition'; import {getFactoryDef} from './definition';
import {store} from './instructions/all'; import {store} from './instructions/all';
import {PipeDef, PipeDefList} from './interfaces/definition'; import {PipeDef, PipeDefList} from './interfaces/definition';
import {BINDING_INDEX, HEADER_OFFSET, TVIEW} from './interfaces/view'; import {BINDING_INDEX, HEADER_OFFSET, LView, TVIEW} from './interfaces/view';
import {ɵɵpureFunction1, ɵɵpureFunction2, ɵɵpureFunction3, ɵɵpureFunction4, ɵɵpureFunctionV} from './pure_function'; import {ɵɵpureFunction1, ɵɵpureFunction2, ɵɵpureFunction3, ɵɵpureFunction4, ɵɵpureFunctionV} from './pure_function';
import {getLView} from './state'; import {getLView} from './state';
import {NO_CHANGE} from './tokens'; import {NO_CHANGE} from './tokens';
@ -85,9 +85,11 @@ function getPipeDef(name: string, registry: PipeDefList | null): PipeDef<any> {
* @codeGenApi * @codeGenApi
*/ */
export function ɵɵpipeBind1(index: number, slotOffset: number, v1: any): any { export function ɵɵpipeBind1(index: number, slotOffset: number, v1: any): any {
const pipeInstance = load<PipeTransform>(getLView(), index); const lView = getLView();
const pipeInstance = load<PipeTransform>(lView, index);
return unwrapValue( return unwrapValue(
isPure(index) ? ɵɵpureFunction1(slotOffset, pipeInstance.transform, v1, pipeInstance) : lView, isPure(lView, index) ?
ɵɵpureFunction1(slotOffset, pipeInstance.transform, v1, pipeInstance) :
pipeInstance.transform(v1)); pipeInstance.transform(v1));
} }
@ -105,9 +107,11 @@ export function ɵɵpipeBind1(index: number, slotOffset: number, v1: any): any {
* @codeGenApi * @codeGenApi
*/ */
export function ɵɵpipeBind2(index: number, slotOffset: number, v1: any, v2: any): any { export function ɵɵpipeBind2(index: number, slotOffset: number, v1: any, v2: any): any {
const pipeInstance = load<PipeTransform>(getLView(), index); const lView = getLView();
const pipeInstance = load<PipeTransform>(lView, index);
return unwrapValue( return unwrapValue(
isPure(index) ? ɵɵpureFunction2(slotOffset, pipeInstance.transform, v1, v2, pipeInstance) : lView, isPure(lView, index) ?
ɵɵpureFunction2(slotOffset, pipeInstance.transform, v1, v2, pipeInstance) :
pipeInstance.transform(v1, v2)); pipeInstance.transform(v1, v2));
} }
@ -126,9 +130,10 @@ export function ɵɵpipeBind2(index: number, slotOffset: number, v1: any, v2: an
* @codeGenApi * @codeGenApi
*/ */
export function ɵɵpipeBind3(index: number, slotOffset: number, v1: any, v2: any, v3: any): any { export function ɵɵpipeBind3(index: number, slotOffset: number, v1: any, v2: any, v3: any): any {
const pipeInstance = load<PipeTransform>(getLView(), index); const lView = getLView();
const pipeInstance = load<PipeTransform>(lView, index);
return unwrapValue( return unwrapValue(
isPure(index) ? lView, isPure(lView, index) ?
ɵɵpureFunction3(slotOffset, pipeInstance.transform, v1, v2, v3, pipeInstance) : ɵɵpureFunction3(slotOffset, pipeInstance.transform, v1, v2, v3, pipeInstance) :
pipeInstance.transform(v1, v2, v3)); pipeInstance.transform(v1, v2, v3));
} }
@ -150,9 +155,10 @@ export function ɵɵpipeBind3(index: number, slotOffset: number, v1: any, v2: an
*/ */
export function ɵɵpipeBind4( export function ɵɵpipeBind4(
index: number, slotOffset: number, v1: any, v2: any, v3: any, v4: any): any { index: number, slotOffset: number, v1: any, v2: any, v3: any, v4: any): any {
const pipeInstance = load<PipeTransform>(getLView(), index); const lView = getLView();
const pipeInstance = load<PipeTransform>(lView, index);
return unwrapValue( return unwrapValue(
isPure(index) ? lView, isPure(lView, index) ?
ɵɵpureFunction4(slotOffset, pipeInstance.transform, v1, v2, v3, v4, pipeInstance) : ɵɵpureFunction4(slotOffset, pipeInstance.transform, v1, v2, v3, v4, pipeInstance) :
pipeInstance.transform(v1, v2, v3, v4)); pipeInstance.transform(v1, v2, v3, v4));
} }
@ -170,14 +176,16 @@ export function ɵɵpipeBind4(
* @codeGenApi * @codeGenApi
*/ */
export function ɵɵpipeBindV(index: number, slotOffset: number, values: [any, ...any[]]): any { export function ɵɵpipeBindV(index: number, slotOffset: number, values: [any, ...any[]]): any {
const pipeInstance = load<PipeTransform>(getLView(), index); const lView = getLView();
const pipeInstance = load<PipeTransform>(lView, index);
return unwrapValue( return unwrapValue(
isPure(index) ? ɵɵpureFunctionV(slotOffset, pipeInstance.transform, values, pipeInstance) : lView, isPure(lView, index) ?
ɵɵpureFunctionV(slotOffset, pipeInstance.transform, values, pipeInstance) :
pipeInstance.transform.apply(pipeInstance, values)); pipeInstance.transform.apply(pipeInstance, values));
} }
function isPure(index: number): boolean { function isPure(lView: LView, index: number): boolean {
return (<PipeDef<any>>getLView()[TVIEW].data[index + HEADER_OFFSET]).pure; return (<PipeDef<any>>lView[TVIEW].data[index + HEADER_OFFSET]).pure;
} }
/** /**
@ -187,10 +195,9 @@ function isPure(index: number): boolean {
* *
* @param newValue the pipe transformation output. * @param newValue the pipe transformation output.
*/ */
function unwrapValue(newValue: any): any { function unwrapValue(lView: LView, newValue: any): any {
if (WrappedValue.isWrapped(newValue)) { if (WrappedValue.isWrapped(newValue)) {
newValue = WrappedValue.unwrap(newValue); newValue = WrappedValue.unwrap(newValue);
const lView = getLView();
// The NO_CHANGE value needs to be written at the index where the impacted binding value is // The NO_CHANGE value needs to be written at the index where the impacted binding value is
// stored // stored
const bindingToInvalidateIdx = lView[BINDING_INDEX]; const bindingToInvalidateIdx = lView[BINDING_INDEX];