honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(ivy): move error-handling test to be handled at a later stage (#28212) 

Due to the fast moving nature of the Ivy codebase, the timing isn't
right to make changes to how errors and reported and handled during the
runtime.

Once ivy is stable this test should be revisted because that stage there
will be a better and more robust understanding of how ivy should recover
from runtime errors.

Jira Issue: FW-952

PR Close #28212
This commit is contained in:
Matias Niemelä 2019-01-17 11:29:49 -08:00 committed by Jason Aden
parent 7496630a94
commit 7421534873
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/test/animation/animation_integration_spec.ts
View File

@ -13,7 +13,7 @@ import {TestBed, fakeAsync, flushMicrotasks} from '@angular/core/testing';
import {ɵDomRendererFactory2} from '@angular/platform-browser'; import {ɵDomRendererFactory2} from '@angular/platform-browser';
import {ANIMATION_MODULE_TYPE, BrowserAnimationsModule, NoopAnimationsModule} from '@angular/platform-browser/animations'; import {ANIMATION_MODULE_TYPE, BrowserAnimationsModule, NoopAnimationsModule} from '@angular/platform-browser/animations';
import {getDOM} from '@angular/platform-browser/src/dom/dom_adapter'; import {getDOM} from '@angular/platform-browser/src/dom/dom_adapter';
import {fixmeIvy, ivyEnabled} from '@angular/private/testing'; import {ivyEnabled, modifiedInIvy} from '@angular/private/testing';
const DEFAULT_NAMESPACE_ID = 'id'; const DEFAULT_NAMESPACE_ID = 'id';
const DEFAULT_COMPONENT_ID = '1'; const DEFAULT_COMPONENT_ID = '1';
@ -3660,7 +3660,7 @@ const DEFAULT_COMPONENT_ID = '1';
expect(() => { TestBed.createComponent(Cmp); }).not.toThrowError(); expect(() => { TestBed.createComponent(Cmp); }).not.toThrowError();
}); });
fixmeIvy('FW-952 - Error recovery is handled differently in Ivy than VE') modifiedInIvy('FW-952 - Error recovery is handled differently in Ivy than VE')
.it('should continue to clean up DOM-related animation artificats even if a compiler-level error is thrown midway', .it('should continue to clean up DOM-related animation artificats even if a compiler-level error is thrown midway',
() => { () => {
@Component({ @Component({