ci: migrate payload size tracking goldens to the golden directory (#36455)

This change is part of a larger effort to migrate all golden type
tracking files to a single location.  Additionally, this makes it
a bit easier to manage file ownership in pullapprove.

PR Close #36455
This commit is contained in:
Joey Perrott 2020-04-06 09:42:02 -07:00 committed by Andrew Kushnir
parent dd049caf0a
commit 76190c71fc
9 changed files with 10 additions and 11 deletions

View File

@ -1031,8 +1031,7 @@ groups:
- *can-be-global-approved - *can-be-global-approved
- > - >
contains_any_globs(files, [ contains_any_globs(files, [
'aio/scripts/_payload-limits.json', 'goldens/size-tracking/**'
'integration/_payload-limits.json'
]) ])
reviewers: reviewers:
users: users:

View File

@ -12,4 +12,4 @@ source ../scripts/ci/payload-size.sh
# Provide node_modules from aio # Provide node_modules from aio
NODE_MODULES_BIN=$PROJECT_ROOT/aio/node_modules/.bin/ NODE_MODULES_BIN=$PROJECT_ROOT/aio/node_modules/.bin/
trackPayloadSize "$target" "dist/*.js" true "${thisDir}/_payload-limits.json" trackPayloadSize "$target" "dist/*.js" true "$PROJECT_ROOT/goldens/size-tracking/aio-payloads.json"

View File

@ -1,5 +1,9 @@
package(default_visibility = ["//visibility:public"]) package(default_visibility = ["//visibility:public"])
exports_files([
"size-tracking/integration-payloads.json",
])
filegroup( filegroup(
name = "public-api", name = "public-api",
srcs = glob([ srcs = glob([

View File

@ -1,9 +1,5 @@
load(":angular_integration_test.bzl", "angular_integration_test") load(":angular_integration_test.bzl", "angular_integration_test")
exports_files([
"_payload-limits.json",
])
# Some integration ports must be managed manually to be unique and in other # Some integration ports must be managed manually to be unique and in other
# cases the tests are able to select a random free port. # cases the tests are able to select a random free port.
# #

View File

@ -108,10 +108,10 @@ def _angular_integration_test(name, **kwargs):
elif commands == "payload_size_tracking": elif commands == "payload_size_tracking":
commands = DEFAULT_COMMANDS + [ commands = DEFAULT_COMMANDS + [
"$(rootpath @nodejs//:yarn_bin) build", "$(rootpath @nodejs//:yarn_bin) build",
"$(rootpath //:scripts/ci/track-payload-size.sh) %s dist/*.js true ${RUNFILES}/angular/$(rootpath //integration:_payload-limits.json)" % name, "$(rootpath //:scripts/ci/track-payload-size.sh) %s dist/*.js true ${RUNFILES}/angular/$(rootpath //goldens:size-tracking/integration-payloads.json)" % name,
] ]
data = data + [ data = data + [
"//integration:_payload-limits.json", "//goldens:size-tracking/integration-payloads.json",
"//:scripts/ci/track-payload-size.sh", "//:scripts/ci/track-payload-size.sh",
"//:scripts/ci/payload-size.sh", "//:scripts/ci/payload-size.sh",
"//:scripts/ci/payload-size.js", "//:scripts/ci/payload-size.js",

View File

@ -2,4 +2,4 @@
This test checks bundle sizes when there is a lazy module and experimentalRollupPass is used. It also checks if the `ngDevMode` global variable and string references in `packages/core/src/util/ng_dev_mode.ts` are correctly removed. This test checks bundle sizes when there is a lazy module and experimentalRollupPass is used. It also checks if the `ngDevMode` global variable and string references in `packages/core/src/util/ng_dev_mode.ts` are correctly removed.
This test contains a lazy route to ensure `ngDevMode` removal happens even across chunks, and a payload size check in `../_payload-limits.json` to ensure extra code is not retained accidentally. This test contains a lazy route to ensure `ngDevMode` removal happens even across chunks, and a payload size check in `/goldens/size-tracking/integration-payloads.json` to ensure extra code is not retained accidentally.

View File

@ -2,4 +2,4 @@
This test checks bundle sizes when there is a lazy module. It also checks if the `ngDevMode` global variable and string references in `packages/core/src/util/ng_dev_mode.ts` are correctly removed. This test checks bundle sizes when there is a lazy module. It also checks if the `ngDevMode` global variable and string references in `packages/core/src/util/ng_dev_mode.ts` are correctly removed.
This test contains a lazy route to ensure `ngDevMode` removal happens even across chunks, and a payload size check in `../_payload-limits.json` to ensure extra code is not retained accidentally. This test contains a lazy route to ensure `ngDevMode` removal happens even across chunks, and a payload size check in `/goldens/size-tracking/integration-payloads.json` to ensure extra code is not retained accidentally.