From 77c0ef38bea2bbb54d30419da8a94a97e1d76997 Mon Sep 17 00:00:00 2001 From: Santosh Yadav Date: Wed, 13 May 2020 00:59:11 +0530 Subject: [PATCH] docs(router): filter the event to subscribe (#37027) The current code will not work as the `e` will be an event, If we try to access e.id and e.url it will throw an exception, the correct way is to use map or filter down to specific events PR Close #37027 --- packages/router/src/events.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/router/src/events.ts b/packages/router/src/events.ts index 0cf8dc6415..2dd1ca6fba 100644 --- a/packages/router/src/events.ts +++ b/packages/router/src/events.ts @@ -30,8 +30,8 @@ export type NavigationTrigger = 'imperative'|'popstate'|'hashchange'; * class MyService { * constructor(public router: Router, logger: Logger) { * router.events.pipe( - * filter(e => e instanceof RouterEvent) - * ).subscribe(e => { + * filter((e: Event): e is RouterEvent => e instanceof RouterEvent) + * ).subscribe((e: RouterEvent) => { * logger.log(e.id, e.url); * }); * }