honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(compiler-cli): ngcc - remove outdated link (#40285) 

The link to the "speeding-up-ngcc-compilation" URL does not exist,
it was removed shortly after it was added, but the link in the ngcc
error message was not updated.

Fixes #39837

PR Close #40285
This commit is contained in:
Pete Bacon Darwin 2020-12-31 11:20:13 +00:00 committed by Joey Perrott
parent f846c093b1
commit 7c167629b8
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/compiler-cli/ngcc/src/locking/sync_locker.ts
View File

@ -54,8 +54,7 @@ export class SyncLocker {
const pid = this.lockFile.read(); const pid = this.lockFile.read();
throw new Error( throw new Error(
`ngcc is already running at process with id ${pid}.\n` + `ngcc is already running at process with id ${pid}.\n` +
`If you are running multiple builds in parallel then you should pre-process your node_modules via the command line ngcc tool before starting the builds;\n` + `If you are running multiple builds in parallel then you might try pre-processing your node_modules via the command line ngcc tool before starting the builds.\n` +
`See https://v9.angular.io/guide/ivy#speeding-up-ngcc-compilation.\n` +
`(If you are sure no ngcc process is running then you should delete the lock-file at ${ `(If you are sure no ngcc process is running then you should delete the lock-file at ${
this.lockFile.path}.)`); this.lockFile.path}.)`);
} }

3
packages/compiler-cli/ngcc/test/locking/sync_locker_spec.ts
View File

@ -58,8 +58,7 @@ runInEachFileSystem(() => {
expect(() => locker.lock(() => {})) expect(() => locker.lock(() => {}))
.toThrowError( .toThrowError(
`ngcc is already running at process with id 188.\n` + `ngcc is already running at process with id 188.\n` +
`If you are running multiple builds in parallel then you should pre-process your node_modules via the command line ngcc tool before starting the builds;\n` + `If you are running multiple builds in parallel then you might try pre-processing your node_modules via the command line ngcc tool before starting the builds.\n` +
`See https://v9.angular.io/guide/ivy#speeding-up-ngcc-compilation.\n` +
`(If you are sure no ngcc process is running then you should delete the lock-file at ${ `(If you are sure no ngcc process is running then you should delete the lock-file at ${
lockFile.path}.)`); lockFile.path}.)`);
}); });