honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(dev-infra): remove unused argument from `publish` script (#41688) 

Since recently, the `githubToken` parameter passed to the `ReleaseTool`
constructor is no longer used. This commit removes the unused parameter
and also the corresponding argument from the `publish` script.

PR Close #41688
This commit is contained in:
George Kalpakas 2021-04-18 12:46:57 +03:00 committed by Andrew Kushnir
parent 8058396c52
commit 7c353d452e
3 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dev-infra/ng-dev.js
View File

@ -6619,10 +6619,9 @@ var CompletionState;
CompletionState[CompletionState["MANUALLY_ABORTED"] = 2] = "MANUALLY_ABORTED"; CompletionState[CompletionState["MANUALLY_ABORTED"] = 2] = "MANUALLY_ABORTED";
})(CompletionState || (CompletionState = {})); })(CompletionState || (CompletionState = {}));
class ReleaseTool { class ReleaseTool {
constructor(_config, _github, _githubToken, _projectRoot) { constructor(_config, _github, _projectRoot) {
this._config = _config; this._config = _config;
this._github = _github; this._github = _github;
this._githubToken = _githubToken;
this._projectRoot = _projectRoot; this._projectRoot = _projectRoot;
/** The singleton instance of the GitClient. */ /** The singleton instance of the GitClient. */
this._git = GitClient.getAuthenticatedInstance(); this._git = GitClient.getAuthenticatedInstance();
@ -6782,13 +6781,13 @@ function builder$8(argv) {
return addGithubTokenOption(argv); return addGithubTokenOption(argv);
} }
/** Yargs command handler for staging a release. */ /** Yargs command handler for staging a release. */
function handler$8(args) { function handler$8() {
return tslib.__awaiter(this, void 0, void 0, function* () { return tslib.__awaiter(this, void 0, void 0, function* () {
const git = GitClient.getInstance(); const git = GitClient.getInstance();
const config = getConfig(); const config = getConfig();
const releaseConfig = getReleaseConfig(config); const releaseConfig = getReleaseConfig(config);
const projectDir = git.baseDir; const projectDir = git.baseDir;
const task = new ReleaseTool(releaseConfig, config.github, args.githubToken, projectDir); const task = new ReleaseTool(releaseConfig, config.github, projectDir);
const result = yield task.run(); const result = yield task.run();
switch (result) { switch (result) {
case CompletionState.FATAL_ERROR: case CompletionState.FATAL_ERROR:

4
dev-infra/release/publish/cli.ts
View File

@ -27,12 +27,12 @@ function builder(argv: Argv): Argv<ReleasePublishOptions> {
} }
/** Yargs command handler for staging a release. */ /** Yargs command handler for staging a release. */
async function handler(args: Arguments<ReleasePublishOptions>) { async function handler() {
const git = GitClient.getInstance(); const git = GitClient.getInstance();
const config = getConfig(); const config = getConfig();
const releaseConfig = getReleaseConfig(config); const releaseConfig = getReleaseConfig(config);
const projectDir = git.baseDir; const projectDir = git.baseDir;
const task = new ReleaseTool(releaseConfig, config.github, args.githubToken, projectDir); const task = new ReleaseTool(releaseConfig, config.github, projectDir);
const result = await task.run(); const result = await task.run();
switch (result) { switch (result) {

2
dev-infra/release/publish/index.ts
View File

@ -35,7 +35,7 @@ export class ReleaseTool {
constructor( constructor(
protected _config: ReleaseConfig, protected _github: GithubConfig, protected _config: ReleaseConfig, protected _github: GithubConfig,
protected _githubToken: string, protected _projectRoot: string) {} protected _projectRoot: string) {}
/** Runs the interactive release tool. */ /** Runs the interactive release tool. */
async run(): Promise<CompletionState> { async run(): Promise<CompletionState> {