fix(elements): schematics fails with schema.json not found error (#35211)

Fixes #35154

PR Close #35211
This commit is contained in:
Alan Agius 2020-02-07 08:51:47 +01:00 committed by Kara Erickson
parent 332937ef24
commit 7c9735a995
8 changed files with 1983 additions and 8 deletions

View File

@ -0,0 +1,2 @@
/demo
*.js

View File

@ -0,0 +1,11 @@
# Angular Elements Schematics Tests
This directory is an integration test for `@angular/elements` schematics. To ensure
that the elements schematics do work and leave the application in a working state.
To use the tests:
- Use `yarn install` to install all dependencies in this directory and in the Angular repo root
directory.
- Build an Angular distribution with `yarn build-dist`. This needs to be done after changes to
Angular, but not after changes to integration tests. This is an expensive build.
- In this directory, run the integration tests with `yarn test`.

View File

@ -0,0 +1,15 @@
{
"name": "elements-schematics",
"version": "1.0.0",
"license": "MIT",
"devDependencies": {
"@angular/cli": "file:../../node_modules/@angular/cli",
"@types/node": "file:../../node_modules/@types/node",
"typescript": "file:../../node_modules/typescript"
},
"scripts": {
"build": "tsc -p tsconfig.json",
"build-dist": "node ../../scripts/build-packages-dist.js && yarn install --check-files",
"test": "yarn build && node test.js"
}
}

View File

@ -0,0 +1,53 @@
#!/usr/bin/env node
import {cd, exec, rm, set} from 'shelljs';
// Fail on first error
set('-e');
// Install Angular packages that are built locally from HEAD.
// This also gets around the bug whereby yarn caches local `file://` urls.
// See https://github.com/yarnpkg/yarn/issues/2165
// The below packages are all required in a default CLI project.
const ngPackages = [
'animations',
'core',
'common',
'compiler',
'forms',
'platform-browser',
'platform-browser-dynamic',
'router',
'compiler-cli',
'language-service',
].map(p => `"@angular/${p}@file:${__dirname}/../../dist/packages-dist/${p}"`);
// Keep typescript, tslib, and @types/node versions in sync with the ones used in this repo
const nodePackages = [
'@types/node',
'tslib',
'typescript',
].map(p => `"${p}@file:${__dirname}/../../node_modules/${p}"`);
const packages = [
...ngPackages,
...nodePackages,
].join(' ');
// Clean up previously run test
cd(__dirname);
rm('-rf', `demo`);
// Set up demo project
exec('ng version');
exec('ng new demo --skip-git --skip-install --style=css --no-interactive');
cd('demo');
// Install Angular packages that are built locally from HEAD
exec(`yarn add --ignore-scripts --silent ${packages}`);
// Add @angular/elements
exec(`ng add "${__dirname}/../../dist/packages-dist/elements"`);
// Test that build is successful after adding elements
exec('ng build --no-source-map');

View File

@ -0,0 +1,60 @@
{
"compilerOptions": {
/* Basic Options */
"target": "es2016", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */
"module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
// "lib": [], /* Specify library files to be included in the compilation. */
// "allowJs": true, /* Allow javascript files to be compiled. */
// "checkJs": true, /* Report errors in .js files. */
// "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
// "declaration": true, /* Generates corresponding '.d.ts' file. */
// "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */
// "sourceMap": true, /* Generates corresponding '.map' file. */
// "outFile": "./", /* Concatenate and emit output to single file. */
// "outDir": "./", /* Redirect output structure to the directory. */
// "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
// "composite": true, /* Enable project compilation */
// "removeComments": true, /* Do not emit comments to output. */
// "noEmit": true, /* Do not emit outputs. */
// "importHelpers": true, /* Import emit helpers from 'tslib'. */
// "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
// "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
/* Strict Type-Checking Options */
"strict": true, /* Enable all strict type-checking options. */
// "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */
// "strictNullChecks": true, /* Enable strict null checks. */
// "strictFunctionTypes": true, /* Enable strict checking of function types. */
// "strictPropertyInitialization": true, /* Enable strict checking of property initialization in classes. */
// "noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */
// "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */
/* Additional Checks */
// "noUnusedLocals": true, /* Report errors on unused locals. */
// "noUnusedParameters": true, /* Report errors on unused parameters. */
// "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
// "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
/* Module Resolution Options */
// "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
// "baseUrl": "./", /* Base directory to resolve non-absolute module names. */
// "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
// "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */
"typeRoots": ["node_modules/@types"], /* List of folders to include type definitions from. */
// "types": [], /* Type declaration files to be included in compilation. */
// "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
"esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
// "preserveSymlinks": true, /* Do not resolve the real path of symlinks. */
/* Source Map Options */
// "sourceRoot": "", /* Specify the location where debugger should locate TypeScript files instead of source locations. */
// "mapRoot": "", /* Specify the location where debugger should locate map files instead of generated locations. */
// "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */
// "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */
/* Experimental Options */
// "experimentalDecorators": true, /* Enables experimental support for ES7 decorators. */
// "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */
},
"include": ["*.ts"]
}

File diff suppressed because it is too large Load Diff

View File

@ -4,11 +4,13 @@ package(default_visibility = ["//visibility:public"])
ts_library(
name = "ng-add",
srcs =
[
"index.ts",
"schema.ts",
],
srcs = [
"index.ts",
"schema.d.ts",
],
data = [
"schema.json",
],
deps = [
"@npm//@angular-devkit/schematics",
"@npm//@schematics/angular",
@ -21,9 +23,6 @@ ts_library(
srcs = [
"index_spec.ts",
],
data = [
"schema.json",
],
deps = [
":ng-add",
"@npm//@angular-devkit/schematics",