honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: reactivate some of the disabled tests in Edge (#10450)

This commit is contained in:
Marc Laval 2016-08-02 19:58:03 +02:00 committed by Victor Berchet
parent d6d4568830
commit 7db75fa361
3 changed files with 83 additions and 95 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/@angular/core/test/reflection/reflector_spec.ts
View File

@ -110,9 +110,6 @@ export function main() {
expect(obj.b).toEqual(2); expect(obj.b).toEqual(2);
}); });
// Makes Edge to disconnect when running the full unit test campaign
// TODO: remove when issue is solved: https://github.com/angular/angular/issues/4756
if (!browserDetection.isEdge) {
it('should check args from no to max', () => { it('should check args from no to max', () => {
var f = (t: any /** TODO #9100 */) => reflector.factory(t); var f = (t: any /** TODO #9100 */) => reflector.factory(t);
var checkArgs = (obj: any /** TODO #9100 */, args: any /** TODO #9100 */) => var checkArgs = (obj: any /** TODO #9100 */, args: any /** TODO #9100 */) =>
@ -142,7 +139,6 @@ export function main() {
checkArgs(f(TestObjWith20Args)(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20), [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20]); checkArgs(f(TestObjWith20Args)(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20), [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20]);
// clang-format on // clang-format on
}); });
}
it('should throw when more than 20 arguments', it('should throw when more than 20 arguments',
() => { expect(() => reflector.factory(TestObjWith21Args)).toThrowError(); }); () => { expect(() => reflector.factory(TestObjWith21Args)).toThrowError(); });

4
modules/@angular/facade/test/async_spec.ts
View File

@ -56,9 +56,6 @@ export function main() {
expect(called).toBe(true); expect(called).toBe(true);
}); });
// Makes Edge to disconnect when running the full unit test campaign
// TODO: remove when issue is solved: https://github.com/angular/angular/issues/4756
if (!browserDetection.isEdge) {
it('delivers next and error events synchronously', it('delivers next and error events synchronously',
inject([AsyncTestCompleter], (async: AsyncTestCompleter) => { inject([AsyncTestCompleter], (async: AsyncTestCompleter) => {
let log: any[] /** TODO #9100 */ = []; let log: any[] /** TODO #9100 */ = [];
@ -100,7 +97,6 @@ export function main() {
log.push(5); log.push(5);
expect(log).toEqual([1, 2, 3, 4, 5]); expect(log).toEqual([1, 2, 3, 4, 5]);
}); });
}
it('delivers events asynchronously when forced to async mode', it('delivers events asynchronously when forced to async mode',
inject([AsyncTestCompleter], (async: AsyncTestCompleter) => { inject([AsyncTestCompleter], (async: AsyncTestCompleter) => {

4
modules/@angular/platform-browser/test/web_workers/shared/service_message_broker_spec.ts
View File

@ -46,9 +46,6 @@ export function main() {
{'method': TEST_METHOD, 'args': [PASSED_ARG_1, PASSED_ARG_2]}); {'method': TEST_METHOD, 'args': [PASSED_ARG_1, PASSED_ARG_2]});
})); }));
// TODO(pkozlowski): this fails only in Edge with
// "No provider for RenderStore! (Serializer -> RenderStore)"
if (!browserDetection.isEdge) {
it('should return promises to the worker', inject([Serializer], (serializer: Serializer) => { it('should return promises to the worker', inject([Serializer], (serializer: Serializer) => {
var broker = new ServiceMessageBroker_(messageBuses.ui, serializer, CHANNEL); var broker = new ServiceMessageBroker_(messageBuses.ui, serializer, CHANNEL);
broker.registerMethod(TEST_METHOD, [PRIMITIVE], (arg1) => { broker.registerMethod(TEST_METHOD, [PRIMITIVE], (arg1) => {
@ -64,6 +61,5 @@ export function main() {
expect(data.value).toEqual(RESULT); expect(data.value).toEqual(RESULT);
}); });
})); }));
}
}); });
} }